From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.22868.1647424986238968268 for ; Wed, 16 Mar 2022 03:03:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O2sJe8u4; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647424985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nYo0VfLGHQaHVGdsILFqIAdsL3slDpZOOGLINjZv/J8=; b=O2sJe8u4Z/CUZISkfI0A3uq4Irsj1wYPiXuUMX5PPgceZIgb235UJImYJ/iZVO2n3fiJuT 9hlJ9YnSoXSZXvFt50JmnPNly4GftfwrYqtstbEJi1xPXxJUZw9u9BunyZAGCV9JC5RLNj ooQfQk1LyoDgKClllA61juNQJ5hDc1U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-TKI8MfWpMqixUw9kbT0CAQ-1; Wed, 16 Mar 2022 06:03:03 -0400 X-MC-Unique: TKI8MfWpMqixUw9kbT0CAQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 807D918A6581; Wed, 16 Mar 2022 10:03:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19C17C33260; Wed, 16 Mar 2022 10:03:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A35181800381; Wed, 16 Mar 2022 11:02:59 +0100 (CET) Date: Wed, 16 Mar 2022 11:02:59 +0100 From: "Gerd Hoffmann" To: Pedro Falcato Cc: edk2-devel-groups-io , Xiaoyu Lu , Bob Feng , Rebecca Cran , James Bottomley , Sami Mujawar , Jordan Justen , Erdem Aktas , Jiewen Yao , Supreeth Venkatesh , Sebastien Boeuf , Zhichao Gao , Zhiguang Liu , Maciej Rabeda , Maurice Ma , Andrew Fish , Ard Biesheuvel , Tom Lendacky , Peter Grehan , Sean Brogan , Guomin Jiang , Bret Barkelew , Yuwei Chen , Benjamin You , Daniel Schaefer , Liming Gao , Michael D Kinney , Wei6 Xu , Jian J Wang , Jiaxin Wu , Siyuan Fu , Guo Dong , kilian_kegel@hotmail.com, Abner Chang , Oliver Steffen , Leif Lindholm , Brijesh Singh , Min Xu , Ray Ni , Alexei Fedorov , Julien Grall , Nickle Wang , Pawel Polawski , Anthony Perard Subject: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics Message-ID: <20220316100259.b4jxdwfjjmaugu4t@sirius.home.kraxel.org> References: <20220301071820.3135133-1-kraxel@redhat.com> <20220315122242.xwi2xckfos2c3cff@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 15, 2022 at 05:08:55PM +0000, Pedro Falcato wrote: > Gerd, > > Have you considered just pulling in LLVM's compiler-rt builtins? It > implements essentially everything we'll ever need for a GNU-like toolchain, > for all the architectures we support, and also has unit tests ( > https://github.com/llvm/llvm-project/tree/main/compiler-rt/test/builtins/Unit > ). > > I think it would be a good idea considering it's guaranteed to be correct > and always implements whatever clang requires (and AFAIK clang always > requires what gcc requires). This is beyond the scope of this patch series, I want have a single intrinsics lib for everybody as first step. Using llvm's intrinsics certainly is an option for future improvements, assuming it is ok license-wise (edk2 is bsd, llvm compiler-rt is apache, as far I know they are compatible). take care, Gerd