From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web11.11100.1647720804498027671 for ; Sat, 19 Mar 2022 13:13:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=fm2 header.b=TG8b1nou; spf=pass (domain: bsdio.com, ip: 66.111.4.25, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D0B355C00B2; Sat, 19 Mar 2022 16:13:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 19 Mar 2022 16:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=v9ZlCx95yIdG1dcC9YUPU5ZaRS+0iA N7dpwu4hThEGA=; b=TG8b1nou4TX58WrgVqifT6+MyUl1tTaxqOypjijPmL47kx EYABzt2hdx/GhC3jxF7kv1D+wfGnYP49MYPflRcYUuMw3bRwLrT3sev7DIjAdxrn wxHc3O+ivqEZlWpuHrR60gFLJsQj6StHbFhmBC2y6MH2Nmk+dY9zZE1BgrFI8fci xLq5KZIbJwio0qq/uTNMyyZE+v+jF4buf7XxFoTCFgpwmsbqIR7viokwFXVFWHLp /IfHhPUubpZwDpPIoIWocAey4f7sp4n2/zJG1QcQi2F+G82Y3MDK3M9CfFd6BxXm xVFW6jz/hrLSF4PzJR6nQcf+ltuteVtWB0oPagrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=v9ZlCx 95yIdG1dcC9YUPU5ZaRS+0iAN7dpwu4hThEGA=; b=A3Cak1i/2skZF2G04SNqmI BJNzDt6PNjWhGEr9wWSyVPo/6i8676vAVtKVpqmGXyrX3dC7N28rY0AAQHyfjFev 2zrh3X2jusj/3aEQLC88s7AJpraAd/DkTmkAYCQqUzO8Z3cD8/gLZeqx8FXFdm/e LtemU2gNFSfZ99v0Le5tTmoyYdPa/5j7GNgF3vLLmxkkxIEtIZwS8iS8JjnEMbeV Ws3PlSBbS271hF3dnkqr8MF4gRBdHCmkhpZEtbv4XlCYzuUCDiimxe9WYlrX2Vh/ fc+ruqPuJXQngu4J4dQLFD3QQg/eCeD8kYKNByyAvDnEHWcsFkztaMZTsLlxuU7w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefkedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepveejhfefieeuffevfefhkeeggfdvfffgheejledtgfelieeuueeujeeikeeh lefhnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Mar 2022 16:13:23 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , Sami Mujawar Cc: Rebecca Cran Subject: [PATCH edk2-platforms v2 3/3] Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device Date: Sat, 19 Mar 2022 14:13:12 -0600 Message-Id: <20220319201312.158506-4-rebecca@bsdio.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220319201312.158506-1-rebecca@bsdio.com> References: <20220319201312.158506-1-rebecca@bsdio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a RES0 device to the SSDT to reserve the PCI ECAM area. This fixes the warning that Linux prints: acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x40000000-0x4fffffff] not reserved in ACPI namespace With this change, the "Firmware Bug" message is no longer printed, but a different warning is displayed: "system 00:00: [mem 0x40000000-0x4fffffff window] could not be reserved" It appears this is a harmless message though: a discussion about it can be seen at https://lore.kernel.org/all/20210603141641.GA17284@lpieralisi/#t Signed-off-by: Rebecca Cran Tested-by: Sami Mujawar Reviewed-by: Sami Mujawar --- Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf | 4 ++++ Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf b/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf index f140febc4ad4..9a76475765f0 100644 --- a/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf +++ b/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf @@ -45,6 +45,10 @@ [FixedPcd] gArmTokenSpaceGuid.PcdGenericWatchdogControlBase gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceLimit + # # PL011 UART Settings for Serial Port Console Redirection # diff --git a/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl b/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl index 317b621e013e..e60fc42a3340 100644 --- a/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl +++ b/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl @@ -140,6 +140,19 @@ DefinitionBlock("SsdtPci.aml", "SSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_OEM Return (RBUF) } // Method(_CRS) + Device (RES0) { + Name (_HID, "PNP0C02" /* PNP Motherboard Resources */) // _HID: Hardware ID + Name (_CRS, ResourceTemplate () { // _CRS: Current Resource Settings + QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite, + 0x0000000000000000, // Granularity + FixedPcdGet64 (PcdPciExpressBaseAddress), // Range Minimum + FixedPcdGet64 (PcdPciConfigurationSpaceLimit), // Range Maximum + 0x0000000000000000, // Translation Offset + FixedPcdGet64 (PcdPciConfigurationSpaceSize), // Length + ,, , AddressRangeMemory, TypeStatic) + }) + } + // // OS Control Handoff // -- 2.25.1