From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.7361.1647938174014362920 for ; Tue, 22 Mar 2022 01:36:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IRB509Yj; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647938173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pB8ZQLH8vWZqcESVXOPaT9AKcEUlXOkK34f06dvMbHQ=; b=IRB509Yj20d7HE5VSHlQKrLLu08oz/CSaFwpoe6PBRFVVIxlkRw9yTVgd5cIdYp972ojt1 9KtHxFuCwwXQBeoV4w09tWjqy1rIf1FTGjFWSBcO6PMAbUR/9uiRfw4WzghoKyh2cpPtnF /kfSbZS2Vs3/Xuz5Li2ve3WFmjFwalU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-63h2ljxZPiCT8he4TUCOIg-1; Tue, 22 Mar 2022 04:36:07 -0400 X-MC-Unique: 63h2ljxZPiCT8he4TUCOIg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26486899EC2; Tue, 22 Mar 2022 08:36:07 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC58C4B8D42; Tue, 22 Mar 2022 08:36:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A1337180062E; Tue, 22 Mar 2022 09:36:05 +0100 (CET) Date: Tue, 22 Mar 2022 09:36:05 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Sebastien Boeuf Subject: Re: [PATCH V9 22/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Message-ID: <20220322083605.m6yotawukdtakuzs@sirius.home.kraxel.org> References: <17a018b7a0655b1f9ec325a20b766f5871f11565.1647523953.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <17a018b7a0655b1f9ec325a20b766f5871f11565.1647523953.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 18, 2022 at 08:45:40AM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 > > From this patch we start to restruct the functions which set PCDs into > two, one for PlatformInitLib, one for PlatformPei. > > AddressWidthInitialization is the first one. It is splitted into two: > - PlatformAddressWidthInitialization is for PlatformInitLib > - AddressWidthInitialization is for PlatformPei. It calls > PlatformAddressWidthInitialization then set PCDs. > > Below functions are also refined for PlatformInitLib: > - PlatformScanOrAdd64BitE820Ram > - PlatformGetSystemMemorySizeAbove4gb > - PlatformGetFirstNonAddress > > All the SetPcd codes are removed from above functions. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Cc: Sebastien Boeuf > Signed-off-by: Min Xu Acked-by: Gerd Hoffmann