public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io
Cc: Hao A Wu <hao.a.wu@intel.com>
Subject: [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation
Date: Sun, 27 Mar 2022 00:57:48 +0000	[thread overview]
Message-ID: <20220327005748.92041-3-pedro.falcato@gmail.com> (raw)
In-Reply-To: <20220327005748.92041-1-pedro.falcato@gmail.com>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871

Deletes the CRC16 implementation as CalculateCrc16() is being merged
into BaseLib.

Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 .../DebugAgent/DebugAgentCommon/DebugAgent.c  | 35 -------------------
 1 file changed, 35 deletions(-)

diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
index a1e61a6ef90e..62c6a235d425 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
@@ -126,41 +126,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_VECTOR_HANDOFF_INFO  mVectorHandoffInfoDebugAg
 
 GLOBAL_REMOVE_IF_UNREFERENCED UINTN  mVectorHandoffInfoCount = sizeof (mVectorHandoffInfoDebugAgent) / sizeof (EFI_VECTOR_HANDOFF_INFO);
 
-/**
-  Calculate CRC16 for target data.
-
-  @param[in]  Data              The target data.
-  @param[in]  DataSize          The target data size.
-  @param[in]  Crc               Initial CRC.
-
-  @return UINT16     The CRC16 value.
-
-**/
-UINT16
-CalculateCrc16 (
-  IN UINT8   *Data,
-  IN UINTN   DataSize,
-  IN UINT16  Crc
-  )
-{
-  UINTN  Index;
-  UINTN  BitIndex;
-
-  for (Index = 0; Index < DataSize; Index++) {
-    Crc ^= (UINT16)Data[Index];
-    for (BitIndex = 0; BitIndex < 8; BitIndex++) {
-      if ((Crc & 0x8000) != 0) {
-        Crc <<= 1;
-        Crc  ^= 0x1021;
-      } else {
-        Crc <<= 1;
-      }
-    }
-  }
-
-  return Crc;
-}
-
 /**
   Read IDT entry to check if IDT entries are setup by Debug Agent.
 
-- 
2.35.1


  parent reply	other threads:[~2022-03-27  0:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  0:57 [PATCH 0/2] Add CRC16 and CRC32c to MdePkg/BaseLib Pedro Falcato
2022-03-27  0:57 ` [PATCH 1/2] MdePkg/BaseLib: Add CRC16 and CRC32c implementations Pedro Falcato
2022-03-27  0:57 ` Pedro Falcato [this message]
2022-03-28  0:14   ` [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation Wu, Hao A
2022-03-28  1:49     ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220327005748.92041-3-pedro.falcato@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox