From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web09.1277.1648342673314600036 for ; Sat, 26 Mar 2022 17:57:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pfSzB3Ae; spf=pass (domain: gmail.com, ip: 209.85.221.46, mailfrom: pedro.falcato@gmail.com) Received: by mail-wr1-f46.google.com with SMTP id h23so15525085wrb.8 for ; Sat, 26 Mar 2022 17:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+3rBlDdAI9khKHmksGCDK0qli7Px8vsdUQSJYzvZPdY=; b=pfSzB3Aeg2WMOeua/dvq/sxcTSi7OKGy4fT5roam7gue/aNzZK5kB1zg9uG6Cp7ija beR55i7P7uquN1IlHwnFv7fkOkZRTJj5rG5QxS6N5+SR315LJHKMS5udNT6DYSFrrrO9 RfugyYdSj7XOcLGg/qBSgLfSHOt+ZGiUz1umD2N0ACCmBkO5TBpEVPFgaGpB8t0TuYgK rLbd/QraZh5UgCEPNGBtB0YZWJkBSBxc+YMFJzQ3chuoetsQL3aTQnlo3NH3sH/2lkRO 0e7YmH8XtzYoFjAVEYmciV3WH6+hOvhirSl7Dj4X3l2TPEnSSYjaxjaWPMnJ7+uYG/OJ sm4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+3rBlDdAI9khKHmksGCDK0qli7Px8vsdUQSJYzvZPdY=; b=ehU0vx2gA+1ixJRNMOyPaWt3lNYMT4dVxnSSyNLFHxExVyzdQaT9IKnmmFTyR2ipEy vWjITjlpR1KDpaGRVL7v/eTDg6dbdj54cfOfRh50EdQHLAOLNK6RaeUn9O3x7/jmDvVc G70WbPRWjMnvljfIYdDLzr8JkbIq4iQTZUhdWjs08OzNAbk6jDjvfCG6kdaVwXEwF2ul X/BHKIKIGP7oU3MbSy6GIEQnGo8sDlJvhxMn4sPzuQMNM6q5UGRQOl8FBEupl8ETU8OF IhQRspA0qu4qnm+9IqAYvzPKL9Ilypzdl6+soDDJ1NBFON1z4Um3G9OR+efCS6z1h4pS dBeg== X-Gm-Message-State: AOAM533ujahDDEwPsAnWhb6L+JMFKys2zP8Qv1HijgbkBed02kvP3yuk LsCyperWfv8Whrujp0/i6C+1YTiPTnvZzQ== X-Google-Smtp-Source: ABdhPJzOqb7kVag+E5KN33g347ZXn9wExw0Nif1X4Uxpdl2f5HUYKMm+LFOR5hl8N5wB2ZLqVLf+8w== X-Received: by 2002:adf:ec41:0:b0:1ed:beee:6f8f with SMTP id w1-20020adfec41000000b001edbeee6f8fmr14884218wrn.110.1648342671506; Sat, 26 Mar 2022 17:57:51 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id b3-20020adfd1c3000000b00205820686dasm10143304wrd.5.2022.03.26.17.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 17:57:51 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Hao A Wu Subject: [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation Date: Sun, 27 Mar 2022 00:57:48 +0000 Message-Id: <20220327005748.92041-3-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220327005748.92041-1-pedro.falcato@gmail.com> References: <20220327005748.92041-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 Deletes the CRC16 implementation as CalculateCrc16() is being merged into BaseLib. Cc: Hao A Wu Signed-off-by: Pedro Falcato --- .../DebugAgent/DebugAgentCommon/DebugAgent.c | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c index a1e61a6ef90e..62c6a235d425 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c @@ -126,41 +126,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_VECTOR_HANDOFF_INFO mVectorHandoffInfoDebugAg GLOBAL_REMOVE_IF_UNREFERENCED UINTN mVectorHandoffInfoCount = sizeof (mVectorHandoffInfoDebugAgent) / sizeof (EFI_VECTOR_HANDOFF_INFO); -/** - Calculate CRC16 for target data. - - @param[in] Data The target data. - @param[in] DataSize The target data size. - @param[in] Crc Initial CRC. - - @return UINT16 The CRC16 value. - -**/ -UINT16 -CalculateCrc16 ( - IN UINT8 *Data, - IN UINTN DataSize, - IN UINT16 Crc - ) -{ - UINTN Index; - UINTN BitIndex; - - for (Index = 0; Index < DataSize; Index++) { - Crc ^= (UINT16)Data[Index]; - for (BitIndex = 0; BitIndex < 8; BitIndex++) { - if ((Crc & 0x8000) != 0) { - Crc <<= 1; - Crc ^= 0x1021; - } else { - Crc <<= 1; - } - } - } - - return Crc; -} - /** Read IDT entry to check if IDT entries are setup by Debug Agent. -- 2.35.1