From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web08.1302.1648342748329696003 for ; Sat, 26 Mar 2022 17:59:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Tz80Scup; spf=pass (domain: gmail.com, ip: 209.85.128.44, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f44.google.com with SMTP id i67-20020a1c3b46000000b0038ce25c870dso2918098wma.1 for ; Sat, 26 Mar 2022 17:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z0yAziG28OkEWkNr3V61HtbhpwFlooNm4BZWuYkpEXg=; b=Tz80Scuprkm/eDXLC2Cr9dOJ112mfQyHxNrEstvt6TN3JTvDP+addhSBHayNZ0ONMM prvFX+Yi8X8ufwPfn8owrR3UrVe4d5reGssriVbOeT5QZ6PIZRyVz7zPuxRbJP6vXrKa HcP2kfXKlM+n55eC5bpY7oBa0hk2e4yJkIS6dIttP/ww9XoQT5Q8pr4xHWsH50cqk0fp DLItSYLLn1nHK3+CCi1WJXFXMIkDs5cthSH7QRWDcb8bSB33am5aW+L7kz1S2H++0wjx c+Kq1msGTdZNcz36szTELdfFrfXXTt3JVEqkMELdXc+4V/OBy0bnMNcLFnoOPheO8vqr t+6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z0yAziG28OkEWkNr3V61HtbhpwFlooNm4BZWuYkpEXg=; b=2zC7qF++8TyY1GxBZOti9YMynQOwUJyRZ7TI8Hh699R7ZXzxf2qbLLN5Nt1a0IlbV+ VGGtBNv2+rxV1jxY9HgQOBtDHW4aSATq2EOOerVNa2pBaHY8fdPz29PGkENQfxn4v1H/ 4xkV1ZrP7wA40blvXZW+hLG1no2bLKWcgFwg0VKXcvp/l2BKZHW2otrF0pFH/vS4dPY0 t0S3Zx7ZugJDO/6OwawMVCePt459pE/k9sz72avwQUqRJYOgyni7QKX9By6rSbM8SkZa fmKVMkb8SvW6jY6NxfkSBWtw6d5LV6mWMIgG1zD718oAtrioAiUJ5tN3pOkreANAIVOc YvzQ== X-Gm-Message-State: AOAM532H4/jzfcAtleC9xgPulHasLKbSldzKuDOeHItuw/cIyZ9laZEo CjKMRyRrSNxoPaiNnor4AYCTK22p2VGcAInA X-Google-Smtp-Source: ABdhPJxXC6r4JYp4gi+tbzHmt/ModTJunYaaX+fQDVPoF4zXLA4kKsejP4t2vuRMLV3gvt0g8MOQPw== X-Received: by 2002:a05:600c:19ca:b0:38c:a190:9a0f with SMTP id u10-20020a05600c19ca00b0038ca1909a0fmr26950422wmq.57.1648342746600; Sat, 26 Mar 2022 17:59:06 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id q8-20020a056000136800b00203e740c7desm8722448wrz.71.2022.03.26.17.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 17:59:06 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Leif Lindholm , Michael D Kinney , Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [PATCH edk2-platforms 0/2] Replace individual CRC implementations with BaseLib Date: Sun, 27 Mar 2022 00:59:03 +0000 Message-Id: <20220327005905.92480-1-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 This patch-set replaces the individual CRC16 implementations in Ext4Pkg and WhitleyOpenBoardPkg with the soon-to-be-merged BaseLib implementation of CalculateCrc16(). These patches should not be merged before the BaseLib one, but also not too long after, as the BaseLib changes will certainly break these packages' builds. I encourage the platform maintainers to build and test my changes as I couldn't build them nor test them (although everything looks good from a bird's eye view). Also CC'ing the platforms maintainers as I can't review my own patches :) Cc: Leif Lindholm Cc: Michael D Kinney Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Pedro Falcato (2): Ext4Pkg: Replace the CRC implementations with BaseLib WhitleyOpenBoardPkg: Replace BaseCrcLib with BaseLib Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----------------- Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------------------- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 34 +------- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 2 - .../Include/Library/CrcLib.h | 42 ---------- .../AcpiPlatformLibBdat.c | 46 +++------- .../Library/BaseCrcLib/BaseCrcLib.c | 71 ---------------- .../Library/BaseCrcLib/BaseCrcLib.inf | 23 ----- .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 1 - 9 files changed, 13 insertions(+), 365 deletions(-) delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.c delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.inf -- 2.35.1