From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Internet2.beckhoff.com (Internet2.beckhoff.com [194.25.186.210]) by mx.groups.io with SMTP id smtpd.web11.3661.1648536912581966479 for ; Mon, 28 Mar 2022 23:55:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: beckhoff.com, ip: 194.25.186.210, mailfrom: c.koehne@beckhoff.com) Received: from 172.17.5.170 by Internet2.beckhoff.com (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey256); Tue, 29 Mar 2022 06:55:10 GMT Received: from CorvinK-NB03.fritz.box (172.17.204.164) by ex04.beckhoff.com (172.17.5.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.24; Tue, 29 Mar 2022 08:55:08 +0200 From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: CC: =?UTF-8?q?Corvin=20K=C3=B6hne?= , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Rebecca Cran , Peter Grehan , , FreeBSD Virtualization Subject: [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support Date: Tue, 29 Mar 2022 08:54:36 +0200 Message-ID: <20220329065437.186-1-c.koehne@beckhoff.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Return-Path: c.koehne@beckhoff.com X-Originating-IP: [172.17.204.164] X-ClientProxiedBy: ex03.beckhoff.com (172.17.2.169) To ex04.beckhoff.com (172.17.5.170) X-OLX-Disclaimer: EX04.BECKHOFF.COM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =EF=BB=BFHi, I'm going to add QemuFwCfg support to bhyve. See https://reviews.freebsd.org/D31578. Therefore, this patch for OVMF is neccessary to work properly. There's one open point on that patch and hopefully one of you has more insights. Qemu has an item called FW_CFG_MAX_CPUS. It looks very similar to what we need here, but I'm not sure if we can use it safely as Qemu has a comment about it: https://github.com/qemu/qemu/blob/0021c4765a6b83e5b09409b75d50c6caaa6971b9/= hw/i386/fw_cfg.c#L110-L121 /* FW_CFG_MAX_CPUS is a bit confusing/problematic on x86: * * For machine types prior to 1.8, SeaBIOS needs FW_CFG_MAX_CPUS for * building MPTable, ACPI MADT, ACPI CPU hotplug and ACPI SRAT table, * that tables are based on xAPIC ID and QEMU<->SeaBIOS interface * for CPU hotplug also uses APIC ID and not "CPU index". * This means that FW_CFG_MAX_CPUS is not the "maximum number of CPUs", * but the "limit to the APIC ID values SeaBIOS may see". * * So for compatibility reasons with old BIOSes we are stuck with * "etc/max-cpus" actually being apic_id_limit */ Thanks Corvin CC: Ard Biesheuvel CC: Jiewen Yao CC: Jordan Justen CC: Gerd Hoffmann CC: Rebecca Cran CC: Peter Grehan CC: devel@edk2.groups.io CC: FreeBSD Virtualization Corvin K=C3=B6hne (1): OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 41 +++++++++++++++++++= +--- OvmfPkg/Bhyve/BhyveX64.dsc | 4 +-- 3 files changed, 40 insertions(+), 6 deletions(-) --=20 2.11.0 Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075