public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Bob Feng <bob.c.feng@intel.com>, Rebecca Cran <rebecca@bsdio.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 1/1] Basetools: fix gcc workaround
Date: Tue, 29 Mar 2022 10:37:47 +0200	[thread overview]
Message-ID: <20220329083747.182448-1-kraxel@redhat.com> (raw)

Apply the workaround only in case the compiler is gcc.
Fixes builds with clang.

Fixes: 22130dcd98b4 ("Basetools: turn off gcc12 warning")
Reported-by: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 BaseTools/Source/C/DevicePath/GNUmakefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile
index b05d2bddfa68..6323e7355cc8 100644
--- a/BaseTools/Source/C/DevicePath/GNUmakefile
+++ b/BaseTools/Source/C/DevicePath/GNUmakefile
@@ -13,8 +13,10 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o  DevicePathUtili
 
 include $(MAKEROOT)/Makefiles/app.makefile
 
+ifneq ($(CXX), llvm)
 # gcc 12 trips over device path handling
 BUILD_CFLAGS += -Wno-error=stringop-overflow
+endif
 
 LIBS = -lCommon
 ifeq ($(CYGWIN), CYGWIN)
-- 
2.35.1


             reply	other threads:[~2022-03-29  8:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  8:37 Gerd Hoffmann [this message]
2022-03-31  0:51 ` [PATCH v2 1/1] Basetools: fix gcc workaround Yuwei Chen
     [not found] ` <16E150E28AFDD2A7.22795@groups.io>
2022-03-31  2:46   ` [edk2-devel] " Yuwei Chen
2022-03-31  5:33     ` 回复: " gaoliming
2022-04-02  5:56       ` Yuwei Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329083747.182448-1-kraxel@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox