public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, c.koehne@beckhoff.com
Cc: "Corvin Köhne" <CorvinK@beckhoff.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Rebecca Cran" <rebecca@bsdio.com>,
	"Peter Grehan" <grehan@freebsd.org>,
	"FreeBSD Virtualization" <freebsd-virtualization@freebsd.org>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg
Date: Tue, 29 Mar 2022 11:24:58 +0200	[thread overview]
Message-ID: <20220329092458.jkkxvq3thsbjw7px@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220329065437.186-2-c.koehne@beckhoff.com>

On Tue, Mar 29, 2022 at 08:54:37AM +0200, Corvin Köhne wrote:
> From: Corvin Köhne <CorvinK@beckhoff.com>
> 
> QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl
> decided to use the same IO ports as QemuFwCfg. It's not possible to use
> both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl.

Hmm, so QemuFwCfg and BhyveFwCtl are incompatible but use the same
ports?  I guess the signature used is different then so the guest
has a chance to figure which one is active?

Assuming the above is correct the patch looks sane.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


  reply	other threads:[~2022-03-29  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  6:54 [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support Corvin Köhne
2022-03-29  6:54 ` [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Corvin Köhne
2022-03-29  9:24   ` Gerd Hoffmann [this message]
2022-03-29  9:59     ` [edk2-devel] " Corvin Köhne
2022-03-29  9:14 ` [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support Gerd Hoffmann
2022-03-29  9:57   ` Corvin Köhne
2022-03-29 11:30     ` Gerd Hoffmann
2022-03-29 11:53       ` Corvin Köhne
2022-03-29 13:35         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329092458.jkkxvq3thsbjw7px@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox