From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4663.1648545907151672418 for ; Tue, 29 Mar 2022 02:25:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JrqparBJ; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648545906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmumeICT9LXuLaBEhF3OlF+sITLE2tbnHJiC81q5X0I=; b=JrqparBJ62Glnf/NhNoEQhGnYOcfowlT7ynhXgGIXFMdZb3BvOjYDitMPreVEcddBEtRsf 8/ZyHFztbyZKEj2HBU6N2OHsYsXO1dTvcDbHIWExaSSUDRbPPiqVbnV1BzjsY4jGzQV6eK kaJ3XheBFEb4eJeO1UMQEHFdAWlJTdU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-178-WTTBjgzNN2mYYxHIurmkTw-1; Tue, 29 Mar 2022 05:25:02 -0400 X-MC-Unique: WTTBjgzNN2mYYxHIurmkTw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82539101A54C; Tue, 29 Mar 2022 09:25:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47B3C469A78; Tue, 29 Mar 2022 09:25:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C040118003A3; Tue, 29 Mar 2022 11:24:58 +0200 (CEST) Date: Tue, 29 Mar 2022 11:24:58 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, c.koehne@beckhoff.com Cc: Corvin =?utf-8?B?S8O2aG5l?= , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Rebecca Cran , Peter Grehan , FreeBSD Virtualization Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Message-ID: <20220329092458.jkkxvq3thsbjw7px@sirius.home.kraxel.org> References: <20220329065437.186-1-c.koehne@beckhoff.com> <20220329065437.186-2-c.koehne@beckhoff.com> MIME-Version: 1.0 In-Reply-To: <20220329065437.186-2-c.koehne@beckhoff.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Mar 29, 2022 at 08:54:37AM +0200, Corvin Köhne wrote: > From: Corvin Köhne > > QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl > decided to use the same IO ports as QemuFwCfg. It's not possible to use > both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl. Hmm, so QemuFwCfg and BhyveFwCtl are incompatible but use the same ports? I guess the signature used is different then so the guest has a chance to figure which one is active? Assuming the above is correct the patch looks sane. Acked-by: Gerd Hoffmann take care, Gerd