From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web09.3845.1648617269258985882 for ; Tue, 29 Mar 2022 22:14:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dmez32Ah; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648617268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ic+qAn5fgap1esRr29vocr4mkrz/aTpB8ByfQWQl4I0=; b=dmez32AhpF5icI5ExvkF1HWcz/Y33kbuoLAktWBf0CrDqK5D5jfCZBfm2LwNb2V7WSmRHN mSMOjiMUn/pc9DDgGLf1PVcP4Gse5EHzvQKm2jyxR99AxF4DZPbydfovkSWPEjMgLXtgqR KY6ZooAhTicOtwmYKqYywU87jBIsq3Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-K2yzZcwfPj-535DM0QQgiw-1; Wed, 30 Mar 2022 01:14:26 -0400 X-MC-Unique: K2yzZcwfPj-535DM0QQgiw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5671C8564FD; Wed, 30 Mar 2022 05:14:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2126E400E553; Wed, 30 Mar 2022 05:14:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9411E180086C; Wed, 30 Mar 2022 07:14:23 +0200 (CEST) Date: Wed, 30 Mar 2022 07:14:23 +0200 From: "Gerd Hoffmann" To: Dov Murik Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Tobin Feldman-Fitzthum Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf Message-ID: <20220330051423.2n5o4odfwlz2ja2y@sirius.home.kraxel.org> References: <20220328184530.86797-1-dovmurik@linux.ibm.com> <20220328184530.86797-2-dovmurik@linux.ibm.com> <20220329113610.cbbj3iigjimnsska@sirius.home.kraxel.org> <97d772ff-d247-cd08-a08f-b9e0137b63fe@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <97d772ff-d247-cd08-a08f-b9e0137b63fe@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 29, 2022 at 03:32:36PM +0300, Dov Murik wrote: > Thanks Gerd for reviewing. > > On 29/03/2022 14:36, Gerd Hoffmann wrote: > > On Mon, Mar 28, 2022 at 06:45:29PM +0000, Dov Murik wrote: > >> Reorder the pages in the MEMFD section of AmdSevX64.fdf so that it > >> matches the same order used in OvmfPkgX64.fdf. > > > > Makes sense. > > > > Acked-by: Gerd Hoffmann > > Thanks. > > > > > Maybe also move this to a common include file, so it is less likely that > > they run out of sync again? > > > > I was contemplating that, but wasn't sure (I only use OvmfPkgX64 and > AmdSevX64 in my testing). > > Is it common in edk2? We already have a few: kraxel@sirius ~/projects/edk2 (gcc12)# ls OvmfPkg/*.fdf.inc OvmfPkg/FvmainCompactScratchEnd.fdf.inc OvmfPkg/OvmfTpmDxe.fdf.inc OvmfPkg/VarStore.fdf.inc OvmfPkg/OvmfPkgDefines.fdf.inc OvmfPkg/OvmfTpmPei.fdf.inc OvmfPkg/XenElfHeader.fdf.inc > Would it apply to other OvmfPkg targets? I see similar MEMFD in > CloudHvX64.fdf . I'd create one for the confidential computing memory areas, that would only affect the builds which support SEV (and soon TDX). Not sure about CloudHvX64.fdf, as far I know it does not support SEV/TDX, maybe those antries are only there because they have been copied over from OvmfPkgX64.fdf take care, Gerd