From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.3893.1648617646399280007
 for <devel@edk2.groups.io>;
 Tue, 29 Mar 2022 22:20:47 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DtTSzZWr;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1648617645;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=n060HuFpVQNuB/y9P+ntqcO5WimceIHqLgH+7eldfRQ=;
	b=DtTSzZWrTwq0zw7SO9d0Jydeuh0cxZrsoIhDqfUXOXzTO6Pchzg5FjwR9OdrRAK3GKg2UP
	wPmi2v50ohk0lVnhC4wO1c1BfCxCim5/H5MtccUTPLlE4zOIQ0PkcNfBqELrSi6bwmCLOG
	Cqc0tYMMxfP0nmA7ohS96ToEBnQwYdk=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-620-siFv0IKtOXew8XAC0gMS3A-1; Wed, 30 Mar 2022 01:20:42 -0400
X-MC-Unique: siFv0IKtOXew8XAC0gMS3A-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D407391BD80;
	Wed, 30 Mar 2022 05:20:39 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.10])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B0AF8428F1E;
	Wed, 30 Mar 2022 05:20:34 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id F0AD4180086C; Wed, 30 Mar 2022 07:20:29 +0200 (CEST)
Date: Wed, 30 Mar 2022 07:20:29 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Dov Murik <dovmurik@linux.ibm.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
Subject: Re: [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation
Message-ID: <20220330052029.4fuzbca2364nm7fg@sirius.home.kraxel.org>
References: <20220328184530.86797-1-dovmurik@linux.ibm.com>
 <20220328184530.86797-3-dovmurik@linux.ibm.com>
MIME-Version: 1.0
In-Reply-To: <20220328184530.86797-3-dovmurik@linux.ibm.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> Check if that page is defined; if it is, skip it in the metadata list.
> In such case, VMM should fill the page with the hashes content, or
> explicitly update it as a zero page (if kernel hashes are not used).

Is it an option to just skip the page unconditionally?

I think in the OvmfPkgX64 build the page is not used, so it probably
doesn't matter whenever it is included or not, and it would make things
a bit less confusing ...

take care,
  Gerd