public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Eric Dong <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 2/2] MinPlatformPkg/TestPointCheckLib: Remove unused variable
Date: Wed, 30 Mar 2022 11:28:03 -0400	[thread overview]
Message-ID: <20220330152803.1919-3-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20220330152803.1919-1-mikuback@linux.microsoft.com>

From: Michael Kubacki <michael.kubacki@microsoft.com>

The variable VariableMemoryTypeInformation is set but never used.
This change removes the variable.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
index c4dd3c7c9519..0d3da7320fdd 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
@@ -108,7 +108,6 @@ TestPointCheckMemoryTypeInformation (
   EFI_HOB_GUID_TYPE       *GuidHob;
   VOID                    *CurrentMemoryTypeInformation;
   VOID                    *PreviousMemoryTypeInformation;
-  VOID                    *VariableMemoryTypeInformation;
 
   DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n"));
   CurrentMemoryTypeInformation = NULL;
@@ -127,13 +126,6 @@ TestPointCheckMemoryTypeInformation (
     goto Done;
   }
 
-  GetVariable2 (
-             EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME,
-             &gEfiMemoryTypeInformationGuid,
-             &VariableMemoryTypeInformation,
-             NULL
-             );
-
   if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) {
     DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation);
   }
-- 
2.28.0.windows.1


      parent reply	other threads:[~2022-03-30 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 15:28 [edk2-platforms][PATCH v1 0/2] MinPlatformPkg: Check MemoryTypeInfo Fixes Michael Kubacki
2022-03-30 15:28 ` [edk2-platforms][PATCH v1 1/2] MinPlatformPkg/TestPointCheckLib: Prevent MemTypeInfo HOB modification Michael Kubacki
2022-03-30 15:28 ` Michael Kubacki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330152803.1919-3-mikuback@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox