* [PATCH v1 0/6] Merge UefiCpuLib to CpuLib
@ 2022-04-01 5:22 Yu Pu
2022-04-01 5:22 ` [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3394
Today lots of duplicated code call CPUID and calculates the address mask.
Adding an API named GetPhysicalAddressBits in UefiCpuLib can solve this
problem, but at the same time cause MdeModulePkg depend on UefiCpuPkg
which does not meet the design spec. So merge UefiCpuLib to CpuLib is a
good way to sovle these problems. To minimize the impact,this operation
is divided into four steps. This patch sets contain the first step: add
CpuLib to module INFs that depend on UefiCpuLib.
Yu Pu (6):
IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on
UefiCpuLib.
MdePkg: Add CpuLib to module INFs that depend on UefiCpuLib.
OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
UefiCpuPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
UefiPayloadPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
OvmfPkg/Sec/SecMain.c | 1 +
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 +
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
MdePkg/MdeLibs.dsc.inc | 1 +
OvmfPkg/Sec/SecMain.inf | 1 +
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 1 +
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 1 +
UefiCpuPkg/SecCore/SecCore.inf | 1 +
UefiCpuPkg/SecCore/SecCoreNative.inf | 1 +
UefiCpuPkg/SecCore/SecMain.h | 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 1 +
18 files changed, 18 insertions(+)
--
2.30.0.windows.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-06 3:41 ` Chiu, Chasel
2022-04-01 5:22 ` [PATCH v1 2/6] IntelFsp2WrapperPkg: " Yu Pu
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Chasel Chiu, Nate DeSimone, Star Zeng
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
index 7b05cae64130..830471adcf2f 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
@@ -51,6 +51,7 @@
FspSwitchStackLib
FspCommonLib
FspSecPlatformLib
+ CpuLib
UefiCpuLib
[Pcd]
diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h b/IntelFsp2Pkg/FspSecCore/SecMain.h
index 7794255af13d..edb7447d9eff 100644
--- a/IntelFsp2Pkg/FspSecCore/SecMain.h
+++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
@@ -20,6 +20,7 @@
#include <Library/SerialPortLib.h>
#include <Library/FspSwitchStackLib.h>
#include <Library/FspCommonLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <FspEas.h>
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
2022-04-01 5:22 ` [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-06 3:41 ` Chiu, Chasel
2022-04-01 5:22 ` [PATCH v1 3/6] MdePkg: " Yu Pu
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Chasel Chiu, Nate DeSimone, Star Zeng
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
index 5d0e0214015f..e2262d693c55 100644
--- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
+++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
@@ -37,6 +37,7 @@
HobLib
FspWrapperPlatformLib
FspWrapperHobProcessLib
+ CpuLib
UefiCpuLib
PeCoffGetEntryPointLib
PeCoffExtraActionLib
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
index da0049a65435..0598f85ab3ac 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
@@ -38,6 +38,7 @@
MemoryAllocationLib
FspWrapperPlatformLib
FspWrapperHobProcessLib
+ CpuLib
UefiCpuLib
PeCoffGetEntryPointLib
PeCoffExtraActionLib
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 3/6] MdePkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
2022-04-01 5:22 ` [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
2022-04-01 5:22 ` [PATCH v1 2/6] IntelFsp2WrapperPkg: " Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-01 5:22 ` [PATCH v1 4/6] OvmfPkg: " Yu Pu
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Michael D Kinney, Liming Gao, Zhiguang Liu
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
MdePkg/MdeLibs.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
index 3c70daf87a0c..322575090239 100644
--- a/MdePkg/MdeLibs.dsc.inc
+++ b/MdePkg/MdeLibs.dsc.inc
@@ -13,3 +13,4 @@
[LibraryClasses]
RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
+ CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 4/6] OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
` (2 preceding siblings ...)
2022-04-01 5:22 ` [PATCH v1 3/6] MdePkg: " Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-01 5:22 ` [PATCH v1 5/6] UefiCpuPkg: " Yu Pu
2022-04-01 5:22 ` [PATCH v1 6/6] UefiPayloadPkg: " Yu Pu
5 siblings, 0 replies; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
OvmfPkg/Sec/SecMain.c | 1 +
OvmfPkg/Sec/SecMain.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
index 2c5561661ef3..2c9e439800c7 100644
--- a/OvmfPkg/Sec/SecMain.c
+++ b/OvmfPkg/Sec/SecMain.c
@@ -17,6 +17,7 @@
#include <Library/BaseMemoryLib.h>
#include <Library/PeiServicesLib.h>
#include <Library/PcdLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <Library/DebugAgentLib.h>
#include <Library/IoLib.h>
diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf
index 95cf0025e100..6ad366a89333 100644
--- a/OvmfPkg/Sec/SecMain.inf
+++ b/OvmfPkg/Sec/SecMain.inf
@@ -44,6 +44,7 @@
BaseMemoryLib
PeiServicesLib
PcdLib
+ CpuLib
UefiCpuLib
DebugAgentLib
IoLib
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 5/6] UefiCpuPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
` (3 preceding siblings ...)
2022-04-01 5:22 ` [PATCH v1 4/6] OvmfPkg: " Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-01 5:22 ` [PATCH v1 6/6] UefiPayloadPkg: " Yu Pu
5 siblings, 0 replies; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Eric Dong, Ray Ni, Rahul Kumar
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 1 +
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 1 +
UefiCpuPkg/SecCore/SecCore.inf | 1 +
UefiCpuPkg/SecCore/SecCoreNative.inf | 1 +
UefiCpuPkg/SecCore/SecMain.h | 1 +
8 files changed, 8 insertions(+)
diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
index f9e06b2fca45..a944c3d01cf7 100644
--- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
+++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
@@ -21,6 +21,7 @@
#include <Library/IoLib.h>
#include <Library/TimerLib.h>
#include <Library/PcdLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
//
diff --git a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
index aaa42ff8450b..8b3630d7a302 100644
--- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
+++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
@@ -22,6 +22,7 @@
#include <Library/IoLib.h>
#include <Library/TimerLib.h>
#include <Library/PcdLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
//
diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
index 561baa44b0e6..a85b69e0a11c 100644
--- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
+++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
@@ -38,6 +38,7 @@
TimerLib
IoLib
PcdLib
+ CpuLib
UefiCpuLib
[Pcd]
diff --git a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
index 1e2a4f8b790f..31ebdd39c616 100644
--- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
+++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
@@ -38,6 +38,7 @@
TimerLib
IoLib
PcdLib
+ CpuLib
UefiCpuLib
[Pcd]
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
index aed872836c99..dfeceec2aadc 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
@@ -43,6 +43,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/UefiLib.h>
#include <Library/HobLib.h>
#include <Library/LocalApicLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <Library/CpuExceptionHandlerLib.h>
#include <Library/ReportStatusCodeLib.h>
diff --git a/UefiCpuPkg/SecCore/SecCore.inf b/UefiCpuPkg/SecCore/SecCore.inf
index ded83beb5272..f021997f271c 100644
--- a/UefiCpuPkg/SecCore/SecCore.inf
+++ b/UefiCpuPkg/SecCore/SecCore.inf
@@ -47,6 +47,7 @@
PlatformSecLib
PcdLib
DebugAgentLib
+ CpuLib
UefiCpuLib
PeCoffGetEntryPointLib
PeCoffExtraActionLib
diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/SecCoreNative.inf
index b528c5987947..e0a1b44a7e23 100644
--- a/UefiCpuPkg/SecCore/SecCoreNative.inf
+++ b/UefiCpuPkg/SecCore/SecCoreNative.inf
@@ -44,6 +44,7 @@
PlatformSecLib
PcdLib
DebugAgentLib
+ CpuLib
UefiCpuLib
PeCoffGetEntryPointLib
PeCoffExtraActionLib
diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h
index 029bee3e7e40..189fcf932625 100644
--- a/UefiCpuPkg/SecCore/SecMain.h
+++ b/UefiCpuPkg/SecCore/SecMain.h
@@ -23,6 +23,7 @@
#include <Library/PcdLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/PlatformSecLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <Library/PeCoffGetEntryPointLib.h>
#include <Library/PeCoffExtraActionLib.h>
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 6/6] UefiPayloadPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
` (4 preceding siblings ...)
2022-04-01 5:22 ` [PATCH v1 5/6] UefiCpuPkg: " Yu Pu
@ 2022-04-01 5:22 ` Yu Pu
2022-04-10 20:26 ` Guo Dong
5 siblings, 1 reply; 12+ messages in thread
From: Yu Pu @ 2022-04-01 5:22 UTC (permalink / raw)
To: devel; +Cc: Yu Pu, Guo Dong, Ray Ni, Maurice Ma, Benjamin You, Sean Rhodes
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 1 +
3 files changed, 3 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
index 56e0a4c639a0..d1c7425b28f2 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
@@ -23,6 +23,7 @@
#include <Library/PeCoffLib.h>
#include <Library/BlParseLib.h>
#include <Library/PlatformSupportLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <IndustryStandard/Acpi.h>
#include <IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h>
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
index c4e4339ede4b..95446dd99729 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
@@ -54,6 +54,7 @@
HobLib
PeCoffLib
PlatformSupportLib
+ CpuLib
UefiCpuLib
[Guids]
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
index 80af5afe0a3f..3b4836042a06 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
@@ -52,6 +52,7 @@
IoLib
HobLib
PeCoffLib
+ CpuLib
UefiCpuLib
[Guids]
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
2022-04-01 5:22 ` [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
@ 2022-04-06 3:41 ` Chiu, Chasel
2022-04-06 11:20 ` Zeng, Star
0 siblings, 1 reply; 12+ messages in thread
From: Chiu, Chasel @ 2022-04-06 3:41 UTC (permalink / raw)
To: Pu, Yu, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Thanks Yu!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Pu, Yu <yu.pu@intel.com>
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu <yu.pu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that
> depend on UefiCpuLib
>
> Step 1 to merge UefiCpuLib to CpuLib.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
> IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 7b05cae64130..830471adcf2f 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -51,6 +51,7 @@
> FspSwitchStackLib
>
> FspCommonLib
>
> FspSecPlatformLib
>
> + CpuLib
>
> UefiCpuLib
>
>
>
> [Pcd]
>
> diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h
> b/IntelFsp2Pkg/FspSecCore/SecMain.h
> index 7794255af13d..edb7447d9eff 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.h
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
> @@ -20,6 +20,7 @@
> #include <Library/SerialPortLib.h>
>
> #include <Library/FspSwitchStackLib.h>
>
> #include <Library/FspCommonLib.h>
>
> +#include <Library/CpuLib.h>
>
> #include <Library/UefiCpuLib.h>
>
> #include <FspEas.h>
>
>
>
> --
> 2.30.0.windows.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 ` [PATCH v1 2/6] IntelFsp2WrapperPkg: " Yu Pu
@ 2022-04-06 3:41 ` Chiu, Chasel
2022-04-06 11:20 ` Zeng, Star
0 siblings, 1 reply; 12+ messages in thread
From: Chiu, Chasel @ 2022-04-06 3:41 UTC (permalink / raw)
To: Pu, Yu, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Thanks Yu!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Pu, Yu <yu.pu@intel.com>
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu <yu.pu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs
> that depend on UefiCpuLib.
>
> Step 1 to merge UefiCpuLib to CpuLib.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
> IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> index 5d0e0214015f..e2262d693c55 100644
> --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> @@ -37,6 +37,7 @@
> HobLib FspWrapperPlatformLib FspWrapperHobProcessLib+ CpuLib
> UefiCpuLib PeCoffGetEntryPointLib PeCoffExtraActionLibdiff --git
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> index da0049a65435..0598f85ab3ac 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> @@ -38,6 +38,7 @@
> MemoryAllocationLib FspWrapperPlatformLib
> FspWrapperHobProcessLib+ CpuLib UefiCpuLib PeCoffGetEntryPointLib
> PeCoffExtraActionLib--
> 2.30.0.windows.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-06 3:41 ` Chiu, Chasel
@ 2022-04-06 11:20 ` Zeng, Star
0 siblings, 0 replies; 12+ messages in thread
From: Zeng, Star @ 2022-04-06 11:20 UTC (permalink / raw)
To: Chiu, Chasel, Pu, Yu, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com>
Sent: Wednesday, April 6, 2022 11:42 AM
To: Pu, Yu <yu.pu@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
Thanks Yu!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Pu, Yu <yu.pu@intel.com>
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu <yu.pu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs
> that depend on UefiCpuLib.
>
> Step 1 to merge UefiCpuLib to CpuLib.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
> IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> index 5d0e0214015f..e2262d693c55 100644
> --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> @@ -37,6 +37,7 @@
> HobLib FspWrapperPlatformLib FspWrapperHobProcessLib+ CpuLib
> UefiCpuLib PeCoffGetEntryPointLib PeCoffExtraActionLibdiff --git
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> index da0049a65435..0598f85ab3ac 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> @@ -38,6 +38,7 @@
> MemoryAllocationLib FspWrapperPlatformLib
> FspWrapperHobProcessLib+ CpuLib UefiCpuLib PeCoffGetEntryPointLib
> PeCoffExtraActionLib--
> 2.30.0.windows.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
2022-04-06 3:41 ` Chiu, Chasel
@ 2022-04-06 11:20 ` Zeng, Star
0 siblings, 0 replies; 12+ messages in thread
From: Zeng, Star @ 2022-04-06 11:20 UTC (permalink / raw)
To: Chiu, Chasel, Pu, Yu, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com>
Sent: Wednesday, April 6, 2022 11:42 AM
To: Pu, Yu <yu.pu@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
Thanks Yu!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Pu, Yu <yu.pu@intel.com>
> Sent: Friday, April 1, 2022 1:22 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu <yu.pu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that
> depend on UefiCpuLib
>
> Step 1 to merge UefiCpuLib to CpuLib.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
> IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 7b05cae64130..830471adcf2f 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -51,6 +51,7 @@
> FspSwitchStackLib
>
> FspCommonLib
>
> FspSecPlatformLib
>
> + CpuLib
>
> UefiCpuLib
>
>
>
> [Pcd]
>
> diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h
> b/IntelFsp2Pkg/FspSecCore/SecMain.h
> index 7794255af13d..edb7447d9eff 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.h
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
> @@ -20,6 +20,7 @@
> #include <Library/SerialPortLib.h>
>
> #include <Library/FspSwitchStackLib.h>
>
> #include <Library/FspCommonLib.h>
>
> +#include <Library/CpuLib.h>
>
> #include <Library/UefiCpuLib.h>
>
> #include <FspEas.h>
>
>
>
> --
> 2.30.0.windows.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 6/6] UefiPayloadPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
2022-04-01 5:22 ` [PATCH v1 6/6] UefiPayloadPkg: " Yu Pu
@ 2022-04-10 20:26 ` Guo Dong
0 siblings, 0 replies; 12+ messages in thread
From: Guo Dong @ 2022-04-10 20:26 UTC (permalink / raw)
To: Pu, Yu, devel@edk2.groups.io
Cc: Ni, Ray, Ma, Maurice, You, Benjamin, Rhodes, Sean
Reviewed-by: Guo Dong <guo.dong@intel.com>
-----Original Message-----
From: Pu, Yu <yu.pu@intel.com>
Sent: Thursday, March 31, 2022 10:22 PM
To: devel@edk2.groups.io
Cc: Pu, Yu <yu.pu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: [PATCH v1 6/6] UefiPayloadPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Yu Pu <yu.pu@intel.com>
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 1 +
3 files changed, 3 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
index 56e0a4c639a0..d1c7425b28f2 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
@@ -23,6 +23,7 @@
#include <Library/PeCoffLib.h>
#include <Library/BlParseLib.h>
#include <Library/PlatformSupportLib.h>
+#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
#include <IndustryStandard/Acpi.h>
#include <IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h>
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
index c4e4339ede4b..95446dd99729 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
@@ -54,6 +54,7 @@
HobLib
PeCoffLib
PlatformSupportLib
+ CpuLib
UefiCpuLib
[Guids]
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
index 80af5afe0a3f..3b4836042a06 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
@@ -52,6 +52,7 @@
IoLib
HobLib
PeCoffLib
+ CpuLib
UefiCpuLib
[Guids]
--
2.30.0.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-04-10 20:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 5:22 [PATCH v1 0/6] Merge UefiCpuLib to CpuLib Yu Pu
2022-04-01 5:22 ` [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
2022-04-06 3:41 ` Chiu, Chasel
2022-04-06 11:20 ` Zeng, Star
2022-04-01 5:22 ` [PATCH v1 2/6] IntelFsp2WrapperPkg: " Yu Pu
2022-04-06 3:41 ` Chiu, Chasel
2022-04-06 11:20 ` Zeng, Star
2022-04-01 5:22 ` [PATCH v1 3/6] MdePkg: " Yu Pu
2022-04-01 5:22 ` [PATCH v1 4/6] OvmfPkg: " Yu Pu
2022-04-01 5:22 ` [PATCH v1 5/6] UefiCpuPkg: " Yu Pu
2022-04-01 5:22 ` [PATCH v1 6/6] UefiPayloadPkg: " Yu Pu
2022-04-10 20:26 ` Guo Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox