* [PATCH v1 0/3] Use windows-2019 VM Image
@ 2022-04-01 17:12 Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 1/3] .azurepipelines: Use windows-2019 VM image Michael Kubacki
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Michael Kubacki @ 2022-04-01 17:12 UTC (permalink / raw)
To: devel
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Andrew Fish, Ray Ni, Abner Chang, Nickle Wang, Ard Biesheuvel,
Jiewen Yao, Jordan Justen, Gerd Hoffmann
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
Pipelines are currently building against VS2019 and use the
"windows-latest" VM image in Azure Pipelines. The "windows-latest"
image recently moved its toolchain to VS2022, so VS2019 is no
longer found.
To immediately address the issue with no change in build behavior,
this series updates YAML files in the repository using
"windows-latest" to "windows-2019".
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Michael Kubacki (3):
.azurepipelines: Use windows-2019 VM image
EmulatorPkg: Use windows-2019 VM image
OvmfPkg: Use windows-2019 VM image
.azurepipelines/Windows-VS2019.yml | 2 +-
EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.28.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/3] .azurepipelines: Use windows-2019 VM image
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
@ 2022-04-01 17:12 ` Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 2/3] EmulatorPkg: " Michael Kubacki
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Michael Kubacki @ 2022-04-01 17:12 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.azurepipelines/Windows-VS2019.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/Windows-VS2019.yml b/.azurepipelines/Windows-VS2019.yml
index 22f2d88c2c6a..e4bd4b1d2283 100644
--- a/.azurepipelines/Windows-VS2019.yml
+++ b/.azurepipelines/Windows-VS2019.yml
@@ -16,5 +16,5 @@ jobs:
- template: templates/pr-gate-build-job.yml
parameters:
tool_chain_tag: 'VS2019'
- vm_image: 'windows-latest'
+ vm_image: 'windows-2019'
arch_list: "IA32,X64"
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 2/3] EmulatorPkg: Use windows-2019 VM image
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 1/3] .azurepipelines: Use windows-2019 VM image Michael Kubacki
@ 2022-04-01 17:12 ` Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 3/3] OvmfPkg: " Michael Kubacki
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Michael Kubacki @ 2022-04-01 17:12 UTC (permalink / raw)
To: devel; +Cc: Andrew Fish, Ray Ni, Abner Chang, Nickle Wang
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
index 03ffb1a5a5c7..e7ead06ae266 100644
--- a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
+++ b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
@@ -20,7 +20,7 @@ jobs:
- job: Platform_CI
variables:
package: 'EmulatorPkg'
- vm_image: 'windows-latest'
+ vm_image: 'windows-2019'
should_run: true
run_flags: "MAKE_STARTUP_NSH=TRUE"
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 3/3] OvmfPkg: Use windows-2019 VM image
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 1/3] .azurepipelines: Use windows-2019 VM image Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 2/3] EmulatorPkg: " Michael Kubacki
@ 2022-04-01 17:12 ` Michael Kubacki
2022-04-01 17:42 ` [edk2-devel] [PATCH v1 0/3] Use windows-2019 VM Image Sean
2022-04-01 23:29 ` Michael D Kinney
4 siblings, 0 replies; 6+ messages in thread
From: Michael Kubacki @ 2022-04-01 17:12 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
index 68b5d951e908..7d6344d6383d 100644
--- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
+++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
@@ -18,7 +18,7 @@ jobs:
- job: Platform_CI
variables:
package: 'OvmfPkg'
- vm_image: 'windows-latest'
+ vm_image: 'windows-2019'
should_run: true
run_flags: "MAKE_STARTUP_NSH=TRUE QEMU_HEADLESS=TRUE"
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/3] Use windows-2019 VM Image
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
` (2 preceding siblings ...)
2022-04-01 17:12 ` [PATCH v1 3/3] OvmfPkg: " Michael Kubacki
@ 2022-04-01 17:42 ` Sean
2022-04-01 23:29 ` Michael D Kinney
4 siblings, 0 replies; 6+ messages in thread
From: Sean @ 2022-04-01 17:42 UTC (permalink / raw)
To: Michael Kubacki, devel
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
Given this is all CI related and the CI is down. I will offer my reviewed by for the series.
Reviewed - by : Sean Brogan <sean.brogan@microsoft.com>
[-- Attachment #2: Type: text/html, Size: 250 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/3] Use windows-2019 VM Image
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
` (3 preceding siblings ...)
2022-04-01 17:42 ` [edk2-devel] [PATCH v1 0/3] Use windows-2019 VM Image Sean
@ 2022-04-01 23:29 ` Michael D Kinney
4 siblings, 0 replies; 6+ messages in thread
From: Michael D Kinney @ 2022-04-01 23:29 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io,
Kinney, Michael D
Cc: Sean Brogan, Bret Barkelew, Gao, Liming, Andrew Fish, Ni, Ray,
Chang, Abner, Wang, Nickle, Ard Biesheuvel, Yao, Jiewen,
Justen, Jordan L, Gerd Hoffmann
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Friday, April 1, 2022 10:12 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>; Chang, Abner <abner.chang@hpe.com>; Wang, Nickle <nickle.wang@hpe.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>
> Subject: [PATCH v1 0/3] Use windows-2019 VM Image
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
>
> Pipelines are currently building against VS2019 and use the
> "windows-latest" VM image in Azure Pipelines. The "windows-latest"
> image recently moved its toolchain to VS2022, so VS2019 is no
> longer found.
>
> To immediately address the issue with no change in build behavior,
> this series updates YAML files in the repository using
> "windows-latest" to "windows-2019".
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (3):
> .azurepipelines: Use windows-2019 VM image
> EmulatorPkg: Use windows-2019 VM image
> OvmfPkg: Use windows-2019 VM image
>
> .azurepipelines/Windows-VS2019.yml | 2 +-
> EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
> OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-01 23:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 17:12 [PATCH v1 0/3] Use windows-2019 VM Image Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 1/3] .azurepipelines: Use windows-2019 VM image Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 2/3] EmulatorPkg: " Michael Kubacki
2022-04-01 17:12 ` [PATCH v1 3/3] OvmfPkg: " Michael Kubacki
2022-04-01 17:42 ` [edk2-devel] [PATCH v1 0/3] Use windows-2019 VM Image Sean
2022-04-01 23:29 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox