From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.5203.1648850346227259429 for ; Fri, 01 Apr 2022 14:59:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=auVjh8cm; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id EC05320DEDCA; Fri, 1 Apr 2022 14:59:04 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EC05320DEDCA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1648850345; bh=x/Hwe77QG4qTK1B5hbP9Ekp0g/o8s8eW06Hp2ul7Hao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=auVjh8cmQuVwKkXYv6GrifiD+ILFzu5wHF034PIM4tVMABOV5kUgADnVR2Drtshul FKb0rzEcIhXSdWvZIQq3qnmH1MJ6cybD543Mbt3aGkmHG7J82HsrnfsxR/EQH97Ixo SsxG1BG3GdEvH3HvqzP+8vYzP6GAM+u3JNv/58OI= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Sean Brogan , Bret Barkelew , Jiewen Yao Subject: [PATCH v3 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths Date: Fri, 1 Apr 2022 17:58:29 -0400 Message-Id: <20220401215832.2523-2-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220401215832.2523-1-mikuback@linux.microsoft.com> References: <20220401215832.2523-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki Currently, UncrustifyCheck._get_git_ignored_paths() is documented to return a list of absolute file paths but it currently returns a list of relative file paths. This change updates the function to return a list of absolute file paths. The result is later compared to the list of absolute file paths for files to run against Uncrustify. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Jiewen Yao --- .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/= Plugin/UncrustifyCheck/UncrustifyCheck.py index 82db7a5a438b..6920580646de 100644 --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py @@ -292,7 +292,12 @@ class UncrustifyCheck(ICiBuildPlugin): f"An error occurred reading git ignore settings. This wi= ll prevent Uncrustify from running against the expected set of files.") =20 # Note: This will potentially be a large list, but at least sort= ed - return outstream_buffer.getvalue().strip().splitlines() + rel_paths =3D outstream_buffer.getvalue().strip().splitlines() + abs_paths =3D [] + for path in rel_paths: + abs_paths.append( + os.path.normpath(os.path.join(self._abs_workspace_path, = path))) + return abs_paths =20 def _get_git_submodule_paths(self) -> List[str]: """ --=20 2.28.0.windows.1