From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH v1 0/3] Add Variable Flash Info HOB
Date: Wed, 6 Apr 2022 12:26:45 -0400 [thread overview]
Message-ID: <20220406162648.234-1-mikuback@linux.microsoft.com> (raw)
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.
For example:
[Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.
This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.
The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com
Michael Kubacki (3):
MdeModulePkg: Add Variable Flash Info HOB
MdeModulePkg/Variable: Consume Variable Info HOB
MdeModulePkg/FaultTolerantWrite: Consume Variable Info HOB
MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c | 111 +++++++++++++++++---
MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c | 7 +-
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c | 92 ++++++++++++++--
MdeModulePkg/Universal/Variable/Pei/Variable.c | 66 +++++++++++-
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 42 ++++++++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 25 ++++-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c | 20 +++-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 20 +++-
MdeModulePkg/Include/Guid/VariableFlashInfo.h | 36 +++++++
MdeModulePkg/MdeModulePkg.dec | 4 +
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.h | 9 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf | 11 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf | 11 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf | 11 +-
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf | 10 +-
MdeModulePkg/Universal/Variable/Pei/Variable.h | 2 +
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf | 6 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h | 17 +++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf | 6 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 6 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 6 +-
21 files changed, 455 insertions(+), 63 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/VariableFlashInfo.h
--
2.28.0.windows.1
next reply other threads:[~2022-04-06 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 16:26 Michael Kubacki [this message]
2022-04-06 16:26 ` [PATCH v1 1/3] MdeModulePkg: Add Variable Flash Info HOB Michael Kubacki
2022-04-06 16:26 ` [PATCH v1 2/3] MdeModulePkg/Variable: Consume Variable " Michael Kubacki
2022-04-07 3:31 ` [edk2-devel] " Wu, Hao A
2022-04-06 16:26 ` [PATCH v1 3/3] MdeModulePkg/FaultTolerantWrite: " Michael Kubacki
2022-04-07 3:31 ` [edk2-devel] " Wu, Hao A
2022-04-07 3:31 ` [edk2-devel] [PATCH v1 0/3] Add Variable Flash " Wu, Hao A
2022-04-07 23:56 ` Michael Kubacki
2022-04-08 21:20 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406162648.234-1-mikuback@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox