From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Yuwei Chen <yuwei.chen@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Pawel Polawski <ppolawsk@redhat.com>,
Bob Feng <bob.c.feng@intel.com>,
Oliver Steffen <osteffen@redhat.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround
Date: Thu, 7 Apr 2022 12:12:25 +0200 [thread overview]
Message-ID: <20220407101225.d2m2i4h2dsacaw57@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAKbZUD2Em5HiTJEAtA1PSwtKE5iDGWgN5Xmw5bWxf28qmtLisQ@mail.gmail.com>
On Mon, Apr 04, 2022 at 04:18:56PM +0100, Pedro Falcato wrote:
> Hi Gerd,
>
> These patches are a great idea but I don't know if we can take GPLv2 code
> like that. Are they even mergeable into the main edk2 repo (as it's not
> compatible with BSD-2-clause)?
It's build system, doesn't end up being linked into firmware code, so
not sure license compatibility is actually a problem here.
In any case I strongly prefer to fix that in some automatic way which
does *not* require a new GCC12 tool chain definition.
So, any comments how to move forward with this?
Can we take the series as-is?
If not, other suggestions?
Second-best idea I've seen on the list is using 'gcc -dumpversion'.
Is it an option to just raise the minimum required gcc version to
something newer? gcc5 was released almost 7 years ago ...
take care,
Gerd
next prev parent reply other threads:[~2022-04-07 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 9:32 [PATCH v3 0/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 1/3] BaseTools: import compiler check macros from linux kernel Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 2/3] BaseTools: adapt comniler checks mmacros for edk2 Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 3/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04 15:18 ` [edk2-devel] [PATCH v3 0/3] " Pedro Falcato
2022-04-07 10:12 ` Gerd Hoffmann [this message]
2022-04-09 3:53 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407101225.d2m2i4h2dsacaw57@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox