From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.4920.1649326359090285404
 for <devel@edk2.groups.io>;
 Thu, 07 Apr 2022 03:12:39 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MCe9swT1;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649326358;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=G7RUBMw4mr3NUitcWdH2BlXyn4/YzheVqx02B5qsAq8=;
	b=MCe9swT11OSVoZd7boRqr0zH5TjPN06ESNoqMwsvhuwoxOzQSKO2c8Wyt0u+UGnoGOZkJt
	VEb59JsEkj9VHy1O/Rb+G949m4Ts9aiXfArzc8BZ4D5vDc6yR6Btr9rtNd9/542f9GUDHm
	Jur6wQteI5f7yu4hDBqAFw/8Dc6XhFI=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-554-SP8DpPFwNTSCw73NYSSWtQ-1; Thu, 07 Apr 2022 06:12:34 -0400
X-MC-Unique: SP8DpPFwNTSCw73NYSSWtQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0605D90184D;
	Thu,  7 Apr 2022 10:12:27 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.9])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A4DDCC44AE2;
	Thu,  7 Apr 2022 10:12:26 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0C8B418000B3; Thu,  7 Apr 2022 12:12:25 +0200 (CEST)
Date: Thu, 7 Apr 2022 12:12:25 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Bob Feng <bob.c.feng@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround
Message-ID: <20220407101225.d2m2i4h2dsacaw57@sirius.home.kraxel.org>
References: <20220404093229.1971782-1-kraxel@redhat.com>
 <CAKbZUD2Em5HiTJEAtA1PSwtKE5iDGWgN5Xmw5bWxf28qmtLisQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKbZUD2Em5HiTJEAtA1PSwtKE5iDGWgN5Xmw5bWxf28qmtLisQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 04, 2022 at 04:18:56PM +0100, Pedro Falcato wrote:
> Hi Gerd,
> 
> These patches are a great idea but I don't know if we can take GPLv2 code
> like that. Are they even mergeable into the main edk2 repo (as it's not
> compatible with BSD-2-clause)?

It's build system, doesn't end up being linked into firmware code, so
not sure license compatibility is actually a problem here.

In any case I strongly prefer to fix that in some automatic way which
does *not* require a new GCC12 tool chain definition.

So, any comments how to move forward with this?
Can we take the series as-is?
If not, other suggestions?
Second-best idea I've seen on the list is using 'gcc -dumpversion'.

Is it an option to just raise the minimum required gcc version to
something newer?  gcc5 was released almost 7 years ago ...

take care,
  Gerd