From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib
Date: Thu, 7 Apr 2022 23:01:43 +0100 [thread overview]
Message-ID: <20220407220146.149580-1-pedro.falcato@gmail.com> (raw)
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871
Hi all,
This patch-set attempts to address two open feature requests for Ext4Pkg
by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib (id 3871).
The previous patch-set regarding 3871 attempted to merge the different crc16 implementations
but failed because, contrary to what I thought, there are many, many different CRC16s which
are all slightly different. This one (plus the separate edk2 patch) attempts to just merge
CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.
Since this patch set grew to be considerably different from the original, I didn't mark it
as v2 but rather a separate, new patch-set.
CC'ing the edk2-platforms stewards (as I cannot review my own code) and the CC's of the MdePkg
patch.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Pedro Falcato (3):
Ext4Pkg: Replace the CRC implementations with BaseLib
Ext4Pkg: Format using uncrustify
Ext4Pkg: Add ext2/3 support
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +-
Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++
Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +-
Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 -----
Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------
Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +-
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +-
Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +-
Features/Ext4Pkg/Ext4Dxe/File.c | 19 +-
Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +-
Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +-
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +-
16 files changed, 640 insertions(+), 487 deletions(-)
create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c
--
2.35.1
next reply other threads:[~2022-04-07 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 22:01 Pedro Falcato [this message]
2022-04-07 22:01 ` [PATCH edk2-platforms 1/3] Ext4Pkg: Replace the CRC implementations with BaseLib Pedro Falcato
2022-04-07 22:01 ` [PATCH edk2-platforms 2/3] Ext4Pkg: Format using uncrustify Pedro Falcato
2022-04-07 22:01 ` [PATCH edk2-platforms 3/3] Ext4Pkg: Add ext2/3 support Pedro Falcato
2022-04-25 17:14 ` [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib Pedro Falcato
[not found] ` <16E9330A7A87074F.18109@groups.io>
2022-05-11 17:41 ` [edk2-devel] " Pedro Falcato
[not found] ` <16EE1DD8FA9A45F3.9448@groups.io>
2022-05-31 21:32 ` Pedro Falcato
2022-06-02 3:04 ` 回复: " gaoliming
2022-06-13 14:45 ` Pedro Falcato
2022-06-14 1:11 ` 回复: " gaoliming
2022-06-14 15:58 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407220146.149580-1-pedro.falcato@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox