From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
Date: Sun, 10 Apr 2022 19:16:58 -0600 [thread overview]
Message-ID: <20220411011659.191390-3-rebecca@bsdio.com> (raw)
In-Reply-To: <20220411011659.191390-1-rebecca@bsdio.com>
The debugger in Arm Development Studio 2021.2 doesn't work with
"ec = debugger.getExecutionContext(0)" because it's subsequently unable
to access memory. Fix it by switching to
"ec = debugger.getCurrentExecutionContext()".
The documentation for waitForStop() says:
"It is not needed after a call to stop() because stop() is blocking."
So, remove the call to waitForStop.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
index 89d2f28ba27d..cb4db148dedf 100644
--- a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
+++ b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
@@ -85,11 +85,10 @@ else:
debugger = Debugger()
# Initialisation commands
-ec = debugger.getExecutionContext(0)
+ec = debugger.getCurrentExecutionContext()
ec.getExecutionService().stop()
-ec.getExecutionService().waitForStop()
# in case the execution context reference is out of date
-ec = debugger.getExecutionContext(0)
+ec = debugger.getCurrentExecutionContext()
try:
armplatform_debugger = edk2_debugger.ArmPlatformDebugger(ec, report_file, regions, verbose)
--
2.25.1
next prev parent reply other threads:[~2022-04-11 1:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 1:16 [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile Rebecca Cran
2022-04-11 1:16 ` [PATCH 1/3] ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py Rebecca Cran
2022-04-11 1:16 ` Rebecca Cran [this message]
2022-04-11 17:39 ` [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py Rebecca Cran
2022-04-11 1:16 ` [PATCH 3/3] ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile Rebecca Cran
2022-04-11 1:18 ` [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile Rebecca Cran
2022-04-13 16:51 ` [edk2-devel] " Ard Biesheuvel
2022-04-13 16:56 ` Rebecca Cran
2022-04-20 0:43 ` Rebecca Cran
2022-05-03 9:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411011659.191390-3-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox