public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: [PATCH 3/3] ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile
Date: Sun, 10 Apr 2022 19:16:59 -0600	[thread overview]
Message-ID: <20220411011659.191390-4-rebecca@bsdio.com> (raw)
In-Reply-To: <20220411011659.191390-1-rebecca@bsdio.com>

With GNU Make 4.2.1, ifeq ($(EDK2_DSC),"") doesn't catch the case where
EDK2_DSC isn't defined. So, switch to using ifndef.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 ArmPlatformPkg/Scripts/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPlatformPkg/Scripts/Makefile b/ArmPlatformPkg/Scripts/Makefile
index da949dc1ed56..270fc80b6ae8 100644
--- a/ArmPlatformPkg/Scripts/Makefile
+++ b/ArmPlatformPkg/Scripts/Makefile
@@ -12,7 +12,7 @@ EDK2_TOOLCHAIN ?= RVCTLINUX
 EDK2_ARCH ?= ARM
 EDK2_BUILD ?= DEBUG
 
-ifeq ($(EDK2_DSC),"")
+ifndef EDK2_DSC
   $(error The Makfile macro 'EDK2_DSC' must be defined with an EDK2 DSC file.)
 endif
 ifeq ("$(EDK2_DSC)","ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc")
-- 
2.25.1


  parent reply	other threads:[~2022-04-11  1:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  1:16 [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile Rebecca Cran
2022-04-11  1:16 ` [PATCH 1/3] ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py Rebecca Cran
2022-04-11  1:16 ` [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py Rebecca Cran
2022-04-11 17:39   ` Rebecca Cran
2022-04-11  1:16 ` Rebecca Cran [this message]
2022-04-11  1:18 ` [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile Rebecca Cran
2022-04-13 16:51   ` [edk2-devel] " Ard Biesheuvel
2022-04-13 16:56     ` Rebecca Cran
2022-04-20  0:43 ` Rebecca Cran
2022-05-03  9:14   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411011659.191390-4-rebecca@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox