From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.24504.1649639843492322392 for ; Sun, 10 Apr 2022 18:17:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=fm2 header.b=IeWX2RGw; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CED585C010D; Sun, 10 Apr 2022 21:17:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 10 Apr 2022 21:17:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=8kXyo7EL7/P3yb1J+gX0B0+nOOhooS TLOKBEaIeocyE=; b=IeWX2RGwWLSuIqbd1YCWaPgGmwwpozmccWBvYTr+NLn3pM p4uZVey4vj6HPwOu/Sj/SYlZ4/tUbv4j6zdhifUtVFZ7F94K9NI35kwZ/jbzgakz XwyGAD0ibI2E33+UD7cZrTa+3l5kRgQzmkLIESEQvVWHwD5bp/LoNDAY6fwf5eSl nCeskZffG7PP1slDTC78puQFwzutDsfduj0LVYfb9jjbwBVkxlm13M7/X/CS/RXo cO4EDDmgPtptTvfgPkN+L+da3rv+TRqI7yw+++K7zKiU1mwH+2Mdfltmo3GSlfAA KQrqTmD0kcvFDecTa/OJcJy7UkhXzg5hxwhncSdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8kXyo7 EL7/P3yb1J+gX0B0+nOOhooSTLOKBEaIeocyE=; b=VA185xwDZ76yE20GnKombe Lnnir5ykS6YZYq7h4jLo71y+h1OWrX7egUopcEU3yiOuJ5yY+5qP1ADe23LGMWW9 bv3q9zCPf3Yk17wyiQYrAjEOhl22XNXU02f6aQm7I72iewf3erO5QWESuaT/ZkCo 8WM8XONds9s8B7h72o1bZ+Nfa32FgBiDbZ6yavJDAbUHJKWv3QjZlyh4zuMZDi0r 5/T8CGeaaYrhzfv6fL+QdvlIAih5e9PFvtxAgpbDLvoYDqT/Z/bpQbs5aIMLh1gO V8/sz02IgtCCxjCNFeGgL9GU7m2Xlv8E0vu1qN+9MS+NPmq8BpTRYO8S1WZNTmFg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekhedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghs ughiohdrtghomheqnecuggftrfgrthhtvghrnhepveeiffeivdevudetueehiedthedthe fhtdehfeelkeeitdfhhfefleetieehgfevnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Apr 2022 21:17:22 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [PATCH 3/3] ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile Date: Sun, 10 Apr 2022 19:16:59 -0600 Message-Id: <20220411011659.191390-4-rebecca@bsdio.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220411011659.191390-1-rebecca@bsdio.com> References: <20220411011659.191390-1-rebecca@bsdio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With GNU Make 4.2.1, ifeq ($(EDK2_DSC),"") doesn't catch the case where EDK2_DSC isn't defined. So, switch to using ifndef. Signed-off-by: Rebecca Cran --- ArmPlatformPkg/Scripts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Scripts/Makefile b/ArmPlatformPkg/Scripts/Makefile index da949dc1ed56..270fc80b6ae8 100644 --- a/ArmPlatformPkg/Scripts/Makefile +++ b/ArmPlatformPkg/Scripts/Makefile @@ -12,7 +12,7 @@ EDK2_TOOLCHAIN ?= RVCTLINUX EDK2_ARCH ?= ARM EDK2_BUILD ?= DEBUG -ifeq ($(EDK2_DSC),"") +ifndef EDK2_DSC $(error The Makfile macro 'EDK2_DSC' must be defined with an EDK2 DSC file.) endif ifeq ("$(EDK2_DSC)","ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc") -- 2.25.1