From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Oliver Steffen <osteffen@redhat.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
Xiaoyu Lu <xiaoyux.lu@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy
Date: Mon, 11 Apr 2022 08:58:43 +0200 [thread overview]
Message-ID: <20220411065843.i4m3dl4u4pdgqfp7@sirius.home.kraxel.org> (raw)
In-Reply-To: <MW4PR11MB5872A3184379A398D4119F5A8CE99@MW4PR11MB5872.namprd11.prod.outlook.com>
On Fri, Apr 08, 2022 at 12:18:17PM +0000, Yao, Jiewen wrote:
> Can we remove inline keyword?
>
> I don't think it is really needed in EDKII project.
Well, in the header file it is, otherwise we'll get duplicate symbol
errors.
We could probably move the implementation from
CryptoPkg/Library/Include/CrtLibSupport.h to
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c,
then drop the inline keyword.
take care,
Gerd
next prev parent reply other threads:[~2022-04-11 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 11:16 [PATCH v2 0/8] CryptoPkg updates for openssl 3.0 Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 1/8] CryptoPkg/CrtLibSupport: add fcntl.h Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 2/8] CryptoPkg/CrtLibSupport: add strstr() Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 3/8] CryptoPkg/CrtLibSupport: add INT_MIN Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 4/8] CryptoPkg/CrtLibSupport: add UINT_MAX Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 5/8] CryptoPkg/CrtLibSupport: add MODULESDIR Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 6/8] CryptoPkg/CrtLibSupport: add off_t Gerd Hoffmann
2022-04-08 11:16 ` [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy Gerd Hoffmann
2022-04-08 12:18 ` Yao, Jiewen
2022-04-11 6:58 ` Gerd Hoffmann [this message]
2022-04-11 7:26 ` Yao, Jiewen
2022-04-08 11:16 ` [PATCH v2 8/8] CryptoPkg/UnitTest: fix DH testcase Gerd Hoffmann
2022-04-08 12:18 ` [PATCH v2 0/8] CryptoPkg updates for openssl 3.0 Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411065843.i4m3dl4u4pdgqfp7@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox