From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.26013.1649660330825441095
 for <devel@edk2.groups.io>;
 Sun, 10 Apr 2022 23:58:51 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZR2BG+Ih;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649660329;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=stqAXt2GJmZWE16GbrfxNtOW4phmfLwkwKE4iK+UcGw=;
	b=ZR2BG+Ihp8pWPVTA3MQMfbbe/fuKt+YeqkypKVvxyTk8XKOXv1XY3pAZEd+xjkMKVwyB2e
	ptSXubCyID4ofaLceLJh0h6/rm0Sf4zqbuIgoc8wc7x2P/ZhaAEyZZH4V85EMbPGS54pMK
	GLMYfvsvkCqYu3/jyul45xrSUo5FYsY=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-161-0w6LJobFOfib6k4f8Jj3Ew-1; Mon, 11 Apr 2022 02:58:46 -0400
X-MC-Unique: 0w6LJobFOfib6k4f8Jj3Ew-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 936CA2A2AD43;
	Mon, 11 Apr 2022 06:58:45 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.9])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 671F6C27D90;
	Mon, 11 Apr 2022 06:58:45 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id EB5E218003A2; Mon, 11 Apr 2022 08:58:43 +0200 (CEST)
Date: Mon, 11 Apr 2022 08:58:43 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Oliver Steffen <osteffen@redhat.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	Xiaoyu Lu <xiaoyux.lu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy
Message-ID: <20220411065843.i4m3dl4u4pdgqfp7@sirius.home.kraxel.org>
References: <20220408111622.3519517-1-kraxel@redhat.com>
 <20220408111622.3519517-8-kraxel@redhat.com>
 <MW4PR11MB5872A3184379A398D4119F5A8CE99@MW4PR11MB5872.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MW4PR11MB5872A3184379A398D4119F5A8CE99@MW4PR11MB5872.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 08, 2022 at 12:18:17PM +0000, Yao, Jiewen wrote:
> Can we remove inline keyword?
> 
> I don't think it is really needed in EDKII project.

Well, in the header file it is, otherwise we'll get duplicate symbol
errors.

We could probably move the implementation from
CryptoPkg/Library/Include/CrtLibSupport.h to
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c,
then drop the inline keyword.

take care,
  Gerd