public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chen, Gang C" <gang.c.chen@intel.com>
To: devel@edk2.groups.io
Cc: guomin.jiang@intel.com, dandan.bi@intel.com, di.zhang@intel.com,
	Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: remove duplicated pcd check
Date: Mon, 11 Apr 2022 18:13:50 +0800	[thread overview]
Message-ID: <20220411101350.697997-3-gang.c.chen@intel.com> (raw)
In-Reply-To: <20220411101350.697997-1-gang.c.chen@intel.com>

Remove the duplicated PcdCpuStackGuard check for it has been checked at
the entry of InitializeMpExceptionStackSwitchHandlers, which will invoke
the current function.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: devel@edk2.groups.io

Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
index 687fc4177f..bcd4175ffa 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
@@ -254,7 +254,7 @@ InitializeCpuExceptionHandlersEx (
     //
     // Initializing stack switch is only necessary for Stack Guard functionality.
     //
-    if (PcdGetBool (PcdCpuStackGuard) && (InitData != NULL)) {
+    if (InitData != NULL) {
       Status = ArchSetupExceptionStack (InitData);
     }
   }
-- 
2.35.1


      parent reply	other threads:[~2022-04-11 10:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 10:13 [PATCH 0/2] update the property of PcdCpuStackGuard Chen, Gang C
2022-04-11 10:13 ` [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property Chen, Gang C
2022-04-11 13:55   ` [edk2-devel] " Ni, Ray
2022-04-11 14:51     ` Chen, Gang C
2022-04-12  6:07       ` Jeff Fan
2022-04-12  6:28   ` Jeff Fan
2022-04-11 10:13 ` Chen, Gang C [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411101350.697997-3-gang.c.chen@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox