From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.8580.1649754243550954326
 for <devel@edk2.groups.io>;
 Tue, 12 Apr 2022 02:04:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PJsn9pfP;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649754242;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bFYg98K6Edf5MBO5f8W2OGL+OICnU9q7jgGA7DEM+qk=;
	b=PJsn9pfPOBLYfgRMXu//Eo66Ho2FR+SMCOPdPRqifpMTlwDjR4R+kb8OM7sPcBCqGGgrWq
	URfl3TLcxcntutEk3R3VTC0qhpA5eXKE1bRPmaK2LVjKSW0A7Nwzpemcbt/fRwaehMXYnm
	iTf2Q9xDoKDfSr0X0jj0XJxJGaNxR38=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-662-t1ixMI6QOeufsn26fRAXIA-1; Tue, 12 Apr 2022 05:03:59 -0400
X-MC-Unique: t1ixMI6QOeufsn26fRAXIA-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C1B8800882;
	Tue, 12 Apr 2022 09:03:58 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.9])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3167B401E13;
	Tue, 12 Apr 2022 09:03:57 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 730EE180039F; Tue, 12 Apr 2022 11:03:56 +0200 (CEST)
Date: Tue, 12 Apr 2022 11:03:56 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>, Ray Ni <ray.ni@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory
Message-ID: <20220412090356.ko5np3i64lqlohuy@sirius.home.kraxel.org>
References: <20220407093304.1551182-1-kraxel@redhat.com>
 <20220407093304.1551182-3-kraxel@redhat.com>
 <PH0PR84MB1647865CB710C8B711AD5CB3FFED9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
In-Reply-To: <PH0PR84MB1647865CB710C8B711AD5CB3FFED9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > -  Io.Base   = IoBase;
> > -  Io.Limit  = IoBase + IoSize - 1;
> > +  if (IoSize) {
> > +    Io.Base  = IoBase;
> > +    Io.Limit = IoBase + IoSize - 1;
> > +  } else {
> > +    Io.Base  = MAX_UINT64;
> > +    Io.Limit = 0;
> HI Gerd,
> Does the consumer of Io (in PCI_ROOT_BRIDGE structure) know that the MAX_UINT64 for Io.Base refers to no memory map I/O?

Patch #1 handles that.

take care,
  Gerd