From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.7510.1649743640165114384 for ; Mon, 11 Apr 2022 23:07:22 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: fanjianfeng@byosoft.com.cn) Received: from DESKTOP-M5NI163 ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 12 Apr 2022 14:07:15 +0800 X-WM-Sender: fanjianfeng@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: fanjianfeng@byosoft.com.cn Date: Tue, 12 Apr 2022 14:07:15 +0800 From: "Jeff Fan" To: "devel@edk2.groups.io" , gang.c.chen , =?utf-8?B?TmksIFJheQ==?= , =?utf-8?B?TGl1LCBTaHVv?= Cc: =?utf-8?B?SmlhbmcsIEd1b21pbg==?= , =?utf-8?B?QmksIERhbmRhbg==?= , =?utf-8?B?WmhhbmcsIERp?= , =?utf-8?B?V2FuZywgSmlhbiBK?= , 'gaoliming' Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property References: <20220411101350.697997-1-gang.c.chen@intel.com>, <20220411101350.697997-2-gang.c.chen@intel.com>, , X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.2.20.269[cn] Mime-Version: 1.0 Message-ID: <2022041214071585081711@byosoft.com.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart348182651881_=----" ------=_001_NextPart348182651881_=---- Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMzJiaXQgcHJvdGVjdGQgbW9kZSwgaXMgdGhlcmUgYW55IGltcGFjdCBpZiBQY2RDcHVTdGFj a0d1YXJkIGlzIHNldCB0byBUUlVFPyAgRXZlbiB0aGVycyBpcyBubyBwYWdlIHRhYmxlIGVuYWJs aW5nIGF0IHRoYXQgdGltZS4NCg0KQmVzdCBSZWdhcmRzLA0KSmVmZg0KDQoNCg0KZmFuamlhbmZl bmdAYnlvc29mdC5jb20uY24NCiANCkZyb206IENoZW4sIEdhbmcgQw0KRGF0ZTogMjAyMi0wNC0x MSAyMjo1MQ0KVG86IE5pLCBSYXk7IGRldmVsQGVkazIuZ3JvdXBzLmlvOyBMaXUsIFNodW8NCkND OiBKaWFuZywgR3VvbWluOyBCaSwgRGFuZGFuOyBaaGFuZywgRGk7IFdhbmcsIEppYW4gSjsgR2Fv LCBMaW1pbmcNClN1YmplY3Q6IFJlOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMl0gTWRlTW9kdWxl UGtnL2RlYzogdXBkYXRlIHRoZSBQY2RDcHVTdGFja0d1YXJkIHByb3BlcnR5DQpUaGlzIGltcGFj dCBvZiB0aGlzIGNoYW5nZSBpcyBub3QgYXMgc2ltcGxlIGFzIHdoYXQgdGhlIHBhdGNoIGRvZXMu DQotLT5Zb3UncmUgY29ycmVjdCwgdGhhdCdzIHdoeSB0aGUgUEFUQ0ggMi8yIHJlbW92ZWQgdGhl IGNoZWNrIGluIEFQLg0KIA0KV2h5IGNhbm5vdCBGU1AgQVBJIGFuZCBEaXNwYXRjaCBtb2RlIHVz ZSB0aGUgc2FtZSBzZXR0aW5nPyAoZWl0aGVyIGVuYWJsZWQgb3IgZGlzYWJsZWQpDQotLT5Gb3Ig ZXhhbXBsZSwgaW4gY29yZWJvb3QsIGl0J3MgMzItYml0LCBzbyB0aGVyZSBpcyBubyBQYWdpbmcg bmVlZGVkLiBJbiB0aGlzIGNhc2UsIGl0IG5lZWRzIHRvIGRpc2FibGUgaXQgZm9yIEZTUCBBUEkg bW9kZS4gQnV0IHRoaXMgZmVhdHVyZSBpcyBuZWVkZWQgZm9yIERpc3BhdGNoIG1vZGUuIA0KIA0K QExpdSwgU2h1bywgaWYgYW55IGluZm9ybWF0aW9uIGlzIHdyb25nIG9yIG1pc3NlZCwgcGxlYXNl IGNvcnJlY3QgbWUuIFRoYW5rcy4NCiANCkJlc3QgUmVnYXJkcw0KR2FuZw0KIA0KLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IE5pLCBSYXkgPHJheS5uaUBpbnRlbC5jb20+IA0KU2Vu dDogTW9uZGF5LCBBcHJpbCAxMSwgMjAyMiA5OjU1IFBNDQpUbzogZGV2ZWxAZWRrMi5ncm91cHMu aW87IENoZW4sIEdhbmcgQyA8Z2FuZy5jLmNoZW5AaW50ZWwuY29tPg0KQ2M6IEppYW5nLCBHdW9t aW4gPGd1b21pbi5qaWFuZ0BpbnRlbC5jb20+OyBCaSwgRGFuZGFuIDxkYW5kYW4uYmlAaW50ZWwu Y29tPjsgWmhhbmcsIERpIDxkaS56aGFuZ0BpbnRlbC5jb20+OyBXYW5nLCBKaWFuIEogPGppYW4u ai53YW5nQGludGVsLmNvbT47IEdhbywgTGltaW5nIDxnYW9saW1pbmdAYnlvc29mdC5jb20uY24+ DQpTdWJqZWN0OiBSRTogW2VkazItZGV2ZWxdIFtQQVRDSCAxLzJdIE1kZU1vZHVsZVBrZy9kZWM6 IHVwZGF0ZSB0aGUgUGNkQ3B1U3RhY2tHdWFyZCBwcm9wZXJ0eQ0KIA0KRml4ZWRBdEJ1aWxkIFBD RCBjYW4gYmUgYWNjZXNzZWQgYXQgYW55IHRpbWUgZnJvbSBhbnkgQ1BVLg0KQnV0IGR5bmFtaWMg UENEIGNhbiBvbmx5IGJlIGFjY2Vzc2VkIGZyb20gQlNQIGFuZCBhZnRlciBQQ0QgZGF0YWJhc2Ug aXMgaW5pdGlhbGl6ZWQuDQogDQpUaGlzIGltcGFjdCBvZiB0aGlzIGNoYW5nZSBpcyBub3QgYXMg c2ltcGxlIGFzIHdoYXQgdGhlIHBhdGNoIGRvZXMuDQogDQpXaHkgY2Fubm90IEZTUCBBUEkgYW5k IERpc3BhdGNoIG1vZGUgdXNlIHRoZSBzYW1lIHNldHRpbmc/IChlaXRoZXIgZW5hYmxlZCBvciBk aXNhYmxlZCkNCiANClRoYW5rcywNClJheQ0KIA0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiBGcm9tOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbyA8ZGV2ZWxAZWRrMi5ncm91cHMuaW8+IE9u IEJlaGFsZiBPZiBDaGVuLCANCj4gR2FuZyBDDQo+IFNlbnQ6IE1vbmRheSwgQXByaWwgMTEsIDIw MjIgNjoxNCBQTQ0KPiBUbzogZGV2ZWxAZWRrMi5ncm91cHMuaW8NCj4gQ2M6IEppYW5nLCBHdW9t aW4gPGd1b21pbi5qaWFuZ0BpbnRlbC5jb20+OyBCaSwgRGFuZGFuIA0KPiA8ZGFuZGFuLmJpQGlu dGVsLmNvbT47IFpoYW5nLCBEaSA8ZGkuemhhbmdAaW50ZWwuY29tPjsgV2FuZywgSmlhbiBKIA0K PiA8amlhbi5qLndhbmdAaW50ZWwuY29tPjsgR2FvLCBMaW1pbmcgPGdhb2xpbWluZ0BieW9zb2Z0 LmNvbS5jbj4NCj4gU3ViamVjdDogW2VkazItZGV2ZWxdIFtQQVRDSCAxLzJdIE1kZU1vZHVsZVBr Zy9kZWM6IHVwZGF0ZSB0aGUgDQo+IFBjZENwdVN0YWNrR3VhcmQgcHJvcGVydHkNCj4gDQo+IFVw ZGF0ZSB0aGUgUGNkQ3B1U3RhY2tHdWFyZCBmcm9tIFBjZHNGaXhlZEF0QnVpbGQgdG8gUGNkc0R5 bmFtaWNFeCBmb3IgDQo+IHRoZSByZXF1aXJlbWVudCB0byBzZXQgZGlmZmVyZW50IHZhbHVlIGlu IEZTUCBBUEkgbW9kZSBhbmQgRlNQIA0KPiBEaXNwYXRjaCBtb2RlLg0KPiANCj4gUkVGOiBodHRw czovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lkPTM4OTcNCj4gDQo+IENj OiBKaWFuIEogV2FuZyA8amlhbi5qLndhbmdAaW50ZWwuY29tPg0KPiBDYzogTGltaW5nIEdhbyA8 Z2FvbGltaW5nQGJ5b3NvZnQuY29tLmNuPg0KPiBDYzogZGV2ZWxAZWRrMi5ncm91cHMuaW8NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IEdhbmcgQ2hlbiA8Z2FuZy5jLmNoZW5AaW50ZWwuY29tPg0KPiAt LS0NCj4gIE1kZU1vZHVsZVBrZy9NZGVNb2R1bGVQa2cuZGVjIHwgMTQgKysrKysrKy0tLS0tLS0N Cj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+IA0K PiBkaWZmIC0tZ2l0IGEvTWRlTW9kdWxlUGtnL01kZU1vZHVsZVBrZy5kZWMgDQo+IGIvTWRlTW9k dWxlUGtnL01kZU1vZHVsZVBrZy5kZWMgaW5kZXggNDYzZTg4OWU5YS4uNzJlN2UyZWNlZCAxMDA2 NDQNCj4gLS0tIGEvTWRlTW9kdWxlUGtnL01kZU1vZHVsZVBrZy5kZWMNCj4gKysrIGIvTWRlTW9k dWxlUGtnL01kZU1vZHVsZVBrZy5kZWMNCj4gQEAgLTEwNzAsMTMgKzEwNzAsNiBAQA0KPiAgICAj IEBQcm9tcHQgVGhlIEhlYXAgR3VhcmQgZmVhdHVyZSBtYXNrDQo+ICAgIA0KPiBnRWZpTWRlTW9k dWxlUGtnVG9rZW5TcGFjZUd1aWQuUGNkSGVhcEd1YXJkUHJvcGVydHlNYXNrfDB4MHxVSU5UOHww eDMwDQo+IDAwMTA1NA0KPiANCj4gLSAgIyMgSW5kaWNhdGVzIGlmIFVFRkkgU3RhY2sgR3VhcmQg d2lsbCBiZSBlbmFibGVkLg0KPiAtICAjICBJZiBlbmFibGVkLCBzdGFjayBvdmVyZmxvdyBpbiBV RUZJIGNhbiBiZSBjYXVnaHQsIHByZXZlbnRpbmcgY2hhb3RpYyBjb25zZXF1ZW5jZXMuPEJSPjxC Uj4NCj4gLSAgIyAgIFRSVUUgIC0gVUVGSSBTdGFjayBHdWFyZCB3aWxsIGJlIGVuYWJsZWQuPEJS Pg0KPiAtICAjICAgRkFMU0UgLSBVRUZJIFN0YWNrIEd1YXJkIHdpbGwgYmUgZGlzYWJsZWQuPEJS Pg0KPiAtICAjIEBQcm9tcHQgRW5hYmxlIFVFRkkgU3RhY2sgR3VhcmQuDQo+IC0gIA0KPiBnRWZp TWRlTW9kdWxlUGtnVG9rZW5TcGFjZUd1aWQuUGNkQ3B1U3RhY2tHdWFyZHxGQUxTRXxCT09MRUFO fDB4MzAwMDEwDQo+IDU1DQo+IC0NCj4gIFtQY2RzRml4ZWRBdEJ1aWxkLCBQY2RzUGF0Y2hhYmxl SW5Nb2R1bGVdDQo+ICAgICMjIER5bmFtaWMgdHlwZSBQQ0QgY2FuIGJlIHJlZ2lzdGVyZWQgY2Fs bGJhY2sgZnVuY3Rpb24gZm9yIFBjZCBzZXR0aW5nIGFjdGlvbi4NCj4gICAgIyAgUGNkTWF4UGVp UGNkQ2FsbEJhY2tOdW1iZXJQZXJQY2RFbnRyeSBpbmRpY2F0ZXMgdGhlIG1heGltdW0gDQo+IG51 bWJlciBvZiBjYWxsYmFjayBmdW5jdGlvbiBAQCAtMjA3OSw2ICsyMDcyLDEzIEBADQo+ICAgICMg QFByb21wdCBFbmFibGUgUENJZSBSZXNpemFibGUgQkFSIENhcGFiaWxpdHkgc3VwcG9ydC4NCj4g ICAgDQo+IGdFZmlNZGVNb2R1bGVQa2dUb2tlblNwYWNlR3VpZC5QY2RQY2llUmVzaXphYmxlQmFy U3VwcG9ydHxGQUxTRXxCT09MRUENCj4gTnwweDEwMDAwMDI0DQo+IA0KPiArICAjIyBJbmRpY2F0 ZXMgaWYgVUVGSSBTdGFjayBHdWFyZCB3aWxsIGJlIGVuYWJsZWQuDQo+ICsgICMgIElmIGVuYWJs ZWQsIHN0YWNrIG92ZXJmbG93IGluIFVFRkkgY2FuIGJlIGNhdWdodCwgcHJldmVudGluZyBjaGFv dGljIGNvbnNlcXVlbmNlcy48QlI+PEJSPg0KPiArICAjICAgVFJVRSAgLSBVRUZJIFN0YWNrIEd1 YXJkIHdpbGwgYmUgZW5hYmxlZC48QlI+DQo+ICsgICMgICBGQUxTRSAtIFVFRkkgU3RhY2sgR3Vh cmQgd2lsbCBiZSBkaXNhYmxlZC48QlI+DQo+ICsgICMgQFByb21wdCBFbmFibGUgVUVGSSBTdGFj ayBHdWFyZC4NCj4gKyAgDQo+ICsgZ0VmaU1kZU1vZHVsZVBrZ1Rva2VuU3BhY2VHdWlkLlBjZENw dVN0YWNrR3VhcmR8RkFMU0V8Qk9PTEVBTnwweDAwMDENCj4gKyAwMDI1DQo+ICsNCj4gIFtQY2Rz UGF0Y2hhYmxlSW5Nb2R1bGVdDQo+ICAgICMjIFNwZWNpZnkgbWVtb3J5IHNpemUgd2l0aCBwYWdl IG51bWJlciBmb3IgUEVJIGNvZGUgd2hlbg0KPiAgICAjICBMb2FkaW5nIE1vZHVsZSBhdCBGaXhl ZCBBZGRyZXNzIGZlYXR1cmUgaXMgZW5hYmxlZC4NCj4gLS0NCj4gMi4zNS4xDQo+IA0KPiANCj4g DQo+IA0KPiANCiANCiANCiANCg0KIA0KIA0KIA0K ------=_001_NextPart348182651881_=---- Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
On 32bit protectd mode, is there any impact if PcdCpuStackGuard is set to TRUE?&= nbsp; Even thers is no page table enabling at that time.
<= br>
Best Regards,
Jeff

fanjianfeng@byosoft.com.cn
 
Fr= om: Chen, Gang C
Date: 2022-04-11 22:51
Subject: Re: [edk2-devel]= [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property
This impact of this change is not as simple as what the= patch does.
-->You're correct, that's why the PATCH 2/2 removed the check in AP= .
 
Why cannot FSP API and Dispatch mode use the same setting? (either ena= bled or disabled)
-->For example, in coreboot, it's 32-bit, so there is no Paging nee= ded. In this case, it needs to disable it for FSP API mode. But this featur= e is needed for Dispatch mode.
 
@Liu, Shuo, if any information is wrong or missed, please correct me. = Thanks.
 
Best Regards
Gang
 
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, April 11, 2022 9:55 PM
To: devel@edk2.groups.io; Chen, Gang C <gang.c.chen@intel.com>
Cc: Jiang, Guomin <guomin.jiang@intel.com>; Bi, Dandan <danda= n.bi@intel.com>; Zhang, Di <di.zhang@intel.com>; Wang, Jian J <= jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the Pcd= CpuStackGuard property
 
FixedAtBuild PCD can be accessed at any time from any CPU.
But dynamic PCD can only be accessed from BSP and after PCD database i= s initialized.
 
This impact of this change is not as simple as what the patch does.
 
Why cannot FSP API and Dispatch mode use the same setting? (either ena= bled or disabled)
 
Thanks,
Ray
 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf= Of Chen,
> Gang C
> Sent: Monday, April 11, 2022 6:14 PM
> To: devel@edk2.groups.io
> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Zhang, Di <di.zhang@intel.com>= ; Wang, Jian J
> <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.= com.cn>
> Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the
> PcdCpuStackGuard property
>
> Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicE= x for
> the requirement to set different value in FSP API mode and FSP
> Dispatch mode.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3897
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: devel@edk2.groups.io
>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 463e889e9a..72e7e2eced 1006= 44
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1070,13 +1070,6 @@
>    # @Prompt The Heap Guard feature mask
>   
> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0|UINT8= |0x30
> 001054
>
> -  ## Indicates if UEFI Stack Guard will be enabled.
> -  #  If enabled, stack overflow in UEFI can be caught,= preventing chaotic consequences.<BR><BR>
> -  #   TRUE  - UEFI Stack Guard will be enabl= ed.<BR>
> -  #   FALSE - UEFI Stack Guard will be disabled.&= lt;BR>
> -  # @Prompt Enable UEFI Stack Guard.
> - 
> gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x3= 00010
> 55
> -
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>    ## Dynamic type PCD can be registered callback = function for Pcd setting action.
>    #  PcdMaxPeiPcdCallBackNumberPerPcdEntry i= ndicates the maximum
> number of callback function @@ -2079,6 +2072,13 @@
>    # @Prompt Enable PCIe Resizable BAR Capability = support.
>   
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|B= OOLEA
> N|0x10000024
>
> +  ## Indicates if UEFI Stack Guard will be enabled.
> +  #  If enabled, stack overflow in UEFI can be caught,= preventing chaotic consequences.<BR><BR>
> +  #   TRUE  - UEFI Stack Guard will be enabl= ed.<BR>
> +  #   FALSE - UEFI Stack Guard will be disabled.&= lt;BR>
> +  # @Prompt Enable UEFI Stack Guard.
> + 
> + gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0= x0001
> + 0025
> +
>  [PcdsPatchableInModule]
>    ## Specify memory size with page number for PEI= code when
>    #  Loading Module at Fixed Address feature= is enabled.
> --
> 2.35.1
>
>
>
>
>
 
 
 
 
 
 
------=_001_NextPart348182651881_=------