public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jeff Fan" <fanjianfeng@byosoft.com.cn>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 gang.c.chen <gang.c.chen@intel.com>
Cc: "Jiang, Guomin" <guomin.jiang@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"Zhang, Di" <di.zhang@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	'gaoliming' <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property
Date: Tue, 12 Apr 2022 14:28:13 +0800	[thread overview]
Message-ID: <2022041214281349737416@byosoft.com.cn> (raw)
In-Reply-To: 20220411101350.697997-2-gang.c.chen@intel.com

[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]

Please correct the commit message which confused me.

It should be "Update the PcdCpuStackGuard to support PcdsPatchableInModule, PcdsDynamci and PcdsDynamciEx ... ..."

Thanks!
Jeff


fanjianfeng@byosoft.com.cn
 
From: Chen, Gang C
Date: 2022-04-11 18:13
To: devel
CC: guomin.jiang; dandan.bi; di.zhang; Jian J Wang; Liming Gao
Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property
Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx
for the requirement to set different value in FSP API mode and FSP
Dispatch mode.
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897
 
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: devel@edk2.groups.io
 
Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
 
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 463e889e9a..72e7e2eced 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1070,13 +1070,6 @@
   # @Prompt The Heap Guard feature mask
   gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0|UINT8|0x30001054
-  ## Indicates if UEFI Stack Guard will be enabled.
-  #  If enabled, stack overflow in UEFI can be caught, preventing chaotic consequences.<BR><BR>
-  #   TRUE  - UEFI Stack Guard will be enabled.<BR>
-  #   FALSE - UEFI Stack Guard will be disabled.<BR>
-  # @Prompt Enable UEFI Stack Guard.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x30001055
-
[PcdsFixedAtBuild, PcdsPatchableInModule]
   ## Dynamic type PCD can be registered callback function for Pcd setting action.
   #  PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum number of callback function
@@ -2079,6 +2072,13 @@
   # @Prompt Enable PCIe Resizable BAR Capability support.
   gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEAN|0x10000024
+  ## Indicates if UEFI Stack Guard will be enabled.
+  #  If enabled, stack overflow in UEFI can be caught, preventing chaotic consequences.<BR><BR>
+  #   TRUE  - UEFI Stack Guard will be enabled.<BR>
+  #   FALSE - UEFI Stack Guard will be disabled.<BR>
+  # @Prompt Enable UEFI Stack Guard.
+  gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x00010025
+
[PcdsPatchableInModule]
   ## Specify memory size with page number for PEI code when
   #  Loading Module at Fixed Address feature is enabled.
-- 
2.35.1
 
 
 

 
 
 

[-- Attachment #2: Type: text/html, Size: 5094 bytes --]

  parent reply	other threads:[~2022-04-12  6:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 10:13 [PATCH 0/2] update the property of PcdCpuStackGuard Chen, Gang C
2022-04-11 10:13 ` [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property Chen, Gang C
2022-04-11 13:55   ` [edk2-devel] " Ni, Ray
2022-04-11 14:51     ` Chen, Gang C
2022-04-12  6:07       ` Jeff Fan
2022-04-12  6:28   ` Jeff Fan [this message]
2022-04-11 10:13 ` [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: remove duplicated pcd check Chen, Gang C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2022041214281349737416@byosoft.com.cn \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox