From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.7712.1649744896541038686 for ; Mon, 11 Apr 2022 23:28:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: fanjianfeng@byosoft.com.cn) Received: from DESKTOP-M5NI163 ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 12 Apr 2022 14:28:12 +0800 X-WM-Sender: fanjianfeng@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: fanjianfeng@byosoft.com.cn Date: Tue, 12 Apr 2022 14:28:13 +0800 From: "Jeff Fan" To: "devel@edk2.groups.io" , gang.c.chen Cc: =?us-ascii?B?SmlhbmcsIEd1b21pbg==?= , =?us-ascii?B?QmksIERhbmRhbg==?= , =?us-ascii?B?WmhhbmcsIERp?= , =?us-ascii?B?V2FuZywgSmlhbiBK?= , 'gaoliming' Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property References: <20220411101350.697997-1-gang.c.chen@intel.com>, <20220411101350.697997-2-gang.c.chen@intel.com> X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.2.20.269[cn] Mime-Version: 1.0 Message-ID: <2022041214281349737416@byosoft.com.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart487627824800_=----" ------=_001_NextPart487627824800_=---- Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: base64 UGxlYXNlIGNvcnJlY3QgdGhlIGNvbW1pdCBtZXNzYWdlIHdoaWNoIGNvbmZ1c2VkIG1lLg0KDQpJ dCBzaG91bGQgYmUgIlVwZGF0ZSB0aGUgUGNkQ3B1U3RhY2tHdWFyZCB0byBzdXBwb3J0IFBjZHNQ YXRjaGFibGVJbk1vZHVsZSwgUGNkc0R5bmFtY2kgYW5kIFBjZHNEeW5hbWNpRXggLi4uIC4uLiIN Cg0KVGhhbmtzIQ0KSmVmZg0KDQoNCmZhbmppYW5mZW5nQGJ5b3NvZnQuY29tLmNuDQogDQpGcm9t OiBDaGVuLCBHYW5nIEMNCkRhdGU6IDIwMjItMDQtMTEgMTg6MTMNClRvOiBkZXZlbA0KQ0M6IGd1 b21pbi5qaWFuZzsgZGFuZGFuLmJpOyBkaS56aGFuZzsgSmlhbiBKIFdhbmc7IExpbWluZyBHYW8N ClN1YmplY3Q6IFtlZGsyLWRldmVsXSBbUEFUQ0ggMS8yXSBNZGVNb2R1bGVQa2cvZGVjOiB1cGRh dGUgdGhlIFBjZENwdVN0YWNrR3VhcmQgcHJvcGVydHkNClVwZGF0ZSB0aGUgUGNkQ3B1U3RhY2tH dWFyZCBmcm9tIFBjZHNGaXhlZEF0QnVpbGQgdG8gUGNkc0R5bmFtaWNFeA0KZm9yIHRoZSByZXF1 aXJlbWVudCB0byBzZXQgZGlmZmVyZW50IHZhbHVlIGluIEZTUCBBUEkgbW9kZSBhbmQgRlNQDQpE aXNwYXRjaCBtb2RlLg0KIA0KUkVGOiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hv d19idWcuY2dpP2lkPTM4OTcNCiANCkNjOiBKaWFuIEogV2FuZyA8amlhbi5qLndhbmdAaW50ZWwu Y29tPg0KQ2M6IExpbWluZyBHYW8gPGdhb2xpbWluZ0BieW9zb2Z0LmNvbS5jbj4NCkNjOiBkZXZl bEBlZGsyLmdyb3Vwcy5pbw0KIA0KU2lnbmVkLW9mZi1ieTogR2FuZyBDaGVuIDxnYW5nLmMuY2hl bkBpbnRlbC5jb20+DQotLS0NCk1kZU1vZHVsZVBrZy9NZGVNb2R1bGVQa2cuZGVjIHwgMTQgKysr KysrKy0tLS0tLS0NCjEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25z KC0pDQogDQpkaWZmIC0tZ2l0IGEvTWRlTW9kdWxlUGtnL01kZU1vZHVsZVBrZy5kZWMgYi9NZGVN b2R1bGVQa2cvTWRlTW9kdWxlUGtnLmRlYw0KaW5kZXggNDYzZTg4OWU5YS4uNzJlN2UyZWNlZCAx MDA2NDQNCi0tLSBhL01kZU1vZHVsZVBrZy9NZGVNb2R1bGVQa2cuZGVjDQorKysgYi9NZGVNb2R1 bGVQa2cvTWRlTW9kdWxlUGtnLmRlYw0KQEAgLTEwNzAsMTMgKzEwNzAsNiBAQA0KICAgIyBAUHJv bXB0IFRoZSBIZWFwIEd1YXJkIGZlYXR1cmUgbWFzaw0KICAgZ0VmaU1kZU1vZHVsZVBrZ1Rva2Vu U3BhY2VHdWlkLlBjZEhlYXBHdWFyZFByb3BlcnR5TWFza3wweDB8VUlOVDh8MHgzMDAwMTA1NA0K LSAgIyMgSW5kaWNhdGVzIGlmIFVFRkkgU3RhY2sgR3VhcmQgd2lsbCBiZSBlbmFibGVkLg0KLSAg IyAgSWYgZW5hYmxlZCwgc3RhY2sgb3ZlcmZsb3cgaW4gVUVGSSBjYW4gYmUgY2F1Z2h0LCBwcmV2 ZW50aW5nIGNoYW90aWMgY29uc2VxdWVuY2VzLjxCUj48QlI+DQotICAjICAgVFJVRSAgLSBVRUZJ IFN0YWNrIEd1YXJkIHdpbGwgYmUgZW5hYmxlZC48QlI+DQotICAjICAgRkFMU0UgLSBVRUZJIFN0 YWNrIEd1YXJkIHdpbGwgYmUgZGlzYWJsZWQuPEJSPg0KLSAgIyBAUHJvbXB0IEVuYWJsZSBVRUZJ IFN0YWNrIEd1YXJkLg0KLSAgZ0VmaU1kZU1vZHVsZVBrZ1Rva2VuU3BhY2VHdWlkLlBjZENwdVN0 YWNrR3VhcmR8RkFMU0V8Qk9PTEVBTnwweDMwMDAxMDU1DQotDQpbUGNkc0ZpeGVkQXRCdWlsZCwg UGNkc1BhdGNoYWJsZUluTW9kdWxlXQ0KICAgIyMgRHluYW1pYyB0eXBlIFBDRCBjYW4gYmUgcmVn aXN0ZXJlZCBjYWxsYmFjayBmdW5jdGlvbiBmb3IgUGNkIHNldHRpbmcgYWN0aW9uLg0KICAgIyAg UGNkTWF4UGVpUGNkQ2FsbEJhY2tOdW1iZXJQZXJQY2RFbnRyeSBpbmRpY2F0ZXMgdGhlIG1heGlt dW0gbnVtYmVyIG9mIGNhbGxiYWNrIGZ1bmN0aW9uDQpAQCAtMjA3OSw2ICsyMDcyLDEzIEBADQog ICAjIEBQcm9tcHQgRW5hYmxlIFBDSWUgUmVzaXphYmxlIEJBUiBDYXBhYmlsaXR5IHN1cHBvcnQu DQogICBnRWZpTWRlTW9kdWxlUGtnVG9rZW5TcGFjZUd1aWQuUGNkUGNpZVJlc2l6YWJsZUJhclN1 cHBvcnR8RkFMU0V8Qk9PTEVBTnwweDEwMDAwMDI0DQorICAjIyBJbmRpY2F0ZXMgaWYgVUVGSSBT dGFjayBHdWFyZCB3aWxsIGJlIGVuYWJsZWQuDQorICAjICBJZiBlbmFibGVkLCBzdGFjayBvdmVy ZmxvdyBpbiBVRUZJIGNhbiBiZSBjYXVnaHQsIHByZXZlbnRpbmcgY2hhb3RpYyBjb25zZXF1ZW5j ZXMuPEJSPjxCUj4NCisgICMgICBUUlVFICAtIFVFRkkgU3RhY2sgR3VhcmQgd2lsbCBiZSBlbmFi bGVkLjxCUj4NCisgICMgICBGQUxTRSAtIFVFRkkgU3RhY2sgR3VhcmQgd2lsbCBiZSBkaXNhYmxl ZC48QlI+DQorICAjIEBQcm9tcHQgRW5hYmxlIFVFRkkgU3RhY2sgR3VhcmQuDQorICBnRWZpTWRl TW9kdWxlUGtnVG9rZW5TcGFjZUd1aWQuUGNkQ3B1U3RhY2tHdWFyZHxGQUxTRXxCT09MRUFOfDB4 MDAwMTAwMjUNCisNCltQY2RzUGF0Y2hhYmxlSW5Nb2R1bGVdDQogICAjIyBTcGVjaWZ5IG1lbW9y eSBzaXplIHdpdGggcGFnZSBudW1iZXIgZm9yIFBFSSBjb2RlIHdoZW4NCiAgICMgIExvYWRpbmcg TW9kdWxlIGF0IEZpeGVkIEFkZHJlc3MgZmVhdHVyZSBpcyBlbmFibGVkLg0KLS0gDQoyLjM1LjEN CiANCiANCiANCg0KIA0KIA0KIA0K ------=_001_NextPart487627824800_=---- Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <= /head>
Please correct the commit message which confused me.

It should be "Update the PcdCpuStackGuard to support&n= bsp;PcdsPatchableInModule,&n= bsp;PcdsDynamci and&n= bsp;PcdsDynamciEx ...= ..."

Thanks!
Jeff
fanjianfeng@byosoft.com.cn
 
Fr= om: Chen, Gang C
Date: 2022-04-11 18:13
To: devel
Subjec= t: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuSta= ckGuard property
Update the PcdCpuStackGuard fro= m PcdsFixedAtBuild to PcdsDynamicEx
for the requirement to set different value in FSP API mode and FSP
Dispatch mode.
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3897
 
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: devel@edk2.groups.io
 
Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
 
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg= .dec
index 463e889e9a..72e7e2eced 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1070,13 +1070,6 @@
   # @Prompt The Heap Guard feature mask
   gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0= x0|UINT8|0x30001054
-  ## Indicates if UEFI Stack Guard will be enabled.
-  #  If enabled, stack overflow in UEFI can be caught, prev= enting chaotic consequences.<BR><BR>
-  #   TRUE  - UEFI Stack Guard will be enabled.&l= t;BR>
-  #   FALSE - UEFI Stack Guard will be disabled.<BR= >
-  # @Prompt Enable UEFI Stack Guard.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|= 0x30001055
-
[PcdsFixedAtBuild, PcdsPatchableInModule]
   ## Dynamic type PCD can be registered callback function f= or Pcd setting action.
   #  PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates t= he maximum number of callback function
@@ -2079,6 +2072,13 @@
   # @Prompt Enable PCIe Resizable BAR Capability support.
   gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport= |FALSE|BOOLEAN|0x10000024
+  ## Indicates if UEFI Stack Guard will be enabled.
+  #  If enabled, stack overflow in UEFI can be caught, prev= enting chaotic consequences.<BR><BR>
+  #   TRUE  - UEFI Stack Guard will be enabled.&l= t;BR>
+  #   FALSE - UEFI Stack Guard will be disabled.<BR= >
+  # @Prompt Enable UEFI Stack Guard.
+  gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|= 0x00010025
+
[PcdsPatchableInModule]
   ## Specify memory size with page number for PEI code when=
   #  Loading Module at Fixed Address feature is enable= d.
--
2.35.1
 
 
 
 
 
 
------=_001_NextPart487627824800_=------