public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h
Date: Tue, 19 Apr 2022 08:48:34 +0200	[thread overview]
Message-ID: <20220419064834.4cq5j7dvukffgkcv@sirius.home.kraxel.org> (raw)
In-Reply-To: <c1f0b5ba21c298a9aa230900f358356e8dd9b60b.1650163941.git.min.m.xu@intel.com>

  Hi,

> As the first step CC_GUEST_TYPE is defined in this patch. In the
> next patch GUEST_TYPE will be deleted. This is to make sure the
> bisect work correctly.

Hmm, what exactly went wrong?  Splitting into two patches looks
pointless.  If the change is too big for an all-in-one patch typical
bisectable splitting would be:

  (1) add CC_GUEST_TYPE
  (2) multiple patches switching code from GUEST_TYPE to CC_GUEST_TYPE
      (for example one patch per Pkg).
  (3) remove GUEST_TYPE

> +//
> +// Confidential computing guest type
> +//
> +typedef enum {
> +  CCGuestTypeNonEncrypted = 0,
> +  CCGuestTypeAmdSev,
> +  CCGuestTypeIntelTdx,
> +} CC_GUEST_TYPE;

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


  parent reply	other threads:[~2022-04-19  6:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17  3:01 [PATCH V3 0/7] Introduce CcProbe in MdePkg Min Xu
2022-04-17  3:01 ` [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h Min Xu
2022-04-18 13:47   ` Lendacky, Thomas
2022-04-18 14:01     ` Min Xu
2022-04-19  6:48   ` Gerd Hoffmann [this message]
2022-04-17  3:01 ` [PATCH V3 2/7] OvmfPkg: Replace GUEST_TYPE with CC_GUEST_TYPE Min Xu
2022-04-17  3:01 ` [PATCH V3 3/7] MdePkg: Add CcProbeLib Min Xu
2022-04-17  3:01 ` [PATCH V3 4/7] OvmfPkg: " Min Xu
2022-04-17  3:01 ` [PATCH V3 5/7] OvmfPkg: Add CcProbeLib in *.dsc Min Xu
2022-04-18 15:01   ` Lendacky, Thomas
2022-04-17  3:01 ` [PATCH V3 6/7] MdePkg: Probe Cc guest in BaseIoLibIntrinsicSev Min Xu
2022-04-17  3:01 ` [PATCH V3 7/7] OvmfPkg: Call CcProbe in SecMain.c instead of TsIsEnabled Min Xu
2022-04-17  3:22 ` [PATCH V3 0/7] Introduce CcProbe in MdePkg Yao, Jiewen
2022-04-17  3:30 ` 回复: " gaoliming
2022-04-18 15:27 ` Lendacky, Thomas
2022-04-18 23:49   ` [edk2-devel] " Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419064834.4cq5j7dvukffgkcv@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox