From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.1377.1650350923736494454
 for <devel@edk2.groups.io>;
 Mon, 18 Apr 2022 23:48:44 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Cu3aVu6L;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1650350922;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BWuer0HVoqnyFydbmQj1t+rVhQD3dpyCgKSg5WZGsOQ=;
	b=Cu3aVu6LdK9J/rTwMGhhGmxun3gv1YU6OpQo7Dtq9V1rWLAXMc3XBZyEXWq10Rq5LOXFqw
	AcRaINFul7ESLLcY9tIe1838NO2Kq1UUNwWTjDcHlCHhSz2US9QeZDdD0QUgODH2NxIGL/
	by44A1awIm7IlV/JL6hb2dM6cM1nkyE=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-605-EYZyOSwZPgiXhe543CrzZw-1; Tue, 19 Apr 2022 02:48:37 -0400
X-MC-Unique: EYZyOSwZPgiXhe543CrzZw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCCB4802809;
	Tue, 19 Apr 2022 06:48:36 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.9])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B05041136E0;
	Tue, 19 Apr 2022 06:48:36 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id B038C18000B2; Tue, 19 Apr 2022 08:48:34 +0200 (CEST)
Date: Tue, 19 Apr 2022 08:48:34 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h
Message-ID: <20220419064834.4cq5j7dvukffgkcv@sirius.home.kraxel.org>
References: <cover.1650163941.git.min.m.xu@intel.com>
 <c1f0b5ba21c298a9aa230900f358356e8dd9b60b.1650163941.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <c1f0b5ba21c298a9aa230900f358356e8dd9b60b.1650163941.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> As the first step CC_GUEST_TYPE is defined in this patch. In the
> next patch GUEST_TYPE will be deleted. This is to make sure the
> bisect work correctly.

Hmm, what exactly went wrong?  Splitting into two patches looks
pointless.  If the change is too big for an all-in-one patch typical
bisectable splitting would be:

  (1) add CC_GUEST_TYPE
  (2) multiple patches switching code from GUEST_TYPE to CC_GUEST_TYPE
      (for example one patch per Pkg).
  (3) remove GUEST_TYPE

> +//
> +// Confidential computing guest type
> +//
> +typedef enum {
> +  CCGuestTypeNonEncrypted = 0,
> +  CCGuestTypeAmdSev,
> +  CCGuestTypeIntelTdx,
> +} CC_GUEST_TYPE;

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd