* [PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: add modes
2022-04-22 12:41 [PATCH v2 0/3] add and use more video modes Gerd Hoffmann
@ 2022-04-22 12:41 ` Gerd Hoffmann
2022-04-22 12:41 ` [PATCH v2 2/3] OvmfPkg: clear PcdConOut{Row,Column} Gerd Hoffmann
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2022-04-22 12:41 UTC (permalink / raw)
To: devel
Cc: Pawel Polawski, Oliver Steffen, Ray Ni, Gerd Hoffmann,
Jordan Justen, Brijesh Singh, Jian J Wang, Min Xu,
James Bottomley, Erdem Aktas, Julien Grall, Zhichao Gao,
Ard Biesheuvel, Liming Gao, Sami Mujawar, Anthony Perard,
Leif Lindholm, Jiewen Yao, Tom Lendacky
Add modes for a few common display resolutions higher than 800x600,
specifically 1024x768, 1280x800 and 1920x1080, so ConSplitterDxe has
more options available.
The mode list is not use as-is, InitializeGraphicsConsoleTextMode() will
check the list and filter out any modes which don't fit to the screen,
so this will also work fine for small displays.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
.../Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
index 07436cbd15bf..b895dafedeaa 100644
--- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
+++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
@@ -40,7 +40,10 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate = {
};
GRAPHICS_CONSOLE_MODE_DATA mGraphicsConsoleModeData[] = {
- { 100, 31 },
+ { 100, 31 }, // 800 x 600
+ { 128, 40 }, // 1024 x 768
+ { 160, 42 }, // 1280 x 800
+ { 240, 56 }, // 1920 x 1080
//
// New modes can be added here.
// The last entry is specific for full screen mode.
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/3] OvmfPkg: clear PcdConOut{Row,Column}
2022-04-22 12:41 [PATCH v2 0/3] add and use more video modes Gerd Hoffmann
2022-04-22 12:41 ` [PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: add modes Gerd Hoffmann
@ 2022-04-22 12:41 ` Gerd Hoffmann
2022-04-22 12:41 ` [PATCH v2 3/3] ArmVirtPkg: " Gerd Hoffmann
2022-04-22 13:29 ` [PATCH v2 0/3] add and use more video modes Ard Biesheuvel
3 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2022-04-22 12:41 UTC (permalink / raw)
To: devel
Cc: Pawel Polawski, Oliver Steffen, Ray Ni, Gerd Hoffmann,
Jordan Justen, Brijesh Singh, Jian J Wang, Min Xu,
James Bottomley, Erdem Aktas, Julien Grall, Zhichao Gao,
Ard Biesheuvel, Liming Gao, Sami Mujawar, Anthony Perard,
Leif Lindholm, Jiewen Yao, Tom Lendacky
ConSplitterDxe will pick the highest available resolution then,
thereby making better use of the available display space.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 2 ++
OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++
OvmfPkg/OvmfPkgIa32.dsc | 2 ++
OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++
OvmfPkg/OvmfPkgX64.dsc | 2 ++
OvmfPkg/OvmfXen.dsc | 2 ++
6 files changed, 12 insertions(+)
diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
index 1c088f25fa4b..f0700035c116 100644
--- a/OvmfPkg/AmdSev/AmdSevX64.dsc
+++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
@@ -530,6 +530,8 @@ [PcdsDynamicDefault]
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
index c9c843e116a9..20c3c9c4d862 100644
--- a/OvmfPkg/Microvm/MicrovmX64.dsc
+++ b/OvmfPkg/Microvm/MicrovmX64.dsc
@@ -563,6 +563,8 @@ [PcdsDynamicDefault]
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 9e4ecd21fb17..f02b371f7427 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -593,6 +593,8 @@ [PcdsDynamicDefault]
!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 75fb8095eec2..cb68e612bd35 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -601,6 +601,8 @@ [PcdsDynamicDefault]
!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 2e534d0d2478..45ffa2dbe35f 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -612,6 +612,8 @@ [PcdsDynamicDefault]
!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 8d420cf54371..a1626d06dfc3 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -470,6 +470,8 @@ [PcdsDynamicDefault]
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1280
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 3/3] ArmVirtPkg: clear PcdConOut{Row,Column}
2022-04-22 12:41 [PATCH v2 0/3] add and use more video modes Gerd Hoffmann
2022-04-22 12:41 ` [PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: add modes Gerd Hoffmann
2022-04-22 12:41 ` [PATCH v2 2/3] OvmfPkg: clear PcdConOut{Row,Column} Gerd Hoffmann
@ 2022-04-22 12:41 ` Gerd Hoffmann
2022-04-22 13:29 ` [PATCH v2 0/3] add and use more video modes Ard Biesheuvel
3 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2022-04-22 12:41 UTC (permalink / raw)
To: devel
Cc: Pawel Polawski, Oliver Steffen, Ray Ni, Gerd Hoffmann,
Jordan Justen, Brijesh Singh, Jian J Wang, Min Xu,
James Bottomley, Erdem Aktas, Julien Grall, Zhichao Gao,
Ard Biesheuvel, Liming Gao, Sami Mujawar, Anthony Perard,
Leif Lindholm, Jiewen Yao, Tom Lendacky
ConSplitterDxe will pick the highest available resolution then,
thereby making better use of the available display space.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
ArmVirtPkg/ArmVirtQemu.dsc | 2 ++
ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 ++
2 files changed, 4 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index b2b0d304d335..aa0ce61630f7 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -259,6 +259,8 @@ [PcdsDynamicDefault.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
#
# SMBIOS entry point version
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index 36343f347bab..7f7d15d6eee3 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -238,6 +238,8 @@ [PcdsDynamicDefault.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|800
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0
#
# SMBIOS entry point version
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 0/3] add and use more video modes
2022-04-22 12:41 [PATCH v2 0/3] add and use more video modes Gerd Hoffmann
` (2 preceding siblings ...)
2022-04-22 12:41 ` [PATCH v2 3/3] ArmVirtPkg: " Gerd Hoffmann
@ 2022-04-22 13:29 ` Ard Biesheuvel
2022-04-23 6:52 ` Ard Biesheuvel
3 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2022-04-22 13:29 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: edk2-devel-groups-io, Pawel Polawski, Oliver Steffen, Ray Ni,
Jordan Justen, Brijesh Singh, Jian J Wang, Min Xu,
James Bottomley, Erdem Aktas, Julien Grall, Zhichao Gao,
Ard Biesheuvel, Liming Gao, Sami Mujawar, Anthony Perard,
Leif Lindholm, Jiewen Yao, Tom Lendacky
On Fri, 22 Apr 2022 at 14:41, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> v2:
> - rebase to latest master
> - add review tags
>
Thanks Gerd, I'll pick these up later today.
> Gerd Hoffmann (3):
> MdeModulePkg/GraphicsConsoleDxe: add modes
> OvmfPkg: clear PcdConOut{Row,Column}
> ArmVirtPkg: clear PcdConOut{Row,Column}
>
> ArmVirtPkg/ArmVirtQemu.dsc | 2 ++
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 ++
> OvmfPkg/AmdSev/AmdSevX64.dsc | 2 ++
> OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++
> OvmfPkg/OvmfPkgIa32.dsc | 2 ++
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++
> OvmfPkg/OvmfPkgX64.dsc | 2 ++
> OvmfPkg/OvmfXen.dsc | 2 ++
> .../Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 5 ++++-
> 9 files changed, 20 insertions(+), 1 deletion(-)
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 0/3] add and use more video modes
2022-04-22 13:29 ` [PATCH v2 0/3] add and use more video modes Ard Biesheuvel
@ 2022-04-23 6:52 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2022-04-23 6:52 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: edk2-devel-groups-io, Pawel Polawski, Oliver Steffen, Ray Ni,
Jordan Justen, Brijesh Singh, Jian J Wang, Min Xu,
James Bottomley, Erdem Aktas, Julien Grall, Zhichao Gao,
Ard Biesheuvel, Liming Gao, Sami Mujawar, Anthony Perard,
Leif Lindholm, Jiewen Yao, Tom Lendacky
On Fri, 22 Apr 2022 at 15:29, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Fri, 22 Apr 2022 at 14:41, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > v2:
> > - rebase to latest master
> > - add review tags
> >
>
> Thanks Gerd, I'll pick these up later today.
>
Merged as #2819
Thanks all,
>
> > Gerd Hoffmann (3):
> > MdeModulePkg/GraphicsConsoleDxe: add modes
> > OvmfPkg: clear PcdConOut{Row,Column}
> > ArmVirtPkg: clear PcdConOut{Row,Column}
> >
> > ArmVirtPkg/ArmVirtQemu.dsc | 2 ++
> > ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 ++
> > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 ++
> > OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++
> > OvmfPkg/OvmfPkgIa32.dsc | 2 ++
> > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++
> > OvmfPkg/OvmfPkgX64.dsc | 2 ++
> > OvmfPkg/OvmfXen.dsc | 2 ++
> > .../Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 5 ++++-
> > 9 files changed, 20 insertions(+), 1 deletion(-)
> >
> > --
> > 2.35.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread