public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Edward Pickup" <edward.pickup@arm.com>
To: <devel@edk2.groups.io>
Cc: <sami.mujawar@arm.com>, <ardb+tianocore@kernel.org>,
	<thomas.abraham@arm.com>, <nd@arm.com>
Subject: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC
Date: Wed, 27 Apr 2022 09:59:35 +0100	[thread overview]
Message-ID: <20220427085935.17236-1-edward.pickup@arm.com> (raw)

When booting Linux on FVP RevC, Linux reports the following error:

ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit

This issue is due to the RC Address Limit not being configured in the
configuration manager for the platform.

The default model parameter is configured to 32, so set this in the
configuration manager, fixing the error.

Signed-off-by: Edward Pickup <edward.pickup@arm.com>
---

The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6deab2eb82fced9e2 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     // ATS attributes
     EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED,
     // PCI segment number
-    0
+    0,
+    // Memory Address Size Limit
+    32
   },

   // Array of Device ID mappings
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

             reply	other threads:[~2022-04-27  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  8:59 Edward Pickup [this message]
2022-04-27 11:36 ` [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC Ard Biesheuvel
2022-04-28  8:24   ` Edward Pickup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427085935.17236-1-edward.pickup@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox