From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7265.1651215056409501722 for ; Thu, 28 Apr 2022 23:50:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qe87TiRP; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651215055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A8ohVdZDsIZXkK/+dmAPQi8qU3EZDObRVgr/wVJ2aOE=; b=Qe87TiRP46TQPAku1kXp294+7EE2X1bziztKYUAiwx5PjNvcTPysRunULizWg8R0mi0/YT VeZcKbB1/O7n5mgqzDJXrU/vpCQGILTr/OX7Fmzn9uxKY0KpFmMVdvfg/iv0tQ9K/mKxHF 4ki3e3kiWWLrBGldnkQCAtQXn8U6wXg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-DjmuIZ3EP0KC1Q0jPxOVqQ-1; Fri, 29 Apr 2022 02:50:52 -0400 X-MC-Unique: DjmuIZ3EP0KC1Q0jPxOVqQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD6528E8CC7; Fri, 29 Apr 2022 06:50:51 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2ADCC111C482; Fri, 29 Apr 2022 06:50:50 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0C20F18003A5; Fri, 29 Apr 2022 08:50:48 +0200 (CEST) Date: Fri, 29 Apr 2022 08:50:47 +0200 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "ardb@kernel.org" , Pawel Polawski , Ard Biesheuvel , "Gao, Liming" , "Wu, Hao A" , Oliver Steffen , Leif Lindholm , "Justen, Jordan L" , "Yao, Jiewen" , "Chang, Abner" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Message-ID: <20220429065047.7ed7xvawzmfdja2h@sirius.home.kraxel.org> References: <20220422073713.2087781-1-kraxel@redhat.com> <20220422073713.2087781-2-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2022 at 03:08:50AM +0000, Ni, Ray wrote: > Ard, > can you explain more? > > Your code changes the PciHostBridge driver to ignore the failure of IO allocation. > If IO requirement of certain PCI(E) devices can be ignored, can you change the IncompatiblePciDevice protocol implementation to override the IO request from the devices? Hmm, it's a problem indeed, device initialization fails in case an io bar is present even if the bar is not required to drive the device. Suggestions how to deal with this best? ovmf has it's own IncompatiblePciDevice Protocol implementation, so I could handle it there because only OvmfPkg/Microvm needs this. Or should the MdeModulePkg version be updated too? thanks, Gerd