[PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

[PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

[Rebecca Cran]

The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
the console difficult, for example when using the UiApp.

To allow for easy inclusion for future debugging, comment out but don't
remove the DEBUG lines.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 ...utBlt.c | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
index 01ec6f68bd93..4766d72cef28 100644
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
@@ -815,17 +815,17 @@ LcdGraphicsBlt (
   HorizontalResolution = This->Mode->Info->HorizontalResolution;
   VerticalResolution   = This->Mode->Info->VerticalResolution;
 
-  DEBUG ((
-    DEBUG_INFO,
-    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
-    BltOperation,
-    DestinationX,
-    DestinationY,
-    Width,
-    Height,
-    HorizontalResolution,
-    VerticalResolution
-    ));
+//  DEBUG ((
+//    DEBUG_INFO,
+//    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
+//    BltOperation,
+//    DestinationX,
+//    DestinationY,
+//    Width,
+//    Height,
+//    HorizontalResolution,
+//    VerticalResolution
+//    ));
 
   // Check we have reasonable parameters
   if ((Width == 0) || (Height == 0)) {
-- 
2.25.1

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

[Ard Biesheuvel]

Hi Rebecca,

On Tue, 3 May 2022 at 21:31, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
> the console difficult, for example when using the UiApp.
>
> To allow for easy inclusion for future debugging, comment out but don't
> remove the DEBUG lines.
>

I'd suggest to either demote the debug level to DEBUG_VERBOSE, or
simply remove them, instead of using comments like this.

> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  ...utBlt.c | 22 +++---
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> index 01ec6f68bd93..4766d72cef28 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> @@ -815,17 +815,17 @@ LcdGraphicsBlt (
>    HorizontalResolution = This->Mode->Info->HorizontalResolution;
>    VerticalResolution   = This->Mode->Info->VerticalResolution;
>
> -  DEBUG ((
> -    DEBUG_INFO,
> -    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
> -    BltOperation,
> -    DestinationX,
> -    DestinationY,
> -    Width,
> -    Height,
> -    HorizontalResolution,
> -    VerticalResolution
> -    ));
> +//  DEBUG ((
> +//    DEBUG_INFO,
> +//    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
> +//    BltOperation,
> +//    DestinationX,
> +//    DestinationY,
> +//    Width,
> +//    Height,
> +//    HorizontalResolution,
> +//    VerticalResolution
> +//    ));
>
>    // Check we have reasonable parameters
>    if ((Width == 0) || (Height == 0)) {
> --
> 2.25.1
>
>
>
> 
>
>

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

[Rebecca Cran]

I think with the PL111 being such old technology now it should be safe 
to just remove them.


-- 
Rebecca Cran


On 5/3/22 13:43, Ard Biesheuvel wrote:
> Hi Rebecca,
>
> On Tue, 3 May 2022 at 21:31, Rebecca Cran <rebecca@bsdio.com> wrote:
>> The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
>> the console difficult, for example when using the UiApp.
>>
>> To allow for easy inclusion for future debugging, comment out but don't
>> remove the DEBUG lines.
>>
> I'd suggest to either demote the debug level to DEBUG_VERBOSE, or
> simply remove them, instead of using comments like this.
>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>>   ...utBlt.c | 22 +++---
>>   1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
>> index 01ec6f68bd93..4766d72cef28 100644
>> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
>> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
>> @@ -815,17 +815,17 @@ LcdGraphicsBlt (
>>     HorizontalResolution = This->Mode->Info->HorizontalResolution;
>>     VerticalResolution   = This->Mode->Info->VerticalResolution;
>>
>> -  DEBUG ((
>> -    DEBUG_INFO,
>> -    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
>> -    BltOperation,
>> -    DestinationX,
>> -    DestinationY,
>> -    Width,
>> -    Height,
>> -    HorizontalResolution,
>> -    VerticalResolution
>> -    ));
>> +//  DEBUG ((
>> +//    DEBUG_INFO,
>> +//    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
>> +//    BltOperation,
>> +//    DestinationX,
>> +//    DestinationY,
>> +//    Width,
>> +//    Height,
>> +//    HorizontalResolution,
>> +//    VerticalResolution
>> +//    ));
>>
>>     // Check we have reasonable parameters
>>     if ((Width == 0) || (Height == 0)) {
>> --
>> 2.25.1
>>
>>
>>
>> 
>>
>>