From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by mx.groups.io with SMTP id smtpd.web12.8821.1651742144671885830 for ; Thu, 05 May 2022 02:15:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JgXY29Q0; spf=pass (domain: redhat.com, ip: 170.10.133.74, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651742143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/e9NxdGZT0VAifFfi1/ipStpBafpxAu+j3yp4l4ExPM=; b=JgXY29Q0oQdmtZ/xh0fqQeYnOIiLb9ixx1/b4WLgOJnGSxqtx/x5910weddA/wWB7DlpJ4 jaZRnkSBxGRP+Msle0nm3UB31+O8nYdS8KFOVh9xR8gNVxui9ZEz7D0l4MN6e+LnPtafxY R/PQikEL4a9nvWmSNe4f52Y0FWnciOY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-ihOxkBiGMxONrsUxJG_hIg-1; Thu, 05 May 2022 05:15:39 -0400 X-MC-Unique: ihOxkBiGMxONrsUxJG_hIg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C45610AF940; Thu, 5 May 2022 09:15:38 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D0D7C27E80; Thu, 5 May 2022 09:15:38 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C954E18000A9; Thu, 5 May 2022 11:15:36 +0200 (CEST) Date: Thu, 5 May 2022 11:15:36 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: "Yao, Jiewen" , Pawel Polawski , "Li, Yi1" , Oliver Steffen , "Wang, Jian J" , Ard Biesheuvel , "Jiang, Guomin" , "Lu, Xiaoyu1" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally. Message-ID: <20220505091536.llguh4dzozqtiiob@sirius.home.kraxel.org> References: <20220502103436.3274412-1-kraxel@redhat.com> <20220505080638.rmrw3f773rkw3ljl@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20220505080638.rmrw3f773rkw3ljl@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > > I am not convinced that "EC is hard requirement for EDKII" just because "EC is a hard requirement for TLS 1.3". My reason below: > > A) TLS1.3 is only for DXE, but enabling ECC unconditionally may impact PEI/DXE. (Unless size of PEI/SMM is unchanged). > > Well, the PcdEcEnabled switch we have in the tree right now enables or > disables EC for everybody, it doesn't support enabling EC for DXE only. > > In we want change that we'll need two different *.inf files I guess, > one for openssl with ec and one for openssl without ec. > > I'll check the effect on image sizes. Here we go: --- master.stats 2022-05-05 10:05:03.791368600 +0200 +++ openssl-ec.stats 2022-05-05 10:35:44.429412053 +0200 @@ -137,8 +137,8 @@ 124410 BdsDxe 145534 DxeCore 148078 UiApp - 400158 SecureBootConfigDxe - 472950 SecurityStubDxe - 532626 VariableSmm - 658174 TlsDxe + 575390 SecureBootConfigDxe + 643062 SecurityStubDxe + 700562 VariableSmm + 847422 TlsDxe 946646 Shell So no effect on PEI size but SMM is affected. take care, Gerd