From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by mx.groups.io with SMTP id smtpd.web08.9160.1651746211121217180 for ; Thu, 05 May 2022 03:23:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e81qn6mT; spf=pass (domain: redhat.com, ip: 170.10.133.74, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651746209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QVt0XmJa9tqZnyXEA2Owc+q4A2jKCZO70rWZyPlbo8o=; b=e81qn6mT8wS2wtF2sDFyBlff+4xzrbkO2JKHqQXXNMHpx178cORFT9OjD1XES/S59gkk6H RjuNXvY0+xOof4wE29+L7Q8UnUQXhJLip1oJlCZa8rcYdBfX+GL4KuBmsUrRnoSNCxjL0P m0/9mRqaOC6KtJREZJufftGQKLXFDZ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-Cwv6OtIPPQe8XhXR3dhjlw-1; Thu, 05 May 2022 06:23:26 -0400 X-MC-Unique: Cwv6OtIPPQe8XhXR3dhjlw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B52B9185A7BA; Thu, 5 May 2022 10:23:24 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CADFC7B64; Thu, 5 May 2022 10:23:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B9B7218000A9; Thu, 5 May 2022 12:23:18 +0200 (CEST) Date: Thu, 5 May 2022 12:23:18 +0200 From: "Gerd Hoffmann" To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Maciej Rabeda , Abner Chang , Peter Grehan , Yuwei Chen , Jiaxin Wu , Siyuan Fu , Sean Brogan , Anthony Perard , Benjamin You , Guomin Jiang , Rebecca Cran , Wei6 Xu , Nickle Wang , Xiaoyu Lu , Zhichao Gao , kilian_kegel@hotmail.com, Liming Gao , Jordan Justen , Sami Mujawar , Andrew Fish , Oliver Steffen , Alexei Fedorov , Guo Dong , Brijesh Singh , Jian J Wang , Supreeth Venkatesh , Min Xu , Bret Barkelew , Maurice Ma , Pawel Polawski , Daniel Schaefer , Bob Feng , James Bottomley , Jiewen Yao , Ray Ni , Julien Grall , Michael D Kinney , Sebastien Boeuf , Zhiguang Liu , Tom Lendacky Subject: Re: [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo Message-ID: <20220505102318.5jivneoxmtjr53hn@sirius.home.kraxel.org> References: <20220429102019.1375348-1-kraxel@redhat.com> <20220429102019.1375348-6-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote: > Apologies for late feedback. > > I'm super happy with this set, but... > > On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote: > > Copy over unmodified (except for running through uncrustify), from > > https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT > > ...I think these files should also be given the SPDX treatment, and > while doing that have the explicit patent grant added by changing them > from BSD2 to BSD+Patent. See patch #6 ;) (comments on the process are welcome too, not sure I can just change the licence without intel explicitly acking this ...). take care, Gerd