From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.6583.1651895956803299023 for ; Fri, 06 May 2022 20:59:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=L/Fb23U1; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651895956; x=1683431956; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OqAg3QP/rZU48JU+ocvDXyO7Fak0Jm/EDlz0cwM1mwY=; b=L/Fb23U1yH6aCBwUk1wBbHwURQgkkJgmPba2ocXUwYoKzGwOW2LkxRjI qWsuW/hcubdSF9ts/pqTOc1oBAH1C7TQ4zeVCsoSXuOArcj4pHjay1m7d 1Zyf4dc/zynXLODiG4FR2XYoMhyfI64ac3haGDn47rKgSUfeSfZYIV3in zLD+QGX0unQN5ngDSzcdSeyK90t1Di6gaFee2gi8KeQeTgqnjRF1ymDp9 4VSscy5KViAf7qshkxC8JTl8d4yCzs2/+gsovrD9WUZhcn+SZarPI8zBg 9rrJj46diZKIQARbJ8S44kmsoB95ithvTTkIRpPto7TuFSlPWIuubAx+b g==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="268540139" X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="268540139" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 20:59:15 -0700 X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="586342567" Received: from duntan-mobl.ccr.corp.intel.com ([10.249.174.233]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 20:59:14 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Guo Dong , Benjamin You , Sean Rhodes Subject: [Patch V2] UefiPayloadPkg: Fix the UPL build failure Date: Sat, 7 May 2022 11:57:32 +0800 Message-Id: <20220507035732.605-1-dun.tan@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add double quotes to LlvmObjcopyPath. Blank space in LlvmObjcopyPath will cause build failure. This build failure is introduced by 2306555bf908 ( "UefiPayloadPkg: Fix IA32 entry build failure"). Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes --- UefiPayloadPkg/UniversalPayloadBuild.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py index 8af381336d..50335d4316 100644 --- a/UefiPayloadPkg/UniversalPayloadBuild.py +++ b/UefiPayloadPkg/UniversalPayloadBuild.py @@ -111,9 +111,9 @@ def BuildUniversalPayload(Args, MacroList): # # Copy the DXEFV as a section in elf format Universal Payload entry. # - remove_section = f"{LlvmObjcopyPath} -I {ObjCopyFlag} -O {ObjCopyFlag} --remove-section .upld_info --remove-section .upld.uefi_fv {EntryOutputDir}" - add_section = f"{LlvmObjcopyPath} -I {ObjCopyFlag} -O {ObjCopyFlag} --add-section .upld_info={UpldInfoFile} --add-section .upld.uefi_fv={FvOutputDir} {EntryOutputDir}" - set_section = f"{LlvmObjcopyPath} -I {ObjCopyFlag} -O {ObjCopyFlag} --set-section-alignment .upld.upld_info=16 --set-section-alignment .upld.uefi_fv=16 {EntryOutputDir}" + remove_section = f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjCopyFlag} --remove-section .upld_info --remove-section .upld.uefi_fv {EntryOutputDir}' + add_section = f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjCopyFlag} --add-section .upld_info={UpldInfoFile} --add-section .upld.uefi_fv={FvOutputDir} {EntryOutputDir}' + set_section = f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjCopyFlag} --set-section-alignment .upld.upld_info=16 --set-section-alignment .upld.uefi_fv=16 {EntryOutputDir}' RunCommand(remove_section) RunCommand(add_section) RunCommand(set_section) -- 2.31.1.windows.1