From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web08.29756.1652088849021784817
 for <devel@edk2.groups.io>;
 Mon, 09 May 2022 02:34:09 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fUi2jJ7y;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1652088848;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Se+sSfnQE5j7o+MoBN72UG3rHi8K8gVLh0jmL0FC9Q8=;
	b=fUi2jJ7y68MRs8R1JIrKwmbNNSpABkGWA37nmYrnNYyOd7UrMkK2kWhMQzegLWdDI83+sf
	8Eke4720rvncpKQhNkGFUMVQa64qGFKezoHUMcqIUAS57E9cyFpihEjCGqNVywZDajMIxe
	SFVq4Fh6eerjx7yg5Tu+jcnN/SJBXsE=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-570-mW-lby8qPLODc3pUgHpS2Q-1; Mon, 09 May 2022 05:34:05 -0400
X-MC-Unique: mW-lby8qPLODc3pUgHpS2Q-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83C113C02190;
	Mon,  9 May 2022 09:34:04 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.13])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CE712166B49;
	Mon,  9 May 2022 09:34:04 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2CD9C180062C; Mon,  9 May 2022 11:34:02 +0200 (CEST)
Date: Mon, 9 May 2022 11:34:02 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Yi Li <yi1.li@intel.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Xiaoyu Lu <xiaoyu1.lu@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>
Subject: Re: [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option
Message-ID: <20220509093402.uxt5s3bmzvtcg7zb@sirius.home.kraxel.org>
References: <cover.1652066029.git.yi1.li@intel.com>
 <ea90c043834bf117236dcdd221a3b889d62d06a8.1652066029.git.yi1.li@intel.com>
MIME-Version: 1.0
In-Reply-To: <ea90c043834bf117236dcdd221a3b889d62d06a8.1652066029.git.yi1.li@intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +#
> +# Add conditional feature to opensslconf.h
> +#

I'd suggest to write the opensslconf.h created by openssl unmodified to
opensslconf-generated.h, then have a opensslconf.h like this:

#include <Library/PcdLib.h>
#include "opensslconf-generated.h"
#if !FixedPcdGetBool(PcdEcEnable)
# define OPENSSL_NO_EC
# [ ... ]
#endif

take care,
  Gerd