From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Li, Yi1" <yi1.li@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [PATCH 3/3] CryptoPkg/openssl: update generated files
Date: Mon, 9 May 2022 11:38:23 +0200 [thread overview]
Message-ID: <20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org> (raw)
In-Reply-To: <MW4PR11MB5872A30583D6422F02D37DC98CC69@MW4PR11MB5872.namprd11.prod.outlook.com>
On Mon, May 09, 2022 at 03:25:24AM +0000, Yao, Jiewen wrote:
> Thanks for the update.
>
> think some changes are unnecessary.
>
> > -#define OSSL_CRYPTO_DSO_CONF_H
> > -#define DSO_NONE
> > -#define DSO_EXTENSION ".so"
> > +# define OSSL_CRYPTO_DSO_CONF_H
> > +# define DSO_NONE
> > +# define DSO_EXTENSION ".so"
>
> Why you add a space ' ' ?
>
> Can we make it unchanged?
Not sure where this comes from, either it's a upstream openssl change,
or it comes from running the generated files though uncrustify once last
year when uncrustify was introduced.
take care,
Gerd
next prev parent reply other threads:[~2022-05-09 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1652066029.git.yi1.li@intel.com>
2022-05-09 3:19 ` [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 9:34 ` Gerd Hoffmann
2022-05-09 9:58 ` [edk2-devel] " yi1 li
2022-05-09 3:19 ` [PATCH 2/3] CryptoPkg/openssl: disable codestyle checks for generated files yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 3:19 ` [PATCH 3/3] CryptoPkg/openssl: update " yi1 li
2022-05-09 3:25 ` Yao, Jiewen
2022-05-09 3:34 ` yi1 li
2022-05-09 9:38 ` Gerd Hoffmann [this message]
2022-05-09 10:05 ` [edk2-devel] " yi1 li
2022-05-09 10:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox