From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.29779.1652089108130366205 for ; Mon, 09 May 2022 02:38:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IWDIqHUF; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652089107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RMXvUIjv7RPHwDfoTexAQOcOVce8VuKfBD8x6jr0nGo=; b=IWDIqHUFZphQJdaSuQfl/VWwBnDRJC0HFzBgU3fvyYZ/HwrnCvU69DOKCMtwyus0PsF7Ki lQnYminBNi54/4NN6U94Y889Ujkytxr2Uax8AvHF9C/8vnx135xKlZUvXVYQ5r26QN5fTy 0hAi4yS363+W6LerVts8BEirkjbOwIs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-272-Uje9vUNxOhmKLjpj8eUglg-1; Mon, 09 May 2022 05:38:26 -0400 X-MC-Unique: Uje9vUNxOhmKLjpj8eUglg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84E25185A7A4; Mon, 9 May 2022 09:38:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BD5E7ADD; Mon, 9 May 2022 09:38:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 545C0180062C; Mon, 9 May 2022 11:38:23 +0200 (CEST) Date: Mon, 9 May 2022 11:38:23 +0200 From: "Gerd Hoffmann" To: "Yao, Jiewen" Cc: "Li, Yi1" , "devel@edk2.groups.io" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH 3/3] CryptoPkg/openssl: update generated files Message-ID: <20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org> References: <234d9edcf3f78cc3046e43241a76c4faf2592ea9.1652066029.git.yi1.li@intel.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 09, 2022 at 03:25:24AM +0000, Yao, Jiewen wrote: > Thanks for the update. > > think some changes are unnecessary. > > > -#define OSSL_CRYPTO_DSO_CONF_H > > -#define DSO_NONE > > -#define DSO_EXTENSION ".so" > > +# define OSSL_CRYPTO_DSO_CONF_H > > +# define DSO_NONE > > +# define DSO_EXTENSION ".so" > > Why you add a space ' ' ? > > Can we make it unchanged? Not sure where this comes from, either it's a upstream openssl change, or it comes from running the generated files though uncrustify once last year when uncrustify was introduced. take care, Gerd