From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Li, Yi1" <yi1.li@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files
Date: Mon, 9 May 2022 12:26:32 +0200 [thread overview]
Message-ID: <20220509102632.go2xmofuwao5xmak@sirius.home.kraxel.org> (raw)
In-Reply-To: <BL0PR11MB33967C08C070B60263A1C1CCC5C69@BL0PR11MB3396.namprd11.prod.outlook.com>
On Mon, May 09, 2022 at 10:05:21AM +0000, Li, Yi1 wrote:
> Yes it does come from running the generated files though uncrustify once last year when uncrustify was introduced:
> https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21aec8cb7a
Thanks for checking.
> I can remove those change next patch to avoid confusion.
That wasn't a request to remove those changes, just an attempt to
explain where they are coming from.
The generated files should be commited without changes (so re-running
process_files.pl does not change your checkout).
take care,
Gerd
prev parent reply other threads:[~2022-05-09 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1652066029.git.yi1.li@intel.com>
2022-05-09 3:19 ` [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 9:34 ` Gerd Hoffmann
2022-05-09 9:58 ` [edk2-devel] " yi1 li
2022-05-09 3:19 ` [PATCH 2/3] CryptoPkg/openssl: disable codestyle checks for generated files yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 3:19 ` [PATCH 3/3] CryptoPkg/openssl: update " yi1 li
2022-05-09 3:25 ` Yao, Jiewen
2022-05-09 3:34 ` yi1 li
2022-05-09 9:38 ` Gerd Hoffmann
2022-05-09 10:05 ` [edk2-devel] " yi1 li
2022-05-09 10:26 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509102632.go2xmofuwao5xmak@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox