From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.30139.1652092416088577543 for ; Mon, 09 May 2022 03:33:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JT/phF23; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652092415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K/DANv8iTZ24ug//24BIYF7qILQ4Rty3BAIXLy/nccY=; b=JT/phF23X84KpSLZx9WNj4KY5SivhlA4+S+cODN44x+EL3t15G+1S9YEoI3TDLj26/5BqJ 9ZubRr6zdsYFFybfy7XX9rXRiBxAAeDV43s0ROOS4xIdO9Se+GBAORkiRKXLQLmJSy3sWs AWPFwFSrTTMn5t1iP1qFj/Wv519Mxzs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-100-f_fT9nzlMMuo_ifPsDYs6A-1; Mon, 09 May 2022 06:33:34 -0400 X-MC-Unique: f_fT9nzlMMuo_ifPsDYs6A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A25E3805B25; Mon, 9 May 2022 10:33:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 673CC111E3F8; Mon, 9 May 2022 10:33:33 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B8BA3180062C; Mon, 9 May 2022 12:26:32 +0200 (CEST) Date: Mon, 9 May 2022 12:26:32 +0200 From: "Gerd Hoffmann" To: "Li, Yi1" Cc: "devel@edk2.groups.io" , "Yao, Jiewen" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files Message-ID: <20220509102632.go2xmofuwao5xmak@sirius.home.kraxel.org> References: <234d9edcf3f78cc3046e43241a76c4faf2592ea9.1652066029.git.yi1.li@intel.com> <20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 09, 2022 at 10:05:21AM +0000, Li, Yi1 wrote: > Yes it does come from running the generated files though uncrustify once last year when uncrustify was introduced: > https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21aec8cb7a Thanks for checking. > I can remove those change next patch to avoid confusion. That wasn't a request to remove those changes, just an attempt to explain where they are coming from. The generated files should be commited without changes (so re-running process_files.pl does not change your checkout). take care, Gerd