Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

["Gerd Hoffmann" <kraxel@redhat.com>]

On Mon, May 09, 2022 at 12:44:58PM +0000, Xu, Min M wrote:
> Gerd & Tom
> What are your comments about this patch-set?
> 
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918
> > 
> > Above BZ reports an issue that commit 88da06ca triggers ASSERT in some
> > scenario. This patch-set is to fix this issue.
> > 
> > As commit 88da06ca describes TDVF BSP and APs are simplied and it can
> > simply use MpInitLibUp instead of MpInitLib. To achieve this goal, we
> > include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and IntelTdxX64. This is
> > done by setting different FILE_GUID to these drivers (of the same name). In
> > the other hand, we import a set of MpInitLibDepLib. These libs simply
> > depend on the PPI/Protocols. While these PPI/Protocols are installed
> > according to the guest type.

So the idea is to pick the one or the other implementations via guid
and depex dependencies?  The approach looks sane to me.

Assuming the above is correct:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd