From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.9334.1652803275248273103 for ; Tue, 17 May 2022 09:01:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=l5vQo05m; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 4C3B720F7229; Tue, 17 May 2022 09:01:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4C3B720F7229 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1652803274; bh=FqRz8+t822z8sutpswhPSaastva0mAVAnthZEmj/jQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l5vQo05mMUdlz8OkkqIMCwZCzbwIeRXfiplIevFB5N268YN/yHAJggmfSVhI75dDP 5oaiTFWj/aYVm/eG4DiE6rOlFNtVrOzS5NBvxUaP0pidcbX3J6i1wDsXFUNawnoaMC dL6D041rmYwjUQiBehXFntR9LwwxDWJdzE6+H/6A= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Michael D Kinney , Michael Kubacki , Sean Brogan , Bret Barkelew Subject: [PATCH v1 4/8] UnitTestFrameworkPkg: Fix new typos reported Date: Tue, 17 May 2022 12:00:39 -0400 Message-Id: <20220517160043.1210-5-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220517160043.1210-1-mikuback@linux.microsoft.com> References: <20220517160043.1210-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAlloca= tionLibPosix.c | 18 ++++++------ UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c = | 2 +- UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbC= lass.c | 2 +- UnitTestFrameworkPkg/Library/UnitTestLib/Log.c = | 2 +- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c = | 2 +- UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.= c | 2 +- UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h = | 2 +- UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h = | 2 +- UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml = | 29 ++++++++++++++------ 9 files changed, 36 insertions(+), 25 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/= MemoryAllocationLibPosix.c b/UnitTestFrameworkPkg/Library/Posix/MemoryAll= ocationLibPosix/MemoryAllocationLibPosix.c index 54029283fbbf..f85a05ec06ee 100644 --- a/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryA= llocationLibPosix.c +++ b/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryA= llocationLibPosix.c @@ -27,7 +27,7 @@ /// typedef struct { UINT32 Signature; - VOID *AllocatedBufffer; + VOID *AllocatedBuffer; UINTN TotalPages; VOID *AlignedBuffer; UINTN AlignedPages; @@ -165,16 +165,16 @@ AllocateAlignedPages ( // // We need reserve Alignment pages for PAGE_HEAD, as meta data. // - PageHead.Signature =3D PAGE_HEAD_PRIVATE_SIGNATURE; - PageHead.TotalPages =3D Pages + EFI_SIZE_TO_PAGES (Alignment) * = 2; - PageHead.AlignedPages =3D Pages; - PageHead.AllocatedBufffer =3D malloc (EFI_PAGES_TO_SIZE (PageHead.Tota= lPages)); - if (PageHead.AllocatedBufffer =3D=3D NULL) { + PageHead.Signature =3D PAGE_HEAD_PRIVATE_SIGNATURE; + PageHead.TotalPages =3D Pages + EFI_SIZE_TO_PAGES (Alignment) * 2= ; + PageHead.AlignedPages =3D Pages; + PageHead.AllocatedBuffer =3D malloc (EFI_PAGES_TO_SIZE (PageHead.Total= Pages)); + if (PageHead.AllocatedBuffer =3D=3D NULL) { return NULL; } =20 - PageHead.AlignedBuffer =3D (VOID *)(((UINTN)PageHead.AllocatedBufffer = + AlignmentMask) & ~AlignmentMask); - if ((UINTN)PageHead.AlignedBuffer - (UINTN)PageHead.AllocatedBufffer <= sizeof (PAGE_HEAD)) { + PageHead.AlignedBuffer =3D (VOID *)(((UINTN)PageHead.AllocatedBuffer += AlignmentMask) & ~AlignmentMask); + if ((UINTN)PageHead.AlignedBuffer - (UINTN)PageHead.AllocatedBuffer < = sizeof (PAGE_HEAD)) { PageHead.AlignedBuffer =3D (VOID *)((UINTN)PageHead.AlignedBuffer + = Alignment); } =20 @@ -279,7 +279,7 @@ FreeAlignedPages ( } =20 PageHeadPtr->Signature =3D 0; - free (PageHeadPtr->AllocatedBufffer); + free (PageHeadPtr->AllocatedBuffer); } =20 /** diff --git a/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBoo= tLibNull.c b/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBoo= tLibNull.c index a49aaefdb71f..7ff80850ff57 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNul= l.c +++ b/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNul= l.c @@ -13,7 +13,7 @@ =20 @retval EFI_SUCCESS Boot device for next boot was set. @retval EFI_UNSUPPORTED Setting the boot device for the next boot is = not - supportted. + supported. @retval Other Boot device for next boot can not be set. **/ EFI_STATUS diff --git a/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTes= tBootLibUsbClass.c b/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass= /UnitTestBootLibUsbClass.c index ebb42186a534..8b03e7cd15fc 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLi= bUsbClass.c +++ b/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLi= bUsbClass.c @@ -20,7 +20,7 @@ =20 @retval EFI_SUCCESS Boot device for next boot was set. @retval EFI_UNSUPPORTED Setting the boot device for the next boot is = not - supportted. + supported. @retval Other Boot device for next boot can not be set. **/ EFI_STATUS diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFra= meworkPkg/Library/UnitTestLib/Log.c index 3998aafdf843..35544ff0659a 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c @@ -1,5 +1,5 @@ /** - Implemnet UnitTestLib log services + Implement UnitTestLib log services =20 Copyright (c) Microsoft Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/Uni= tTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c index 64d5880783bf..d095b2f12067 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c @@ -215,7 +215,7 @@ InitUnitTestFramework ( NewFramework =3D NULL; =20 // - // First, check all pointers and make sure nothing's broked. + // First, check all pointers and make sure nothing is broken. // if ((FrameworkHandle =3D=3D NULL) || (Title =3D=3D NULL) || (ShortTitle =3D=3D NULL) || (VersionString =3D=3D NULL)) diff --git a/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/Sam= pleUnitTest.c b/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/= SampleUnitTest.c index c02a2dba987d..dd010a75a5a6 100644 --- a/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnit= Test.c +++ b/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnit= Test.c @@ -1,5 +1,5 @@ /** @file - This is a sample to demostrate the usage of the Unit Test Library that + This is a sample to demonstrate the usage of the Unit Test Library tha= t supports the PEI, DXE, SMM, UEFI SHell, and host execution environment= s. =20 Copyright (c) Microsoft Corporation.
diff --git a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.= h b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h index d90bff0e4c1b..de4b9566837b 100644 --- a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h +++ b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h @@ -19,7 +19,7 @@ =20 @retval EFI_SUCCESS Boot device for next boot was set. @retval EFI_UNSUPPORTED Setting the boot device for the next boot is = not - supportted. + supported. @retval Other Boot device for next boot can not be set. **/ EFI_STATUS diff --git a/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h= b/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h index adce413818a2..0c0e82de4003 100644 --- a/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h +++ b/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h @@ -18,7 +18,7 @@ #define UNIT_TEST_MAX_STRING_LENGTH (120) =20 /// -/// The size of a firngerprint used to save/resume execution of a unit t= est +/// The size of a fingerprint used to save/resume execution of a unit te= st /// framework. This is the size of a CRC32 value which is 32-bit value. /// /// diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTest= FrameworkPkg/UnitTestFrameworkPkg.ci.yaml index 77d51e13484c..dab416521585 100644 --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml @@ -81,19 +81,30 @@ "Library/CmockaLib/cmocka/**/*.*" # not going to spell chec= k a submodule ], "ExtendWords": [ # words to extend to the dictionary= for this package - "testcase", - "testsuites", - "cmocka", + "assertnotefierror", + "assertnotnull", + "assertstatusequal", "buildmodule", + "cmocka", + "cmockery", + "corthon", # Contact GitHub account in Readme "criterium", + "deadloop", + "devpath", + "DHAVE", # build flag for cmocka in the INF + "expectassert", + "failuretype", + "mdkinney", # Contact GitHub account in Readme + "NOFAILURE", + "notefierror", + "notequal", "pytool", "pytools", - "NOFAILURE", - "cmockery", - "DHAVE", # build flag for cmocka in the INF - "corthon", # Contact GitHub account in Readme - "mdkinney", # Contact GitHub account in Readme - "spbrogan" # Contact GitHub account in Readme + "spbrogan", # Contact GitHub account in Readme + "statusequal", + "testcase", + "testfailuremsg", + "testsuites" ], "IgnoreStandardPaths": [], # Standard Plugin defined paths tha= t should be ignore "AdditionalIncludePaths": [] # Additional paths to spell check (= wildcards supported) --=20 2.28.0.windows.1