* [PATCH v2 01/11] PrmPkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 02/11] StandaloneMmPkg: " Michael Kubacki
` (9 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Nate DeSimone, Ankit Sinha
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
PrmPkg/Application/PrmInfo/PrmInfo.c | 2 +-
PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c | 2 +-
PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c | 2 +-
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c | 2 +-
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c | 2 +-
PrmPkg/Include/Library/PrmModuleDiscoveryLib.h | 2 +-
PrmPkg/PrmLoaderDxe/PrmAcpiTable.h | 4 ++--
PrmPkg/PrmPkg.ci.yaml | 9 +++++++++
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h | 4 ++--
9 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/PrmPkg/Application/PrmInfo/PrmInfo.c b/PrmPkg/Application/PrmInfo/PrmInfo.c
index 0cde2fad3b4b..178d4810f498 100644
--- a/PrmPkg/Application/PrmInfo/PrmInfo.c
+++ b/PrmPkg/Application/PrmInfo/PrmInfo.c
@@ -148,7 +148,7 @@ PrintMmioRuntimeRangeInfo (
Gathers the PRM handler (and by extension module) information discovered on this system.
This function must be called to build up the discovered context for other functions in the application. The
- function will optionally print results as determed by the value of the PrintInformation parameter.
+ function will optionally print results as determined by the value of the PrintInformation parameter.
@param[in] PrintInformation Indicates whether to print information as discovered in the function.
diff --git a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c
index e6bea47bc583..34373effd4cd 100644
--- a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c
+++ b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c
@@ -149,7 +149,7 @@ IsAddressInMmram (
/**
Discovers all PRM Modules loaded during boot.
- Each PRM Module discovered is placed into a linked list so the list can br processsed in the future.
+ Each PRM Module discovered is placed into a linked list so the list can br processed in the future.
@param[out] ModuleCount An optional pointer parameter that, if provided, is set to the number
of PRM modules discovered.
diff --git a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c
index 5a223d783d80..7b0042f133ef 100644
--- a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c
+++ b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c
@@ -295,7 +295,7 @@ PublishPrmAcpiTable (
time of this function invocation.
The main responsibilities of the PRM Loader are executed from this function which include 3 phases:
- 1.) Disover PRM Modules - Find all PRM modules loaded during DXE dispatch and insert a PRM Module
+ 1.) Discover PRM Modules - Find all PRM modules loaded during DXE dispatch and insert a PRM Module
Context entry into a linked list to be handed off to phase 2.
2.) Process PRM Modules - Build a GUID to PRM handler mapping for each module that is described in the
PRM ACPI table so the OS can resolve a PRM Handler GUID to the corresponding PRM Handler physical address.
diff --git a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c
index a5799ff92d0c..abc6a4f1440c 100644
--- a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c
+++ b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c
@@ -130,7 +130,7 @@ UnitTestExit (
@retval EFI_SUCCESS The image has been unloaded.
@retval EFI_UNSUPPORTED The image has been started, and does not support
unload.
- @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image handle.
+ @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle.
**/
EFI_STATUS
diff --git a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c
index 799b153a445f..46fd263ec070 100644
--- a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c
+++ b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c
@@ -723,7 +723,7 @@ UnitTestReinstallProtocolInterface (
}
/**
- Uninstalls all instances of a protocol:interfacer from a handle.
+ Uninstalls all instances of a protocol from a handle.
If the last protocol interface is remove from the handle, the
handle is freed.
diff --git a/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h
index 341b9b26a0f8..9df8d4d02370 100644
--- a/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h
+++ b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h
@@ -34,7 +34,7 @@ GetNextPrmModuleEntry (
/**
Discovers all PRM Modules loaded during boot.
- Each PRM Module discovered is placed into a linked list so the list can br processsed in the future.
+ Each PRM Module discovered is placed into a linked list so the list can br processed in the future.
@param[out] ModuleCount An optional pointer parameter that, if provided, is set to the number
of PRM modules discovered.
diff --git a/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h b/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h
index e2034d4738bd..fdb708c2a112 100644
--- a/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h
+++ b/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h
@@ -72,7 +72,7 @@ typedef struct {
//
// Todo: Revisit whether to use; currently both macros are not used
//
-#define PRM_MODULE_INFORMATION_STRUCTURE(ModuleGuid, ModuleRevision, HandlerCount, PrmHanderInfoStructureArray) { \
+#define PRM_MODULE_INFORMATION_STRUCTURE(ModuleGuid, ModuleRevision, HandlerCount, PrmHandlerInfoStructureArray) { \
{ \
PRM_MODULE_INFORMATION_STRUCT_REVISION, /* UINT16 StructureRevision; */ \
(OFFSET_OF (PRM_MODULE_INFORMATION_STRUCT, HandlerInfoStructure) + (HandlerCount * sizeof (PRM_HANDLER_INFORMATION_STRUCT))) /* UINT16 StructureLength; */ \
@@ -80,7 +80,7 @@ typedef struct {
ModuleRevision, /* UINT16 ModuleRevision */ \
HandlerCount, /* UINT16 HandlerCount */ \
OFFSET_OF (PRM_MODULE_INFORMATION_STRUCT, HandlerInfoOffset), /* UINT32 HandlerInfoOffset */ \
- PrmHanderInfoStructureArray /* PRM_HANDLER_INFORMATION_STRUCT HandlerInfoStructure */ \
+ PrmHandlerInfoStructureArray /* PRM_HANDLER_INFORMATION_STRUCT HandlerInfoStructure */ \
} \
}
diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml
index babaf2214ec8..0c84e616adbf 100644
--- a/PrmPkg/PrmPkg.ci.yaml
+++ b/PrmPkg/PrmPkg.ci.yaml
@@ -93,10 +93,19 @@
# in matching files
"ExtendWords": [ # words to extend to the dictionary for this package
"buffe", # note: appears in buffer ascii dump in documentation
+ "dbgmsgid",
+ "devicepath",
"iptor", # note: appears in buffer ascii dump in documentation
"keepoptionalheader",
"odule", # note: appears in buffer ascii dump in documentation
"oemid",
+ "packagelist",
+ "pecoff",
+ "prmconfig",
+ "prmcontextbufferlib",
+ "prminfo",
+ "prmloader",
+ "prmmodulediscoverylib",
"prmopreg",
"prmpecofflib",
"prmpkg",
diff --git a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h
index 82853bb61a1c..20958589b254 100644
--- a/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h
+++ b/PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h
@@ -354,7 +354,7 @@ UnitTestReinstallProtocolInterface (
);
/**
- Uninstalls all instances of a protocol:interfacer from a handle.
+ Uninstalls all instances of a protocol from a handle.
If the last protocol interface is remove from the handle, the
handle is freed.
@@ -600,7 +600,7 @@ UnitTestExit (
@retval EFI_SUCCESS The image has been unloaded.
@retval EFI_UNSUPPORTED The image has been started, and does not support
unload.
- @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image handle.
+ @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle.
**/
EFI_STATUS
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 02/11] StandaloneMmPkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 01/11] PrmPkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-12-13 10:26 ` Sami Mujawar
2022-05-18 0:13 ` [PATCH v2 03/11] DynamicTablesPkg: " Michael Kubacki
` (8 subsequent siblings)
10 siblings, 1 reply; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Sami Mujawar, Jiewen Yao, Supreeth Venkatesh
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
StandaloneMmPkg/Core/Dependency.c | 2 +-
StandaloneMmPkg/Core/Dispatcher.c | 18 +++++++++---------
StandaloneMmPkg/Core/Handle.c | 2 +-
StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +-
StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +-
StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 +++++++++
6 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/StandaloneMmPkg/Core/Dependency.c b/StandaloneMmPkg/Core/Dependency.c
index 440fe3e45238..0e9c0e96a276 100644
--- a/StandaloneMmPkg/Core/Dependency.c
+++ b/StandaloneMmPkg/Core/Dependency.c
@@ -38,7 +38,7 @@ BOOLEAN *mDepexEvaluationStackPointer = NULL;
/**
Grow size of the Depex stack
- @retval EFI_SUCCESS Stack successfully growed.
+ @retval EFI_SUCCESS Stack successfully grew.
@retval EFI_OUT_OF_RESOURCES There is not enough system memory to grow the stack.
**/
diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
index b1ccba15b060..01da395be3c4 100644
--- a/StandaloneMmPkg/Core/Dispatcher.c
+++ b/StandaloneMmPkg/Core/Dispatcher.c
@@ -17,7 +17,7 @@
and After dependencies. This is done recursively as the call to add
to the mScheduledQueue checks for Before Depexes and recursively
adds all Before Depexes. It then adds the item that was passed in
- and then processess the After dependencies by recursively calling
+ and then processes the After dependencies by recursively calling
the routine.
Dispatcher Rules:
@@ -93,29 +93,29 @@ LIST_ENTRY mScheduledQueue = INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
LIST_ENTRY mFwVolList = INITIALIZE_LIST_HEAD_VARIABLE (mFwVolList);
//
-// Flag for the MM Dispacher. TRUE if dispatcher is executing.
+// Flag for the MM Dispatcher. TRUE if dispatcher is executing.
//
BOOLEAN gDispatcherRunning = FALSE;
//
-// Flag for the MM Dispacher. TRUE if there is one or more MM drivers ready to be dispatched
+// Flag for the MM Dispatcher. TRUE if there is one or more MM drivers ready to be dispatched
//
BOOLEAN gRequestDispatch = FALSE;
//
// The global variable is defined for Loading modules at fixed address feature to track the MM code
-// memory range usage. It is a bit mapped array in which every bit indicates the correspoding
+// memory range usage. It is a bit mapped array in which every bit indicates the corresponding
// memory page available or not.
//
GLOBAL_REMOVE_IF_UNREFERENCED UINT64 *mMmCodeMemoryRangeUsageBitMap = NULL;
/**
To check memory usage bit map array to figure out if the memory range in which the image will be loaded
- is available or not. If memory range is avaliable, the function will mark the corresponding bits to 1
+ is available or not. If memory range is available, the function will mark the corresponding bits to 1
which indicates the memory range is used. The function is only invoked when load modules at fixed address
feature is enabled.
- @param ImageBase The base addres the image will be loaded at.
+ @param ImageBase The base address the image will be loaded at.
@param ImageSize The size of the image
@retval EFI_SUCCESS The memory range the image will be loaded in is available
@@ -194,7 +194,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
@param ImageContext Pointer to the image context structure that describes the PE/COFF
image that needs to be examined by this function.
@retval EFI_SUCCESS An fixed loading address is assigned to this image by build tools .
- @retval EFI_NOT_FOUND The image has no assigned fixed loadding address.
+ @retval EFI_NOT_FOUND The image has no assigned fixed loading address.
**/
EFI_STATUS
@@ -513,7 +513,7 @@ MmPreProcessDepex (
@param DriverEntry Driver to work on.
- @retval EFI_SUCCESS Depex read and preprossesed
+ @retval EFI_SUCCESS Depex read and pre-processed
@retval EFI_PROTOCOL_ERROR The section extraction protocol returned an error
and Depex reading needs to be retried.
@retval Error DEPEX not found.
@@ -851,7 +851,7 @@ FvIsBeingProcessed (
The Discovered list is never freed and contains booleans that represent the
other possible MM driver states.
- @param [in] FwVolHeader Pointer to the formware volume header.
+ @param [in] FwVolHeader Pointer to the firmware volume header.
@param [in] Pe32Data Pointer to the PE data.
@param [in] Pe32DataSize Size of the PE data.
@param [in] Depex Pointer to the Depex info.
diff --git a/StandaloneMmPkg/Core/Handle.c b/StandaloneMmPkg/Core/Handle.c
index 7df4629cf291..bd0005fcb84d 100644
--- a/StandaloneMmPkg/Core/Handle.c
+++ b/StandaloneMmPkg/Core/Handle.c
@@ -347,7 +347,7 @@ MmInstallProtocolInterfaceNotify (
}
/**
- Uninstalls all instances of a protocol:interfacer from a handle.
+ Uninstalls all instances of a protocol interface from a handle.
If the last protocol interface is remove from the handle, the
handle is freed.
diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.h b/StandaloneMmPkg/Core/StandaloneMmCore.h
index 822d95358c39..b5e2e4b9083b 100644
--- a/StandaloneMmPkg/Core/StandaloneMmCore.h
+++ b/StandaloneMmPkg/Core/StandaloneMmCore.h
@@ -426,7 +426,7 @@ MmInstallProtocolInterfaceNotify (
);
/**
- Uninstalls all instances of a protocol:interfacer from a handle.
+ Uninstalls all instances of a protocol interface from a handle.
If the last protocol interface is remove from the handle, the
handle is freed.
diff --git a/StandaloneMmPkg/Include/Guid/MmCoreData.h b/StandaloneMmPkg/Include/Guid/MmCoreData.h
index b8be92c6abfd..0f58f41d8060 100644
--- a/StandaloneMmPkg/Include/Guid/MmCoreData.h
+++ b/StandaloneMmPkg/Include/Guid/MmCoreData.h
@@ -70,7 +70,7 @@ typedef struct {
///
/// The MM Foundation Entry Point. The MM Core fills in this field when the
- /// MM Core is initialized. The MM IPL is responsbile for registering this entry
+ /// MM Core is initialized. The MM IPL is responsible for registering this entry
/// point with the MM Configuration Protocol. The MM Configuration Protocol may
/// not be available at the time the MM IPL and MM Core are started, so the MM IPL
/// sets up a protocol notification on the MM Configuration Protocol and registers
diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
index 4777532a7ede..535e269e7891 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
+++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
@@ -81,12 +81,21 @@
"IgnoreFiles": [], # use gitignore syntax to ignore errors
# in matching files
"ExtendWords": [
+ "bootinformation",
"Bsymbolic",
+ "bugbug",
+ "combineable",
+ "depexes",
"FwVol",
+ "hoblist",
+ "imagehandle",
+ "interfacer",
"mpidr",
"mstrict",
"schedulable",
"StandaloneMMCore",
+ "systemtable",
+ "uncacheable"
], # words to extend to the dictionary for this package
"IgnoreStandardPaths": [], # Standard Plugin defined paths that
# should be ignore
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2 02/11] StandaloneMmPkg: Fix new typos reported
2022-05-18 0:13 ` [PATCH v2 02/11] StandaloneMmPkg: " Michael Kubacki
@ 2022-12-13 10:26 ` Sami Mujawar
2022-12-14 3:03 ` [edk2-devel] " Michael Kubacki
0 siblings, 1 reply; 16+ messages in thread
From: Sami Mujawar @ 2022-12-13 10:26 UTC (permalink / raw)
To: mikuback, devel; +Cc: Ard Biesheuvel, Jiewen Yao, Supreeth Venkatesh
Hi Michael,
I just noted that 'interfacer' is no longer required in the
'ExtendWords' list. Please find my response inline marked [SAMI].
With the comment below fixed,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. This change fixes those typos.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 18 +++++++++---------
> StandaloneMmPkg/Core/Handle.c | 2 +-
> StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +-
> StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +-
> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 +++++++++
> 6 files changed, 22 insertions(+), 13 deletions(-)
>
> diff --git a/StandaloneMmPkg/Core/Dependency.c b/StandaloneMmPkg/Core/Dependency.c
> index 440fe3e45238..0e9c0e96a276 100644
> --- a/StandaloneMmPkg/Core/Dependency.c
> +++ b/StandaloneMmPkg/Core/Dependency.c
> @@ -38,7 +38,7 @@ BOOLEAN *mDepexEvaluationStackPointer = NULL;
> /**
> Grow size of the Depex stack
>
> - @retval EFI_SUCCESS Stack successfully growed.
> + @retval EFI_SUCCESS Stack successfully grew.
> @retval EFI_OUT_OF_RESOURCES There is not enough system memory to grow the stack.
>
> **/
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
> index b1ccba15b060..01da395be3c4 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -17,7 +17,7 @@
> and After dependencies. This is done recursively as the call to add
> to the mScheduledQueue checks for Before Depexes and recursively
> adds all Before Depexes. It then adds the item that was passed in
> - and then processess the After dependencies by recursively calling
> + and then processes the After dependencies by recursively calling
> the routine.
>
> Dispatcher Rules:
> @@ -93,29 +93,29 @@ LIST_ENTRY mScheduledQueue = INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
> LIST_ENTRY mFwVolList = INITIALIZE_LIST_HEAD_VARIABLE (mFwVolList);
>
> //
> -// Flag for the MM Dispacher. TRUE if dispatcher is executing.
> +// Flag for the MM Dispatcher. TRUE if dispatcher is executing.
> //
> BOOLEAN gDispatcherRunning = FALSE;
>
> //
> -// Flag for the MM Dispacher. TRUE if there is one or more MM drivers ready to be dispatched
> +// Flag for the MM Dispatcher. TRUE if there is one or more MM drivers ready to be dispatched
> //
> BOOLEAN gRequestDispatch = FALSE;
>
> //
> // The global variable is defined for Loading modules at fixed address feature to track the MM code
> -// memory range usage. It is a bit mapped array in which every bit indicates the correspoding
> +// memory range usage. It is a bit mapped array in which every bit indicates the corresponding
> // memory page available or not.
> //
> GLOBAL_REMOVE_IF_UNREFERENCED UINT64 *mMmCodeMemoryRangeUsageBitMap = NULL;
>
> /**
> To check memory usage bit map array to figure out if the memory range in which the image will be loaded
> - is available or not. If memory range is avaliable, the function will mark the corresponding bits to 1
> + is available or not. If memory range is available, the function will mark the corresponding bits to 1
> which indicates the memory range is used. The function is only invoked when load modules at fixed address
> feature is enabled.
>
> - @param ImageBase The base addres the image will be loaded at.
> + @param ImageBase The base address the image will be loaded at.
> @param ImageSize The size of the image
>
> @retval EFI_SUCCESS The memory range the image will be loaded in is available
> @@ -194,7 +194,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
> @param ImageContext Pointer to the image context structure that describes the PE/COFF
> image that needs to be examined by this function.
> @retval EFI_SUCCESS An fixed loading address is assigned to this image by build tools .
> - @retval EFI_NOT_FOUND The image has no assigned fixed loadding address.
> + @retval EFI_NOT_FOUND The image has no assigned fixed loading address.
>
> **/
> EFI_STATUS
> @@ -513,7 +513,7 @@ MmPreProcessDepex (
>
> @param DriverEntry Driver to work on.
>
> - @retval EFI_SUCCESS Depex read and preprossesed
> + @retval EFI_SUCCESS Depex read and pre-processed
> @retval EFI_PROTOCOL_ERROR The section extraction protocol returned an error
> and Depex reading needs to be retried.
> @retval Error DEPEX not found.
> @@ -851,7 +851,7 @@ FvIsBeingProcessed (
> The Discovered list is never freed and contains booleans that represent the
> other possible MM driver states.
>
> - @param [in] FwVolHeader Pointer to the formware volume header.
> + @param [in] FwVolHeader Pointer to the firmware volume header.
> @param [in] Pe32Data Pointer to the PE data.
> @param [in] Pe32DataSize Size of the PE data.
> @param [in] Depex Pointer to the Depex info.
> diff --git a/StandaloneMmPkg/Core/Handle.c b/StandaloneMmPkg/Core/Handle.c
> index 7df4629cf291..bd0005fcb84d 100644
> --- a/StandaloneMmPkg/Core/Handle.c
> +++ b/StandaloneMmPkg/Core/Handle.c
> @@ -347,7 +347,7 @@ MmInstallProtocolInterfaceNotify (
> }
>
> /**
> - Uninstalls all instances of a protocol:interfacer from a handle.
> + Uninstalls all instances of a protocol interface from a handle.
> If the last protocol interface is remove from the handle, the
> handle is freed.
>
> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.h b/StandaloneMmPkg/Core/StandaloneMmCore.h
> index 822d95358c39..b5e2e4b9083b 100644
> --- a/StandaloneMmPkg/Core/StandaloneMmCore.h
> +++ b/StandaloneMmPkg/Core/StandaloneMmCore.h
> @@ -426,7 +426,7 @@ MmInstallProtocolInterfaceNotify (
> );
>
> /**
> - Uninstalls all instances of a protocol:interfacer from a handle.
> + Uninstalls all instances of a protocol interface from a handle.
> If the last protocol interface is remove from the handle, the
> handle is freed.
>
> diff --git a/StandaloneMmPkg/Include/Guid/MmCoreData.h b/StandaloneMmPkg/Include/Guid/MmCoreData.h
> index b8be92c6abfd..0f58f41d8060 100644
> --- a/StandaloneMmPkg/Include/Guid/MmCoreData.h
> +++ b/StandaloneMmPkg/Include/Guid/MmCoreData.h
> @@ -70,7 +70,7 @@ typedef struct {
>
> ///
> /// The MM Foundation Entry Point. The MM Core fills in this field when the
> - /// MM Core is initialized. The MM IPL is responsbile for registering this entry
> + /// MM Core is initialized. The MM IPL is responsible for registering this entry
> /// point with the MM Configuration Protocol. The MM Configuration Protocol may
> /// not be available at the time the MM IPL and MM Core are started, so the MM IPL
> /// sets up a protocol notification on the MM Configuration Protocol and registers
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> index 4777532a7ede..535e269e7891 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> @@ -81,12 +81,21 @@
> "IgnoreFiles": [], # use gitignore syntax to ignore errors
> # in matching files
> "ExtendWords": [
> + "bootinformation",
> "Bsymbolic",
> + "bugbug",
> + "combineable",
> + "depexes",
> "FwVol",
> + "hoblist",
> + "imagehandle",
> + "interfacer",
[SAMI] I think the above word is fixed in StandaloneMmPkg/Core/Handle.c
and StandaloneMmPkg/Core/StandaloneMmCore and 'interfacer' could be
removed. Can you check, please?
[/SAMI]
> "mpidr",
> "mstrict",
> "schedulable",
> "StandaloneMMCore",
> + "systemtable",
> + "uncacheable"
> ], # words to extend to the dictionary for this package
> "IgnoreStandardPaths": [], # Standard Plugin defined paths that
> # should be ignore
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [edk2-devel] [PATCH v2 02/11] StandaloneMmPkg: Fix new typos reported
2022-12-13 10:26 ` Sami Mujawar
@ 2022-12-14 3:03 ` Michael Kubacki
0 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-12-14 3:03 UTC (permalink / raw)
To: devel, sami.mujawar; +Cc: Ard Biesheuvel, Jiewen Yao, Supreeth Venkatesh
Thanks. I made that change in v3 that I will send soon.
On 12/13/2022 5:26 AM, Sami Mujawar wrote:
> Hi Michael,
>
> I just noted that 'interfacer' is no longer required in the
> 'ExtendWords' list. Please find my response inline marked [SAMI].
>
> With the comment below fixed,
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> The SpellCheck plugin began reporting new typos that were previously
>> missed. This change fixes those typos.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>> ---
>> StandaloneMmPkg/Core/Dependency.c | 2 +-
>> StandaloneMmPkg/Core/Dispatcher.c | 18 +++++++++---------
>> StandaloneMmPkg/Core/Handle.c | 2 +-
>> StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +-
>> StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +-
>> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 +++++++++
>> 6 files changed, 22 insertions(+), 13 deletions(-)
>>
>> diff --git a/StandaloneMmPkg/Core/Dependency.c
>> b/StandaloneMmPkg/Core/Dependency.c
>> index 440fe3e45238..0e9c0e96a276 100644
>> --- a/StandaloneMmPkg/Core/Dependency.c
>> +++ b/StandaloneMmPkg/Core/Dependency.c
>> @@ -38,7 +38,7 @@ BOOLEAN *mDepexEvaluationStackPointer = NULL;
>> /**
>> Grow size of the Depex stack
>>
>> - @retval EFI_SUCCESS Stack successfully growed.
>> + @retval EFI_SUCCESS Stack successfully grew.
>> @retval EFI_OUT_OF_RESOURCES There is not enough system memory to
>> grow the stack.
>>
>> **/
>> diff --git a/StandaloneMmPkg/Core/Dispatcher.c
>> b/StandaloneMmPkg/Core/Dispatcher.c
>> index b1ccba15b060..01da395be3c4 100644
>> --- a/StandaloneMmPkg/Core/Dispatcher.c
>> +++ b/StandaloneMmPkg/Core/Dispatcher.c
>> @@ -17,7 +17,7 @@
>> and After dependencies. This is done recursively as the
>> call to add
>> to the mScheduledQueue checks for Before Depexes and
>> recursively
>> adds all Before Depexes. It then adds the item that was
>> passed in
>> - and then processess the After dependencies by recursively
>> calling
>> + and then processes the After dependencies by recursively
>> calling
>> the routine.
>>
>> Dispatcher Rules:
>> @@ -93,29 +93,29 @@ LIST_ENTRY mScheduledQueue =
>> INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
>> LIST_ENTRY mFwVolList = INITIALIZE_LIST_HEAD_VARIABLE (mFwVolList);
>>
>> //
>> -// Flag for the MM Dispacher. TRUE if dispatcher is executing.
>> +// Flag for the MM Dispatcher. TRUE if dispatcher is executing.
>> //
>> BOOLEAN gDispatcherRunning = FALSE;
>>
>> //
>> -// Flag for the MM Dispacher. TRUE if there is one or more MM
>> drivers ready to be dispatched
>> +// Flag for the MM Dispatcher. TRUE if there is one or more MM
>> drivers ready to be dispatched
>> //
>> BOOLEAN gRequestDispatch = FALSE;
>>
>> //
>> // The global variable is defined for Loading modules at fixed
>> address feature to track the MM code
>> -// memory range usage. It is a bit mapped array in which every bit
>> indicates the correspoding
>> +// memory range usage. It is a bit mapped array in which every bit
>> indicates the corresponding
>> // memory page available or not.
>> //
>> GLOBAL_REMOVE_IF_UNREFERENCED UINT64
>> *mMmCodeMemoryRangeUsageBitMap = NULL;
>>
>> /**
>> To check memory usage bit map array to figure out if the memory
>> range in which the image will be loaded
>> - is available or not. If memory range is avaliable, the function
>> will mark the corresponding bits to 1
>> + is available or not. If memory range is available, the function
>> will mark the corresponding bits to 1
>> which indicates the memory range is used. The function is only
>> invoked when load modules at fixed address
>> feature is enabled.
>>
>> - @param ImageBase The base addres the image will be
>> loaded at.
>> + @param ImageBase The base address the image will be
>> loaded at.
>> @param ImageSize The size of the image
>>
>> @retval EFI_SUCCESS The memory range the image will
>> be loaded in is available
>> @@ -194,7 +194,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
>> @param ImageContext Pointer to the image context
>> structure that describes the PE/COFF
>> image that needs to be examined
>> by this function.
>> @retval EFI_SUCCESS An fixed loading address is
>> assigned to this image by build tools .
>> - @retval EFI_NOT_FOUND The image has no assigned fixed
>> loadding address.
>> + @retval EFI_NOT_FOUND The image has no assigned fixed
>> loading address.
>>
>> **/
>> EFI_STATUS
>> @@ -513,7 +513,7 @@ MmPreProcessDepex (
>>
>> @param DriverEntry Driver to work on.
>>
>> - @retval EFI_SUCCESS Depex read and preprossesed
>> + @retval EFI_SUCCESS Depex read and pre-processed
>> @retval EFI_PROTOCOL_ERROR The section extraction protocol
>> returned an error
>> and Depex reading needs to be retried.
>> @retval Error DEPEX not found.
>> @@ -851,7 +851,7 @@ FvIsBeingProcessed (
>> The Discovered list is never freed and contains booleans that
>> represent the
>> other possible MM driver states.
>>
>> - @param [in] FwVolHeader Pointer to the formware volume header.
>> + @param [in] FwVolHeader Pointer to the firmware volume header.
>> @param [in] Pe32Data Pointer to the PE data.
>> @param [in] Pe32DataSize Size of the PE data.
>> @param [in] Depex Pointer to the Depex info.
>> diff --git a/StandaloneMmPkg/Core/Handle.c
>> b/StandaloneMmPkg/Core/Handle.c
>> index 7df4629cf291..bd0005fcb84d 100644
>> --- a/StandaloneMmPkg/Core/Handle.c
>> +++ b/StandaloneMmPkg/Core/Handle.c
>> @@ -347,7 +347,7 @@ MmInstallProtocolInterfaceNotify (
>> }
>>
>> /**
>> - Uninstalls all instances of a protocol:interfacer from a handle.
>> + Uninstalls all instances of a protocol interface from a handle.
>> If the last protocol interface is remove from the handle, the
>> handle is freed.
>>
>> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.h
>> b/StandaloneMmPkg/Core/StandaloneMmCore.h
>> index 822d95358c39..b5e2e4b9083b 100644
>> --- a/StandaloneMmPkg/Core/StandaloneMmCore.h
>> +++ b/StandaloneMmPkg/Core/StandaloneMmCore.h
>> @@ -426,7 +426,7 @@ MmInstallProtocolInterfaceNotify (
>> );
>>
>> /**
>> - Uninstalls all instances of a protocol:interfacer from a handle.
>> + Uninstalls all instances of a protocol interface from a handle.
>> If the last protocol interface is remove from the handle, the
>> handle is freed.
>>
>> diff --git a/StandaloneMmPkg/Include/Guid/MmCoreData.h
>> b/StandaloneMmPkg/Include/Guid/MmCoreData.h
>> index b8be92c6abfd..0f58f41d8060 100644
>> --- a/StandaloneMmPkg/Include/Guid/MmCoreData.h
>> +++ b/StandaloneMmPkg/Include/Guid/MmCoreData.h
>> @@ -70,7 +70,7 @@ typedef struct {
>>
>> ///
>> /// The MM Foundation Entry Point. The MM Core fills in this
>> field when the
>> - /// MM Core is initialized. The MM IPL is responsbile for
>> registering this entry
>> + /// MM Core is initialized. The MM IPL is responsible for
>> registering this entry
>> /// point with the MM Configuration Protocol. The MM
>> Configuration Protocol may
>> /// not be available at the time the MM IPL and MM Core are
>> started, so the MM IPL
>> /// sets up a protocol notification on the MM Configuration
>> Protocol and registers
>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> index 4777532a7ede..535e269e7891 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> @@ -81,12 +81,21 @@
>> "IgnoreFiles": [], # use gitignore syntax to
>> ignore errors
>> # in matching files
>> "ExtendWords": [
>> + "bootinformation",
>> "Bsymbolic",
>> + "bugbug",
>> + "combineable",
>> + "depexes",
>> "FwVol",
>> + "hoblist",
>> + "imagehandle",
>> + "interfacer",
>
> [SAMI] I think the above word is fixed in StandaloneMmPkg/Core/Handle.c
> and StandaloneMmPkg/Core/StandaloneMmCore and 'interfacer' could be
> removed. Can you check, please?
>
> [/SAMI]
>
>> "mpidr",
>> "mstrict",
>> "schedulable",
>> "StandaloneMMCore",
>> + "systemtable",
>> + "uncacheable"
>> ], # words to extend to the dictionary for this
>> package
>> "IgnoreStandardPaths": [], # Standard Plugin defined paths
>> that
>> # should be ignore
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy
> the information in any medium. Thank you.
>
>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 03/11] DynamicTablesPkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 01/11] PrmPkg: " Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 02/11] StandaloneMmPkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 04/11] UnitTestFrameworkPkg: " Michael Kubacki
` (7 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Sami Mujawar, Alexei Fedorov, Sami Mujawar
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 2 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 +-
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | 2 +-
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 4 +--
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 2 +-
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 31 +++++++++++++++-----
DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h | 4 +--
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h | 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h | 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h | 2 +-
DynamicTablesPkg/Readme.md | 4 +--
15 files changed, 41 insertions(+), 24 deletions(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
index 59001378c4e0..83bda4cfba67 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
@@ -352,7 +352,7 @@ AddPrivateResources (
return Status;
}
- // The Node indexer has the Processor hierarchy nodes at the begining
+ // The Node indexer has the Processor hierarchy nodes at the beginning
// followed by the cache structs. Therefore we can skip the Processor
// hierarchy nodes in the node indexer search.
Status = GetPpttNodeReferencedByToken (
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
index 18c8b8d24525..b823b412caae 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
@@ -377,7 +377,7 @@ FixupCmn600Info (
goto error_handler;
}
- // Serialise the definition block
+ // Serialize the definition block
Status = AmlSerializeDefinitionBlock (
RootNodeHandle,
Table
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
index dafbd19fde15..32c3ab534d0b 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
@@ -619,7 +619,7 @@ AmlCodeGenRdDWordMemory (
See ACPI 6.4 spec, s19.2.8 for more.
@param [in] IsReadWrite ReadAndWrite parameter.
- @param [in] Addres AddressBase parameter.
+ @param [in] Address AddressBase parameter.
@param [in] RangeLength Range length.
@param [in] NameOpNode NameOp object node defining a named object.
If provided, append the new resource data
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
index 8c77716dab80..60694819fb4c 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
@@ -1284,7 +1284,7 @@ AmlAddNameSpaceReference (
When computing the size of a tree or serializing it, the additional data is
not taken into account (i.e. the MethodInvocationOp and the ArgumentCount).
- Method invocation nodes have the AML_METHOD_INVOVATION attribute.
+ Method invocation nodes have the AML_METHOD_INVOCATION attribute.
@param [in] NameSpaceRefNode NameSpaceRef node pointing to the
the definition of the invoked
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
index 8e584d49307a..6f80725bf13d 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
@@ -331,7 +331,7 @@ AmlParseString (
StrSize = 0;
// AML String is NULL terminated.
do {
- // Reading the stream moves the stream forward aswell.
+ // Reading the stream moves the stream forward as well.
Status = AmlStreamReadByte (FStream, &Byte);
if (EFI_ERROR (Status)) {
ASSERT (0);
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
index 1404a2182b65..0a744f1ff3fa 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
@@ -573,7 +573,7 @@ AmlIsMethodDefinitionNode (
{
AML_DATA_NODE *ObjectType;
- // Node is checked to be an object node aswell.
+ // Node is checked to be an object node as well.
if (AmlNodeCompareOpCode (Node, AML_METHOD_OP, 0)) {
return TRUE;
} else if (AmlNodeCompareOpCode (Node, AML_EXTERNAL_OP, 0)) {
diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
index bc713f30b2fe..1244bbda702d 100644
--- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
+++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
@@ -294,9 +294,9 @@ GroupCmObjNodes (
return Status;
}
-/** Finalise the dynamic repository.
+/** Finalize the dynamic repository.
- Finalising means:
+ Finalizing means:
- Preventing any further objects from being added.
- Allowing to get objects from the dynamic repository
(not possible before a call to this function).
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
index 831f0d5b7365..d38a331f4822 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
@@ -88,7 +88,7 @@ GetGicVersion (
/** Gic dispatcher.
- This disptacher populates the following structures:
+ This dispatcher populates the following structures:
- CM_ARM_GICC_INFO
- CM_ARM_GICD_INFO
- CM_ARM_GIC_MSI_FRAME_INFO
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
index 0557e416b44c..71e92ee1fb14 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
@@ -447,7 +447,7 @@ ArmSerialPortInfoParser (
/** SerialPort dispatcher.
- This disptacher populates the CM_ARM_SERIAL_PORT_INFO structure for
+ This dispatcher populates the CM_ARM_SERIAL_PORT_INFO structure for
the following CM_OBJ_ID:
- EArmObjSerialConsolePortInfo
- EArmObjSerialDebugPortInfo
diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index bfa282926e48..2d2f3405e467 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -92,35 +92,52 @@
"IgnoreFiles": [], # use gitignore syntax to ignore errors
# in matching files
"ExtendWords": [
+ "aaaabbbbcccc",
+ "AMLDBG",
"ARMHB", # ARMHB000
"ARMHC", # ARMHC600
"ARMLTD",
- "AMLDBG",
- "EISAID",
+ "bytecodes",
+ "bytelist",
+ "bytestream",
"CCIDX",
"CCSIDR",
"countof",
+ "deregistering",
+ "devicetree",
"edynamic",
+ "EISAID",
"EOBJECT",
+ "etable",
+ "finalise",
+ "GTBLOCK",
"invoc",
"ITARGETSR",
- "GTBLOCK",
"lgreater",
"lless",
+ "mainpage",
+ "mismanipulation",
"MPIDR",
+ "nameseg",
+ "namespaceid",
+ "namespacestring",
+ "namestr",
"PERIPHBASE",
"phandle",
+ "pkglen",
+ "prefetchable",
"pytool",
"Rdword",
+ "redist",
"Roadmap",
"ROOTNODEBASE",
- "ssdtcmn",
- "ssdtserialporttemplate",
"SMMUV",
- "ssdtpcieosctemplate",
+ "ssdtcmn",
"SSDTPC",
- "standardised",
+ "ssdtpcieosctemplate",
+ "ssdtserialporttemplate",
"TABLEEX",
+ "tagsize",
"TNSID",
"Vatos",
"WBINVD"
diff --git a/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h b/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
index bb18215b08bc..c3cd6b5728ff 100644
--- a/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
+++ b/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
@@ -38,9 +38,9 @@ DynPlatRepoAddObject (
OUT CM_OBJECT_TOKEN *Token OPTIONAL
);
-/** Finalise the dynamic repository.
+/** Finalize the dynamic repository.
- Finalising means:
+ Finalizing means:
- Preventing any further objects from being added.
- Allowing to get objects from the dynamic repository
(not possible before a call to this function).
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
index ac3284d0311e..6e4837956f74 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
@@ -138,7 +138,7 @@ AmlAddNameSpaceReference (
When computing the size of a tree or serializing it, the additional data is
not taken into account (i.e. the MethodInvocationOp and the ArgumentCount).
- Method invocation nodes have the AML_METHOD_INVOVATION attribute.
+ Method invocation nodes have the AML_METHOD_INVOCATION attribute.
@param [in] NameSpaceRefNode NameSpaceRef node pointing to the
the definition of the invoked
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
index aa942f7d1f49..65c5968baa57 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
@@ -40,7 +40,7 @@ GetGicVersion (
/** Gic dispatcher.
- This disptacher populates the following structures:
+ This dispatcher populates the following structures:
- CM_ARM_GICC_INFO
- CM_ARM_GICD_INFO
- CM_ARM_GIC_MSI_FRAME_INFO
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
index de08e57e6c57..cec93d389240 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
@@ -14,7 +14,7 @@
/** SerialPort dispatcher.
- This disptacher populates the CM_ARM_SERIAL_PORT_INFO structure for
+ This dispatcher populates the CM_ARM_SERIAL_PORT_INFO structure for
the following CM_OBJ_ID:
- EArmObjSerialConsolePortInfo
- EArmObjSerialDebugPortInfo
diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
index 5f92d4c6cb2e..f5b3f65cd9af 100644
--- a/DynamicTablesPkg/Readme.md
+++ b/DynamicTablesPkg/Readme.md
@@ -11,9 +11,9 @@ UEFI modules.
# Feature Summary
-The dynamic tables framework is designed to generate standardised
+The dynamic tables framework is designed to generate standardized
firmware tables that describe the hardware information at
-run-time. A goal of standardised firmware is to have a common
+run-time. A goal of standardized firmware is to have a common
firmware for a platform capable of booting both Windows and Linux
operating systems.
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 04/11] UnitTestFrameworkPkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (2 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 03/11] DynamicTablesPkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 05/11] FatPkg: " Michael Kubacki
` (6 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Michael Kubacki, Sean Brogan, Bret Barkelew
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c | 18 ++++++------
UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c | 2 +-
UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c | 2 +-
UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +-
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 2 +-
UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c | 2 +-
UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h | 2 +-
UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h | 2 +-
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 29 ++++++++++++++------
9 files changed, 36 insertions(+), 25 deletions(-)
diff --git a/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c b/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c
index 54029283fbbf..f85a05ec06ee 100644
--- a/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c
+++ b/UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c
@@ -27,7 +27,7 @@
///
typedef struct {
UINT32 Signature;
- VOID *AllocatedBufffer;
+ VOID *AllocatedBuffer;
UINTN TotalPages;
VOID *AlignedBuffer;
UINTN AlignedPages;
@@ -165,16 +165,16 @@ AllocateAlignedPages (
//
// We need reserve Alignment pages for PAGE_HEAD, as meta data.
//
- PageHead.Signature = PAGE_HEAD_PRIVATE_SIGNATURE;
- PageHead.TotalPages = Pages + EFI_SIZE_TO_PAGES (Alignment) * 2;
- PageHead.AlignedPages = Pages;
- PageHead.AllocatedBufffer = malloc (EFI_PAGES_TO_SIZE (PageHead.TotalPages));
- if (PageHead.AllocatedBufffer == NULL) {
+ PageHead.Signature = PAGE_HEAD_PRIVATE_SIGNATURE;
+ PageHead.TotalPages = Pages + EFI_SIZE_TO_PAGES (Alignment) * 2;
+ PageHead.AlignedPages = Pages;
+ PageHead.AllocatedBuffer = malloc (EFI_PAGES_TO_SIZE (PageHead.TotalPages));
+ if (PageHead.AllocatedBuffer == NULL) {
return NULL;
}
- PageHead.AlignedBuffer = (VOID *)(((UINTN)PageHead.AllocatedBufffer + AlignmentMask) & ~AlignmentMask);
- if ((UINTN)PageHead.AlignedBuffer - (UINTN)PageHead.AllocatedBufffer < sizeof (PAGE_HEAD)) {
+ PageHead.AlignedBuffer = (VOID *)(((UINTN)PageHead.AllocatedBuffer + AlignmentMask) & ~AlignmentMask);
+ if ((UINTN)PageHead.AlignedBuffer - (UINTN)PageHead.AllocatedBuffer < sizeof (PAGE_HEAD)) {
PageHead.AlignedBuffer = (VOID *)((UINTN)PageHead.AlignedBuffer + Alignment);
}
@@ -279,7 +279,7 @@ FreeAlignedPages (
}
PageHeadPtr->Signature = 0;
- free (PageHeadPtr->AllocatedBufffer);
+ free (PageHeadPtr->AllocatedBuffer);
}
/**
diff --git a/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c b/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c
index a49aaefdb71f..7ff80850ff57 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c
@@ -13,7 +13,7 @@
@retval EFI_SUCCESS Boot device for next boot was set.
@retval EFI_UNSUPPORTED Setting the boot device for the next boot is not
- supportted.
+ supported.
@retval Other Boot device for next boot can not be set.
**/
EFI_STATUS
diff --git a/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c b/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c
index ebb42186a534..8b03e7cd15fc 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c
@@ -20,7 +20,7 @@
@retval EFI_SUCCESS Boot device for next boot was set.
@retval EFI_UNSUPPORTED Setting the boot device for the next boot is not
- supportted.
+ supported.
@retval Other Boot device for next boot can not be set.
**/
EFI_STATUS
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
index 3998aafdf843..35544ff0659a 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
@@ -1,5 +1,5 @@
/**
- Implemnet UnitTestLib log services
+ Implement UnitTestLib log services
Copyright (c) Microsoft Corporation.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
index 64d5880783bf..d095b2f12067 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
@@ -215,7 +215,7 @@ InitUnitTestFramework (
NewFramework = NULL;
//
- // First, check all pointers and make sure nothing's broked.
+ // First, check all pointers and make sure nothing is broken.
//
if ((FrameworkHandle == NULL) || (Title == NULL) ||
(ShortTitle == NULL) || (VersionString == NULL))
diff --git a/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c b/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c
index c02a2dba987d..dd010a75a5a6 100644
--- a/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c
+++ b/UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c
@@ -1,5 +1,5 @@
/** @file
- This is a sample to demostrate the usage of the Unit Test Library that
+ This is a sample to demonstrate the usage of the Unit Test Library that
supports the PEI, DXE, SMM, UEFI SHell, and host execution environments.
Copyright (c) Microsoft Corporation.<BR>
diff --git a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h
index d90bff0e4c1b..de4b9566837b 100644
--- a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h
+++ b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h
@@ -19,7 +19,7 @@
@retval EFI_SUCCESS Boot device for next boot was set.
@retval EFI_UNSUPPORTED Setting the boot device for the next boot is not
- supportted.
+ supported.
@retval Other Boot device for next boot can not be set.
**/
EFI_STATUS
diff --git a/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h b/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h
index adce413818a2..0c0e82de4003 100644
--- a/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h
+++ b/UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h
@@ -18,7 +18,7 @@
#define UNIT_TEST_MAX_STRING_LENGTH (120)
///
-/// The size of a firngerprint used to save/resume execution of a unit test
+/// The size of a fingerprint used to save/resume execution of a unit test
/// framework. This is the size of a CRC32 value which is 32-bit value.
///
///
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index 77d51e13484c..dab416521585 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -81,19 +81,30 @@
"Library/CmockaLib/cmocka/**/*.*" # not going to spell check a submodule
],
"ExtendWords": [ # words to extend to the dictionary for this package
- "testcase",
- "testsuites",
- "cmocka",
+ "assertnotefierror",
+ "assertnotnull",
+ "assertstatusequal",
"buildmodule",
+ "cmocka",
+ "cmockery",
+ "corthon", # Contact GitHub account in Readme
"criterium",
+ "deadloop",
+ "devpath",
+ "DHAVE", # build flag for cmocka in the INF
+ "expectassert",
+ "failuretype",
+ "mdkinney", # Contact GitHub account in Readme
+ "NOFAILURE",
+ "notefierror",
+ "notequal",
"pytool",
"pytools",
- "NOFAILURE",
- "cmockery",
- "DHAVE", # build flag for cmocka in the INF
- "corthon", # Contact GitHub account in Readme
- "mdkinney", # Contact GitHub account in Readme
- "spbrogan" # Contact GitHub account in Readme
+ "spbrogan", # Contact GitHub account in Readme
+ "statusequal",
+ "testcase",
+ "testfailuremsg",
+ "testsuites"
],
"IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
"AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 05/11] FatPkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (3 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 04/11] UnitTestFrameworkPkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 06/11] FmpDevicePkg: " Michael Kubacki
` (5 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
FatPkg/EnhancedFatDxe/FileSpace.c | 2 +-
FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +-
FatPkg/EnhancedFatDxe/Fat.h | 2 +-
FatPkg/FatPkg.ci.yaml | 22 +++++++++++++++-----
4 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c b/FatPkg/EnhancedFatDxe/FileSpace.c
index 909d4980d21a..1220e66598ea 100644
--- a/FatPkg/EnhancedFatDxe/FileSpace.c
+++ b/FatPkg/EnhancedFatDxe/FileSpace.c
@@ -347,7 +347,7 @@ FatSizeToClusters (
@param OFile - The open file.
- @retval EFI_SUCCESS - Shrinked successfully.
+ @retval EFI_SUCCESS - Shrunk successfully.
@retval EFI_VOLUME_CORRUPTED - There are errors in the file's clusters.
**/
diff --git a/FatPkg/EnhancedFatDxe/ReadWrite.c b/FatPkg/EnhancedFatDxe/ReadWrite.c
index 8f525044d1f1..6593e3aff79c 100644
--- a/FatPkg/EnhancedFatDxe/ReadWrite.c
+++ b/FatPkg/EnhancedFatDxe/ReadWrite.c
@@ -580,7 +580,7 @@ FatWriteZeroPool (
if (AppendedSize > FAT_MAX_ALLOCATE_SIZE) {
//
// If the appended size is larger, maybe we can not allocate the whole
- // memory once. So if the growed size is larger than 10M, we just
+ // memory once. So if the grown size is larger than 10M, we just
// allocate 10M memory (one healthy system should have 10M available
// memory), and then write the zerobuffer to the file several times.
//
diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h
index 356cdbdb51af..e4aa8eac62c4 100644
--- a/FatPkg/EnhancedFatDxe/Fat.h
+++ b/FatPkg/EnhancedFatDxe/Fat.h
@@ -867,7 +867,7 @@ FatCleanupVolume (
@param OFile - The open file.
- @retval EFI_SUCCESS - Shrinked successfully.
+ @retval EFI_SUCCESS - Shrunk successfully.
@retval EFI_VOLUME_CORRUPTED - There are errors in the file's clusters.
**/
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
index fe95f481b50c..247028c22921 100644
--- a/FatPkg/FatPkg.ci.yaml
+++ b/FatPkg/FatPkg.ci.yaml
@@ -51,15 +51,27 @@
},
"SpellCheck": {
"ExtendWords": [
+ "bootable",
+ "caseflag",
+ "CDVOL",
+ "checklink",
+ "childlink",
+ "clustersize",
+ "controll",
+ "datacache",
+ "dircachelink",
+ "DMDEPKG",
"ELTORITO",
+ "fatcache",
+ "fatfilesystem",
+ "fatname",
+ "FDISKed",
+ "FFFFFFFFL",
"FHAND",
"IFILE",
- "OFILE",
- "FDISKed",
"Lfnbuffer",
- "FFFFFFFFL",
- "CDVOL",
- "DMDEPKG"
+ "OFILE",
+ "zerobuffer"
]
}
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 06/11] FmpDevicePkg: Fix new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (4 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 05/11] FatPkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 07/11] ArmPkg: Ignore " Michael Kubacki
` (4 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Liming Gao, Michael D Kinney, Guomin Jiang, Wei6 Xu
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change fixes those typos.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 2 +-
FmpDevicePkg/FmpDevicePkg.ci.yaml | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c
index 76a1ee3f40db..c5b6bd18ba44 100644
--- a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c
+++ b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c
@@ -56,7 +56,7 @@ DEPEX_ELEMENT *mDepexEvaluationStackPointer = NULL;
/**
Grow size of the Depex stack
- @retval EFI_SUCCESS Stack successfully growed.
+ @retval EFI_SUCCESS Stack successfully grown.
@retval EFI_OUT_OF_RESOURCES There is not enough system memory to grow the stack.
**/
diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml b/FmpDevicePkg/FmpDevicePkg.ci.yaml
index 1b3e2187356d..81d564876cb4 100644
--- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -60,6 +60,10 @@
"SpellCheck": {
"ExtendWords": [
"FMPSTATE",
+ "lastattemptstatus",
+ "lastattemptversion",
+ "lowestsupportedversion",
+ "updateable"
]
},
"Defines": {
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 07/11] ArmPkg: Ignore new typos reported
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (5 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 06/11] FmpDevicePkg: " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-12-13 10:36 ` Sami Mujawar
2022-05-18 0:13 ` [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
` (3 subsequent siblings)
10 siblings, 1 reply; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
The SpellCheck plugin began reporting new typos that were previously
missed. Due to the number of spelling errors in this package, no
errors are fixed in this change. They are ignored to unblock overall
edk2 CI.
The maintainers should visit the list of extended words for
SpellCheck in ArmPkg.ci.yaml and determine the best resolution for
each item.
The following BZ was filed to track that follow up:
https://bugzilla.tianocore.org/show_bug.cgi?id=3929
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +-
ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 4 +-
ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 2 +-
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +--
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
ArmPkg/ArmPkg.ci.yaml | 53 ++++++++++++++++++--
ArmPkg/Include/Library/OemMiscLib.h | 2 +-
7 files changed, 58 insertions(+), 13 deletions(-)
diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
index d5a1ff0be33c..f3bf08a99e76 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
@@ -146,7 +146,7 @@ ScmiCommandExecute (
/** Internal common function useful for common protocol discovery messages.
@param[in] ProtocolId Protocol Id of the the protocol.
- @param[in] MesaageId Message Id of the message.
+ @param[in] MessageId Message Id of the message.
@param[out] ReturnValues SCMI response return values.
diff --git a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
index 6dae7a9121af..dbd1f6c211ab 100644
--- a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
+++ b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
@@ -202,7 +202,7 @@ THUMB_INSTRUCTIONS gOpThumb[] = {
};
THUMB_INSTRUCTIONS gOpThumb2[] = {
- // Instruct OpCode OpCode Mask Addressig Mode
+ // Instruct OpCode OpCode Mask Addressing Mode
{ "ADR", 0xf2af0000, 0xfbff8000, ADR_THUMB2 }, // ADDR <Rd>, <label> ;Needs to go before ADDW
{ "CMN", 0xf1100f00, 0xfff08f00, CMN_THUMB2 }, // CMN <Rn>, #<const> ;Needs to go before ADD
@@ -648,7 +648,7 @@ DisassembleThumbInstruction (
return;
case DATA_CBZ:
- // CB{N}Z <Rn>, <Lable>
+ // CB{N}Z <Rn>, <Label>
Target = ((OpCode >> 2) & 0x3e) | (((OpCode & BIT9) == BIT9) ? BIT6 : 0);
AsciiSPrint (&Buf[Offset], Size - Offset, " %a, %08x", gReg[Rd], Pc + 4 + Target);
return;
diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
index 5ff8a5b7a62e..9c9a0f1c2ef6 100644
--- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
+++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
@@ -95,7 +95,7 @@ SerialPortWrite (
}
/**
- Read data from serial device and save the datas in buffer.
+ Read data from serial device and save the data in buffer.
@param Buffer Point of data buffer which need to be written.
@param NumberOfBytes Number of output bytes which are cached in Buffer.
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
index d55aff76201e..c61d6f7b772d 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
@@ -31,7 +31,7 @@
return it contains the response parameters.
@param [out] RetVal Pointer to return the response value.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
@@ -134,7 +134,7 @@ SendMemoryPermissionRequest (
@param [in] BaseAddress Base address for the memory region.
@param [out] MemoryAttributes Pointer to return the memory attributes.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
@@ -193,7 +193,7 @@ GetMemoryPermissions (
@param [in] Length Length of the memory region.
@param [in] Permissions Memory access controls attributes.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
index 98970407a65e..355d5882be31 100644
--- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
+++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
@@ -36,7 +36,7 @@ OemGetCpuFreq (
@param ProcessorIndex Index of the processor to get the information for.
@param ProcessorStatus Processor status.
- @param ProcessorCharacteristics Processor characteritics.
+ @param ProcessorCharacteristics Processor characteristics.
@param MiscProcessorData Miscellaneous processor information.
@return TRUE on success, FALSE on failure.
diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
index b7e07aaef675..dccd8fd06b20 100644
--- a/ArmPkg/ArmPkg.ci.yaml
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -93,20 +93,32 @@
], # use gitignore syntax to ignore errors
# in matching files
"ExtendWords": [
- "api's",
"ackintid",
"actlr",
"aeabi",
+ "api's",
+ "armgic",
+ "armltd",
"asedis",
"ashldi",
"ashrdi",
+ "autoreload",
"baddr",
+ "batard",
+ "bootflow",
+ "bootup",
+ "cacheability",
+ "cachetype",
"ccidx",
"ccsidr",
"clidr",
"clrex",
"clzsi",
"cnthctl",
+ "codeview",
+ "commonlpiaff",
+ "comms",
+ "conout",
"cortexa",
"cpacr",
"cpuactlr",
@@ -114,18 +126,21 @@
"ctzsi",
"cygdrive",
"cygpaths",
- "datas",
"dcmpeq",
"dcmpge",
"dcmpgt",
"dcmple",
"dcmplt",
"ddisable",
+ "deadloop",
+ "devicepath",
+ "directlpi",
"divdi",
"divsi",
"dmdepkg",
"dpref",
"drsub",
+ "everyoneelse",
"fcmpeq",
"fcmpge",
"fcmpgt",
@@ -136,6 +151,7 @@
"hisilicon",
"iccabpr",
"iccbpr",
+ "icceior",
"icciar",
"iccicr",
"icciidr",
@@ -143,24 +159,32 @@
"iccpmr",
"iccrpr",
"icdabr",
+ "icddcr",
"icdicer",
"icdicfr",
"icdicpr",
"icdictr",
"icdiidr",
+ "icdipr",
+ "icdiptr",
"icdiser",
"icdisr",
"icdppisr",
"icdsgir",
"icdspr",
"icenabler",
+ "innershr",
"intid",
+ "invall",
"ipriority",
"irouter",
"isenabler",
"istatus",
"itargets",
- "lable",
+ "itstate",
+ "langcode",
+ "langcodes",
+ "largepage",
"ldivmod",
"ldmdb",
"ldmia",
@@ -174,25 +198,37 @@
"ldrsb",
"ldrsbt",
"ldrsh",
+ "ldrsht",
+ "littleendian",
"lshrdi",
+ "memclr",
"moddi",
"modsi",
"mpcore",
"mpidr",
"muldi",
"mullu",
+ "nonsecure",
"nonshareable",
"nsacr",
"nsasedis",
"nuvia",
"oldit",
+ "outershr",
+ "pagetable",
"pcten",
"plpis",
+ "postmem",
+ "premem",
"procno",
"readc",
+ "reglist",
"revsh",
"rfedb",
"sctlr",
+ "semihalf",
+ "setend",
+ "sharelvl",
"smccc",
"smlabb",
"smlabt",
@@ -218,7 +254,13 @@
"strexd",
"strexh",
"strht",
+ "subhierarchy",
+ "subtrack",
+ "subvendor",
+ "supersection",
"switchu",
+ "targetlist",
+ "tmpname",
"tpidrurw",
"ttbcr",
"typer",
@@ -232,7 +274,10 @@
"umodsi",
"usada",
"vlpis",
- "writec"
+ "watchdogtimer",
+ "writeback",
+ "writec",
+ "xectue"
], # words to extend to the dictionary for this package
"IgnoreStandardPaths": [ # Standard Plugin defined paths that
"*.asm", "*.s" # should be ignore
diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
index 47cb30d84a62..b97c60d7507d 100644
--- a/ArmPkg/Include/Library/OemMiscLib.h
+++ b/ArmPkg/Include/Library/OemMiscLib.h
@@ -83,7 +83,7 @@ OemGetCpuFreq (
@param ProcessorIndex Index of the processor to get the information for.
@param ProcessorStatus Processor status.
- @param ProcessorCharacteristics Processor characteritics.
+ @param ProcessorCharacteristics Processor characteristics.
@param MiscProcessorData Miscellaneous processor information.
@return TRUE on success, FALSE on failure.
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2 07/11] ArmPkg: Ignore new typos reported
2022-05-18 0:13 ` [PATCH v2 07/11] ArmPkg: Ignore " Michael Kubacki
@ 2022-12-13 10:36 ` Sami Mujawar
0 siblings, 0 replies; 16+ messages in thread
From: Sami Mujawar @ 2022-12-13 10:36 UTC (permalink / raw)
To: mikuback, devel; +Cc: Leif Lindholm, Ard Biesheuvel
Hi Michael,
Thank you for this patch.
these changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. Due to the number of spelling errors in this package, no
> errors are fixed in this change. They are ignored to unblock overall
> edk2 CI.
>
> The maintainers should visit the list of extended words for
> SpellCheck in ArmPkg.ci.yaml and determine the best resolution for
> each item.
>
> The following BZ was filed to track that follow up:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3929
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +-
> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 4 +-
> ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 2 +-
> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +--
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
> ArmPkg/ArmPkg.ci.yaml | 53 ++++++++++++++++++--
> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
> 7 files changed, 58 insertions(+), 13 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> index d5a1ff0be33c..f3bf08a99e76 100644
> --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> @@ -146,7 +146,7 @@ ScmiCommandExecute (
> /** Internal common function useful for common protocol discovery messages.
>
> @param[in] ProtocolId Protocol Id of the the protocol.
> - @param[in] MesaageId Message Id of the message.
> + @param[in] MessageId Message Id of the message.
>
> @param[out] ReturnValues SCMI response return values.
>
> diff --git a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> index 6dae7a9121af..dbd1f6c211ab 100644
> --- a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> +++ b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> @@ -202,7 +202,7 @@ THUMB_INSTRUCTIONS gOpThumb[] = {
> };
>
> THUMB_INSTRUCTIONS gOpThumb2[] = {
> - // Instruct OpCode OpCode Mask Addressig Mode
> + // Instruct OpCode OpCode Mask Addressing Mode
>
> { "ADR", 0xf2af0000, 0xfbff8000, ADR_THUMB2 }, // ADDR <Rd>, <label> ;Needs to go before ADDW
> { "CMN", 0xf1100f00, 0xfff08f00, CMN_THUMB2 }, // CMN <Rn>, #<const> ;Needs to go before ADD
> @@ -648,7 +648,7 @@ DisassembleThumbInstruction (
> return;
>
> case DATA_CBZ:
> - // CB{N}Z <Rn>, <Lable>
> + // CB{N}Z <Rn>, <Label>
> Target = ((OpCode >> 2) & 0x3e) | (((OpCode & BIT9) == BIT9) ? BIT6 : 0);
> AsciiSPrint (&Buf[Offset], Size - Offset, " %a, %08x", gReg[Rd], Pc + 4 + Target);
> return;
> diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> index 5ff8a5b7a62e..9c9a0f1c2ef6 100644
> --- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> +++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> @@ -95,7 +95,7 @@ SerialPortWrite (
> }
>
> /**
> - Read data from serial device and save the datas in buffer.
> + Read data from serial device and save the data in buffer.
>
> @param Buffer Point of data buffer which need to be written.
> @param NumberOfBytes Number of output bytes which are cached in Buffer.
> diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> index d55aff76201e..c61d6f7b772d 100644
> --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> @@ -31,7 +31,7 @@
> return it contains the response parameters.
> @param [out] RetVal Pointer to return the response value.
>
> - @retval EFI_SUCCESS Request successfull.
> + @retval EFI_SUCCESS Request successful.
> @retval EFI_INVALID_PARAMETER A parameter is invalid.
> @retval EFI_NOT_READY Callee is busy or not in a state to handle
> this request.
> @@ -134,7 +134,7 @@ SendMemoryPermissionRequest (
> @param [in] BaseAddress Base address for the memory region.
> @param [out] MemoryAttributes Pointer to return the memory attributes.
>
> - @retval EFI_SUCCESS Request successfull.
> + @retval EFI_SUCCESS Request successful.
> @retval EFI_INVALID_PARAMETER A parameter is invalid.
> @retval EFI_NOT_READY Callee is busy or not in a state to handle
> this request.
> @@ -193,7 +193,7 @@ GetMemoryPermissions (
> @param [in] Length Length of the memory region.
> @param [in] Permissions Memory access controls attributes.
>
> - @retval EFI_SUCCESS Request successfull.
> + @retval EFI_SUCCESS Request successful.
> @retval EFI_INVALID_PARAMETER A parameter is invalid.
> @retval EFI_NOT_READY Callee is busy or not in a state to handle
> this request.
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 98970407a65e..355d5882be31 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -36,7 +36,7 @@ OemGetCpuFreq (
>
> @param ProcessorIndex Index of the processor to get the information for.
> @param ProcessorStatus Processor status.
> - @param ProcessorCharacteristics Processor characteritics.
> + @param ProcessorCharacteristics Processor characteristics.
> @param MiscProcessorData Miscellaneous processor information.
>
> @return TRUE on success, FALSE on failure.
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..dccd8fd06b20 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -93,20 +93,32 @@
> ], # use gitignore syntax to ignore errors
> # in matching files
> "ExtendWords": [
> - "api's",
> "ackintid",
> "actlr",
> "aeabi",
> + "api's",
> + "armgic",
> + "armltd",
> "asedis",
> "ashldi",
> "ashrdi",
> + "autoreload",
> "baddr",
> + "batard",
> + "bootflow",
> + "bootup",
> + "cacheability",
> + "cachetype",
> "ccidx",
> "ccsidr",
> "clidr",
> "clrex",
> "clzsi",
> "cnthctl",
> + "codeview",
> + "commonlpiaff",
> + "comms",
> + "conout",
> "cortexa",
> "cpacr",
> "cpuactlr",
> @@ -114,18 +126,21 @@
> "ctzsi",
> "cygdrive",
> "cygpaths",
> - "datas",
> "dcmpeq",
> "dcmpge",
> "dcmpgt",
> "dcmple",
> "dcmplt",
> "ddisable",
> + "deadloop",
> + "devicepath",
> + "directlpi",
> "divdi",
> "divsi",
> "dmdepkg",
> "dpref",
> "drsub",
> + "everyoneelse",
> "fcmpeq",
> "fcmpge",
> "fcmpgt",
> @@ -136,6 +151,7 @@
> "hisilicon",
> "iccabpr",
> "iccbpr",
> + "icceior",
> "icciar",
> "iccicr",
> "icciidr",
> @@ -143,24 +159,32 @@
> "iccpmr",
> "iccrpr",
> "icdabr",
> + "icddcr",
> "icdicer",
> "icdicfr",
> "icdicpr",
> "icdictr",
> "icdiidr",
> + "icdipr",
> + "icdiptr",
> "icdiser",
> "icdisr",
> "icdppisr",
> "icdsgir",
> "icdspr",
> "icenabler",
> + "innershr",
> "intid",
> + "invall",
> "ipriority",
> "irouter",
> "isenabler",
> "istatus",
> "itargets",
> - "lable",
> + "itstate",
> + "langcode",
> + "langcodes",
> + "largepage",
> "ldivmod",
> "ldmdb",
> "ldmia",
> @@ -174,25 +198,37 @@
> "ldrsb",
> "ldrsbt",
> "ldrsh",
> + "ldrsht",
> + "littleendian",
> "lshrdi",
> + "memclr",
> "moddi",
> "modsi",
> "mpcore",
> "mpidr",
> "muldi",
> "mullu",
> + "nonsecure",
> "nonshareable",
> "nsacr",
> "nsasedis",
> "nuvia",
> "oldit",
> + "outershr",
> + "pagetable",
> "pcten",
> "plpis",
> + "postmem",
> + "premem",
> "procno",
> "readc",
> + "reglist",
> "revsh",
> "rfedb",
> "sctlr",
> + "semihalf",
> + "setend",
> + "sharelvl",
> "smccc",
> "smlabb",
> "smlabt",
> @@ -218,7 +254,13 @@
> "strexd",
> "strexh",
> "strht",
> + "subhierarchy",
> + "subtrack",
> + "subvendor",
> + "supersection",
> "switchu",
> + "targetlist",
> + "tmpname",
> "tpidrurw",
> "ttbcr",
> "typer",
> @@ -232,7 +274,10 @@
> "umodsi",
> "usada",
> "vlpis",
> - "writec"
> + "watchdogtimer",
> + "writeback",
> + "writec",
> + "xectue"
> ], # words to extend to the dictionary for this package
> "IgnoreStandardPaths": [ # Standard Plugin defined paths that
> "*.asm", "*.s" # should be ignore
> diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
> index 47cb30d84a62..b97c60d7507d 100644
> --- a/ArmPkg/Include/Library/OemMiscLib.h
> +++ b/ArmPkg/Include/Library/OemMiscLib.h
> @@ -83,7 +83,7 @@ OemGetCpuFreq (
>
> @param ProcessorIndex Index of the processor to get the information for.
> @param ProcessorStatus Processor status.
> - @param ProcessorCharacteristics Processor characteritics.
> + @param ProcessorCharacteristics Processor characteristics.
> @param MiscProcessorData Miscellaneous processor information.
>
> @return TRUE on success, FALSE on failure.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (6 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 07/11] ArmPkg: Ignore " Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-12-13 10:38 ` Sami Mujawar
2022-05-18 0:13 ` [PATCH v2 09/11] .azurepipelines: Fix cspell version to v5.20.0 Michael Kubacki
` (2 subsequent siblings)
10 siblings, 1 reply; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar, Gerd Hoffmann
From: Michael Kubacki <michael.kubacki@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This change adds the new words reported to the extended
words list in ArmVirtPkg.ci.yaml.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 25 ++++++++++++--------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index d5d63ddd4fd7..e6963a719ea1 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -101,27 +101,32 @@
"ExtendWords": [
"acpiview",
"armltd",
- "ssdts",
- "setjump",
- "plong",
- "lparam",
- "lpdword",
- "lpthread",
- "lresult",
"bootable",
"bsymbolic",
+ "cloudhv",
+ "devicepath",
"endiannness",
+ "finalise",
"fvmain",
+ "kvmtool",
+ "lparam",
+ "lpdword",
+ "lpthread",
+ "lresult",
"multiboot",
+ "periph",
+ "plong",
+ "prefetchable",
"qemu's",
"ramdisk",
"ramfb",
+ "redist",
+ "setjump",
+ "ssdts",
"unbootable",
"virt's",
"werror",
- "xenio",
- "kvmtool",
- "cloudhv"
+ "xenio"
], # words to extend to the dictionary for this package
"IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
"AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors
2022-05-18 0:13 ` [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
@ 2022-12-13 10:38 ` Sami Mujawar
0 siblings, 0 replies; 16+ messages in thread
From: Sami Mujawar @ 2022-12-13 10:38 UTC (permalink / raw)
To: mikuback, devel; +Cc: Ard Biesheuvel, Leif Lindholm, Gerd Hoffmann, nd@arm.com
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. This change adds the new words reported to the extended
> words list in ArmVirtPkg.ci.yaml.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 25 ++++++++++++--------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..e6963a719ea1 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -101,27 +101,32 @@
> "ExtendWords": [
> "acpiview",
> "armltd",
> - "ssdts",
> - "setjump",
> - "plong",
> - "lparam",
> - "lpdword",
> - "lpthread",
> - "lresult",
> "bootable",
> "bsymbolic",
> + "cloudhv",
> + "devicepath",
> "endiannness",
> + "finalise",
> "fvmain",
> + "kvmtool",
> + "lparam",
> + "lpdword",
> + "lpthread",
> + "lresult",
> "multiboot",
> + "periph",
> + "plong",
> + "prefetchable",
> "qemu's",
> "ramdisk",
> "ramfb",
> + "redist",
> + "setjump",
> + "ssdts",
> "unbootable",
> "virt's",
> "werror",
> - "xenio",
> - "kvmtool",
> - "cloudhv"
> + "xenio"
> ], # words to extend to the dictionary for this package
> "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
> "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 09/11] .azurepipelines: Fix cspell version to v5.20.0
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (7 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 10/11] .pytool/plugin/SpellCheck: Allow compound words Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 11/11] .pytool/plugin/SpellCheck: Add more common words Michael Kubacki
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
From: Michael Kubacki <michael.kubacki@microsoft.com>
The v5.21.0 update introduced a number of new issues that might
impact stable tag integration so this fixes the version to the
previous release.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
This value can be revisited in the future to update the
---
.azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml
index 98ee3cfa6bc6..226909d54c4e 100644
--- a/.azurepipelines/templates/spell-check-prereq-steps.yml
+++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
@@ -17,6 +17,6 @@ steps:
#checkLatest: false # Optional
condition: and(gt(variables.pkg_count, 0), succeeded())
-- script: npm install -g cspell
+- script: npm install -g cspell@5.20.0
displayName: 'Install cspell npm'
condition: and(gt(variables.pkg_count, 0), succeeded())
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 10/11] .pytool/plugin/SpellCheck: Allow compound words
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (8 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 09/11] .azurepipelines: Fix cspell version to v5.20.0 Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
2022-05-18 0:13 ` [PATCH v2 11/11] .pytool/plugin/SpellCheck: Add more common words Michael Kubacki
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
From: Michael Kubacki <michael.kubacki@microsoft.com>
Sets "allowCompoundWords" to "true" to reduce the number of compound
word issues encountered in the future.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.pytool/Plugin/SpellCheck/cspell.base.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index ad6f7ac06ad1..3d4fd71f1612 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,7 +21,7 @@
"*.jpg"
],
"minWordLength": 5,
- "allowCompoundWords": false,
+ "allowCompoundWords": true,
"maxNumberOfProblems": 200,
"maxDuplicateProblems": 200,
"ignoreWords": [
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 11/11] .pytool/plugin/SpellCheck: Add more common words
2022-05-18 0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
` (9 preceding siblings ...)
2022-05-18 0:13 ` [PATCH v2 10/11] .pytool/plugin/SpellCheck: Allow compound words Michael Kubacki
@ 2022-05-18 0:13 ` Michael Kubacki
10 siblings, 0 replies; 16+ messages in thread
From: Michael Kubacki @ 2022-05-18 0:13 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
From: Michael Kubacki <michael.kubacki@microsoft.com>
Appends the word list to reduce the number of errors encountered
by individual packages.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.pytool/Plugin/SpellCheck/cspell.base.yaml | 113 +++++++++++++++++++-
1 file changed, 112 insertions(+), 1 deletion(-)
diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 3d4fd71f1612..f0d579187675 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -178,6 +178,117 @@
"vcruntimed",
"ucrtd",
"msvcrtd",
- "XIPFLAGS"
+ "XIPFLAGS",
+ "bootflow",
+ "bootup",
+ "cacheability",
+ "cachetype",
+ "conout",
+ "deadloop",
+ "devicepath",
+ "hisilicon",
+ "littleendian",
+ "nonsecure",
+ "pagetable",
+ "postmem",
+ "premem",
+ "reglist",
+ "semihalf",
+ "subvendor",
+ "subhierarchy",
+ "targetlist",
+ "tmpname",
+ "watchdogtimer",
+ "writeback",
+ "langcode",
+ "langcodes",
+ "autoreload",
+ "bootable",
+ "endiannness",
+ "fvmain",
+ "prefetchable",
+ "multiboot",
+ "ramdisk",
+ "unbootable",
+ "setjump",
+ "bytecodes",
+ "bytelist",
+ "bytestream",
+ "countof",
+ "deregistering",
+ "devicetree",
+ "mainpage",
+ "mismanipulation",
+ "pytool",
+ "wbinvd",
+ "armltd",
+ "datacache",
+ "lastattemptstatus",
+ "lastattemptversion",
+ "lowestsupportedversion",
+ "updateable",
+ "pecoff",
+ "autodetect",
+ "harddisk",
+ "toctou",
+ "bugbug",
+ "depexes",
+ "fwvol",
+ "hoblist",
+ "imagehandle",
+ "schedulable",
+ "StandaloneMMCore",
+ "systemtable",
+ "uncacheable",
+ "devpath",
+ "testsuites",
+ "testcase",
+ "pxmldoc",
+ "pcxml",
+ "pclutf",
+ "pcunicode",
+ "ntxmltransformcharacter",
+ "ntxmlcomparestrings",
+ "pcxmldoc",
+ "ntxmlfetchcharacterdecoder",
+ "ntxml",
+ "ntxmlspecialstringcompare",
+ "rtlxmlcallback",
+ "xmlef",
+ "osruntime",
+ "readytoboot",
+ "hwerrrec",
+ "xformed",
+ "xform",
+ "undock",
+ "qrencoder",
+ "selawik",
+ "ntxmlrawnextcharacter",
+ "undocked",
+ "reprompt",
+ "yesno",
+ "okcancel",
+ "qrencoding",
+ "qrlevel",
+ "shiftn",
+ "unenroll",
+ "pcxmlstructure",
+ "pxmlstructure",
+ "pcencoder",
+ "pcvoid",
+ "nofailure",
+ "blockio",
+ "lockv",
+ "uefishelldebug",
+ "mtrrcap",
+ "drhds",
+ "rmrrs",
+ "creatorid",
+ "dxeipl",
+ "swmdialogs",
+ "unrecovered",
+ "cmocka",
+ "unenrolling",
+ "unconfigure"
]
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 16+ messages in thread