[PATCH v1 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

[PATCH v1 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

[Li, Zhihao]

From: Zhihao Li <zhihao.li@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3931

Some drivers will break down when they use
SmmWaitForAllProcessor() which from SmmCpuRendezvousLibNull.c.
Removing the code "ASSERT(False)" will make consumer
work normally if they keep default setting for sync mode.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Signed-off-by: Zhihao Li <zhihao.li@intel.com>
---
 MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
index 474195bbb374..769f4c673802 100644
--- a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
+++ b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
@@ -24,6 +24,5 @@ SmmWaitForAllProcessor (
   IN BOOLEAN  BlockingMode
   )
 {
-  ASSERT (FALSE);
   return EFI_SUCCESS;
 }
-- 
2.26.2.windows.1

回复: [PATCH v1 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: zhihaoli <zhihao.li@intel.com>
> 发送时间: 2022年5月18日 20:02
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: [PATCH v1 1/1] MdePkg: Remove "assert" from
> SmmCpuRendevousLibNull.c
> 
> From: Zhihao Li <zhihao.li@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3931
> 
> Some drivers will break down when they use
> SmmWaitForAllProcessor() which from SmmCpuRendezvousLibNull.c.
> Removing the code "ASSERT(False)" will make consumer
> work normally if they keep default setting for sync mode.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> ---
>  MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git
> a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> index 474195bbb374..769f4c673802 100644
> ---
> a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> +++
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> @@ -24,6 +24,5 @@ SmmWaitForAllProcessor (
>    IN BOOLEAN  BlockingMode
> 
>    )
> 
>  {
> 
> -  ASSERT (FALSE);
> 
>    return EFI_SUCCESS;
> 
>  }
> 
> --
> 2.26.2.windows.1