From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.27696.1653313508708223803 for ; Mon, 23 May 2022 06:45:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T3fwb30J; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653313507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sh+N2RyDSbjpd/PxGj8sdqpgRPipxza8HI0uiDvlRf8=; b=T3fwb30JdJfAAsnv6JrEgo+KRZhGMLcoBLJHP+nIAykquP5htWZYfC+Ic/RJtTXGeMsL6r fNABP+Bh++XYNaGg+eBm77Vuw+XoC2fb4v9WtZ83bmganrzOQqQV3lCY7s3GcFjqNAzobJ iOllONY7DWdH4sm8c0Wufi+j+gfr48A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-hJIY2ajXNoC1wElKFFCJMg-1; Mon, 23 May 2022 09:45:06 -0400 X-MC-Unique: hJIY2ajXNoC1wElKFFCJMg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48D0B100BAAC for ; Mon, 23 May 2022 13:45:06 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14522492C14; Mon, 23 May 2022 13:45:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BDB2618000B4; Mon, 23 May 2022 15:45:04 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Pawel Polawski , Oliver Steffen , Gerd Hoffmann , Laszlo Ersek Subject: [PATCH 1/1] OvmfPkg: fix PcdFSBClock Date: Mon, 23 May 2022 15:45:04 +0200 Message-Id: <20220523134504.1304459-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. Fix all affected build configurations. Not changed: Microvm and Cloudhw (they have already have the correct value), and Xen (has no fixed frequency, the PCD is configured at runtime by platform initialization code). Fixes: c37cbc030d96 ("OvmfPkg: Switch timer in build time for OvmfPkg") Reported-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index bead9722eab8..fc1fdb2e2297 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc @@ -578,7 +578,7 @@ [PcdsDynamicDefault] !include OvmfPkg/OvmfTpmPcds.dsc.inc - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 [PcdsDynamicHii] !include OvmfPkg/OvmfTpmPcdsHii.dsc.inc diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc index 00bc1255bc4e..dd8d446f4a56 100644 --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc @@ -511,7 +511,7 @@ [PcdsDynamicDefault] # Set ConfidentialComputing defaults gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 ################################################################################ # diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index c16a840fff16..a9841cbfc3ca 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -651,7 +651,7 @@ [PcdsDynamicDefault] gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicHii] diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index d3a80cb56892..f7949780fa38 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -659,7 +659,7 @@ [PcdsDynamicDefault] gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicDefault.X64] diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 7b3d48aac430..1448f925b782 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -684,7 +684,7 @@ [PcdsDynamicDefault] gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicHii] -- 2.35.3