Re: [PATCH 1/1] OvmfPkg/VirtioGpuDxe: replace struct copy with CopyMem call

["Gerd Hoffmann" <kraxel@redhat.com>]

On Mon, May 30, 2022 at 11:32:03AM +0200, Ard Biesheuvel wrote:
> Hi Gerd,
> 
> On Mon, 30 May 2022 at 11:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > Buildfix for `-t CLANG38 -b NOOPT -p OvmfPkg/OvmfPkgX64.dsc`.
> >
> > Fixes: 5f6ecaa398ba ("OvmfPkg/VirtioGpuDxe: use GopQueryMode in GopSetMode")
> > Reported-by: Rebecca Cran <quic_rcran@quicinc.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  OvmfPkg/VirtioGpuDxe/Gop.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c
> > index 70a81c10c8b5..18b29e5a23d2 100644
> > --- a/OvmfPkg/VirtioGpuDxe/Gop.c
> > +++ b/OvmfPkg/VirtioGpuDxe/Gop.c
> > @@ -509,7 +509,7 @@ GopSetMode (
> >    // Populate Mode and ModeInfo (mutable fields only).
> >    //
> >    VgpuGop->GopMode.Mode = ModeNumber;
> > -  VgpuGop->GopModeInfo  = *GopModeInfo;
> > +  CopyMem(&VgpuGop->GopModeInfo, GopModeInfo, sizeof(*GopModeInfo));
> 
> Mind if I change this to
> 
> CopyMem (&VgpuGop->GopModeInfo, GopModeInfo, sizeof VgpuGop->GopModeInfo);

No (that's what running uncrustify would have done I guess?)

thanks,
  Gerd